-
Notifications
You must be signed in to change notification settings - Fork 4k
[No QA] Add GPS key to Onyx #77249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Add GPS key to Onyx #77249
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /** | ||
| * Stores data from GPS trip (GPS distance request) | ||
| */ | ||
| type GpsDraftDetails = { | ||
| /** Captured GPS points */ | ||
| gpsPoints: Array<{ | ||
| /** Latitude */ | ||
| lat: number; | ||
| /** Longitude */ | ||
| long: number; | ||
| }>; | ||
|
|
||
| /** Sum of geodesic distances between all consecutive points from gpsPoints in meters */ | ||
| distanceInMeters: number; | ||
|
|
||
| /** Start address derived from coordinates of the first point from gpsPoints */ | ||
| startAddress: { | ||
| /** Start address string shown to the user */ | ||
| value: string; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the type is coordinates, I think the value shouldn't be a string, right?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It should be, as in case of |
||
| /** Is start address value a human readable address or stringified coordinates */ | ||
| type: 'coordinates' | 'address'; | ||
| }; | ||
|
|
||
| /** End address derived from coordinates of the last point from gpsPoints */ | ||
| endAddress: { | ||
| /** End address string shown to the user */ | ||
| value: string; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as above
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Answered above |
||
| /** Is end address value a human readable address or stringified coordinates */ | ||
| type: 'coordinates' | 'address'; | ||
| }; | ||
|
|
||
| /** Is GPS trip in progress */ | ||
| isTracking: boolean; | ||
| }; | ||
|
|
||
| export default GpsDraftDetails; | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks