[No QA] Update Commercial-feeds.md

[dylanexpensify]

Explanation of Change

Updating helpDot page with new improvements for New Expensify Corporate Card feed management

Fixed Issues

https://github.com/Expensify/Expensify/issues/576486

--->
$
PROPOSAL:

Tests

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[OSBotify]

A preview of your ExpensifyHelp changes have been deployed to https://26af98a8.helpdot.pages.dev ⚡️

Updated articles:

• articles/new-expensify/connect-credit-cards/Commercial-feeds

[dylanexpensify]

@sakluger went ahead and updated this PR to remove the assigning card management piece. Following up with another PR for creating its own page as we discussed in DD!

[melvin-bot]

Concierge reviewer checklist:

• I have verified the accuracy of the article
  • The article is within a hub that makes sense, and the navigation is correct
  • All processes, screenshots, and examples align with current product behavior.
  • All links within the doc have been verified for correct destination and functionality.
• I have verified the readability of the article
  • The article's language is clear, concise, and free of jargon.
  • The grammar, spelling, and punctuation are correct.
  • The article contains at least one image, or that an image is not necessary
• I have verified the formatting of the article
  • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
  • The article has proper text spacing and breaks for readability.
• I have verified the article has the appropriate tone and style
  • The article's tone is professional, friendly, and suitable for the target audience.
  • The article's tone, terminology, and voice are consistent throughout.
• I have verified the overall quality of the article
  • The article is not missing any information, nor does it contain redundant information.
  • The article fully addresses user needs.
• I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @VictoriaExpensify

[melvin-bot]

@VictoriaExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

@sakluger looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[sakluger]

According to https://stackoverflowteams.com/c/expensify/questions/20516/20517#20517, we do not need to complete the PR checklists for help doc changes.

[github-actions]

AI Readiness violation: Heading uses generic phrase "employees" without context. Consider "Assign commercial cards to workspace members" to be more specific and align with Expensify terminology (use "members" instead of "employees").

[github-actions]

AI Readiness violation: Vague heading "Where to find the company card assignment table" - doesn't include the feature name for context. Consider "Where to find Company Cards in your workspace" to be more descriptive and searchable.

[github-actions]

HelpDot Documentation Review

Overall Assessment

This PR removes duplicate content from the Commercial Card Feeds documentation. The "Assign Company Cards" section (23 lines) was appearing twice in the document - once in the middle and once near the end. The author correctly removed the first occurrence while preserving the section in its proper location at the end of the setup instructions. This is a straightforward documentation cleanup that improves organization and eliminates redundancy.

Scores Summary

• Readability: 9/10 - The remaining content is clear, well-structured, and follows a logical flow from setup to management to FAQs. The removal of duplicate content actually improves readability by eliminating confusion.
• AI Readiness: 8/10 - The document uses descriptive headings ("Set up a Mastercard Commercial Feed", "Assign Company Cards"), includes proper YAML metadata with relevant keywords, and maintains clear context throughout. Minor improvement could be made with more explicit breadcrumb references.
• Style Compliance: 8/10 - The document adheres to Expensify documentation standards with proper terminology (workspace, member, Company Cards), clear navigation paths, consistent markdown formatting, and appropriate use of heading hierarchy (# and ##).

Key Findings

Positive Aspects:

• Correctly identified and removed duplicate content without disrupting document flow
• The remaining "Assign Company Cards" section is in the appropriate location (after setup instructions)
• All three card feed types (Mastercard, Visa, Amex) maintain consistent formatting and structure
• Clear step-by-step instructions with specific technical details (Distribution IDs, file formats, etc.)
• Well-organized FAQ section addresses common questions

Minor Issues Identified:

• Line 70: Formatting inconsistency - "5. 3. In Expensify" appears to have duplicate numbering (should be "5." or "3." not both)
• The document could benefit from a clearer visual separation between the three setup sections and the card management sections

Note on Content Migration:
Based on PR comments, this deletion is part of a larger restructuring effort where card assignment/management content will be moved to a dedicated page. This is a sound documentation architecture decision.

Recommendations

1. Fix numbering error: Correct the duplicate numbering on line 70 in the Amex section before or after merge
2. Consider cross-references: When the new dedicated card management page is created, add cross-reference links between the setup and management documentation
3. Monitor for consistency: Ensure the Direct Feeds documentation (which has similar card assignment content) is updated in the same manner to maintain consistency

Files Reviewed

• docs/articles/new-expensify/connect-credit-cards/Commercial-feeds.md - Approved with minor suggestion (duplicate content successfully removed, one numbering issue noted)

---

Overall Recommendation: This PR successfully achieves its goal of removing duplicate content. The documentation quality remains high after this change. The minor numbering issue on line 70 should be addressed, but does not block approval.

Note: This is a comprehensive summary review of the PR's documentation changes.

[github-actions]

HelpDot Review Summary

I reviewed the documentation changes in this PR. Here are my findings:

Violations in Deleted Content (Being Fixed by Removal)

The section being deleted contained:

• Terminology violation (line 78): Used "employees" instead of "members" - this is being fixed by the deletion ✓

Pre-existing Violations (Not Part of This PR)

The following violations exist in the file but are not being addressed by this PR:

American Express Section (lines 70-72)

• Numbering violation: Sequential numbering is broken:
  • Line 70: Shows "5. 3." (should be "5.")
  • Line 71: Shows "4." (should be "6.")
  • Line 72: Shows "7." (correct number, wrong sequence)

Manage Commercial Card Settings Section (line 101)

• AI Readiness violation: Contains vague reference "[Card Name]" without clear context. Consider rephrasing for clarity.

Recommendation

Since this PR is removing content, it is improving the documentation. However, consider addressing the pre-existing numbering violations in the Amex section in a follow-up update.

[OSBotify]

🚀 Deployed to staging by https://github.com/sakluger in version: 9.2.85-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.85-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅