[No QA] Patch Sentry htmlTreeAsString to support data-sentry-label attributes by dariusz-biela · Pull Request #76547 · Expensify/App

dariusz-biela · 2025-12-02T16:48:38Z

Explanation of Change

This PR adds data-sentry-label attribute support to Sentry's htmlTreeAsString function via a patch to @sentry/core. This allows us to identify UI interactions in Sentry spans using meaningful labels instead of just CSS selectors.

Changes:

Sentry patch (@sentry+core+10.20.0+001+data-sentry-label-support.patch): Modifies htmlTreeAsString to include data-sentry-label in element identification and search up to 15 levels up the DOM tree for this attribute
GenericPressable: Added sentryLabel prop that renders as data-sentry-label attribute on pressable elements
NavigationTabBar: Added sentryLabel to tab bar buttons and avatar for better INP tracking

Usage example:

<PressableWithFeedback
    sentryLabel="NavigationTabBar-Reports"
    onPress={handlePress}
>
    <Icon src={Home} />
</PressableWithFeedback>

Example output: [data-sentry-label="NavigationTabBar-Reports"] div.css-146c3p1 > svg instead of just div.css-146c3p1 > svg

Fixed Issues

$ #76128
PROPOSAL:

Tests

Open the file: src/setup/telemetry/debugTransport.ts
Set the following constants:

/**
 * Enable this to log Sentry telemetry data to console instead of sending to Sentry servers.
 */
const DEBUG_SENTRY_ENABLED = true;

/**
 * List of span operations to highlight in debug logs.
 * Add span.op values here to see detailed logs for specific operations.
 * Note: span.op in code corresponds to span.name in Sentry dashboard.
 * Example: ['ui.interaction.click', 'ui.interaction.scroll', 'ui.load', 'navigation']
 */
const HIGHLIGHTED_SPAN_OPS: string[] = ['ui.interaction.click'];

Run the development environment.
Perform several clicks on main navigation.

Open a new tab or switch to another tab in browser.

Note: This step is required because INP (Interaction to Next Paint) metrics are only sent to Sentry when the page visibility changes (e.g., tab switch, minimize, or page close). This is an optimization in the web-vitals library to batch interactions and report the final P98 value.

Details on how INP is calculated
To give a better measure of the actual responsiveness for pages with a high number of interactions, we ignore one highest interaction for every 50 interactions. The vast majority of page experiences don't have over 50 interactions, so the worst interaction is most often reported. The 75th percentile of all page views is then reported as usual, which further removes outliers to give a value that the vast majority of users experience or better.
Source https://web.dev/articles/inp

Go back to thedev.new.expensify.com tab.
Check the console for logs starting with [SENTRY][SPAN][ui.interaction.click]. It should look like:

{
      "description": "[data-sentry-label=\"NavigationTabBar-Inbox\"] div.css-view-g5y9jx > div.css-view-g5y9jx > svg > path",
      "measurements": {
          "inp": {
              "value": 800,
              "unit": "millisecond"
          }
      }
}

Verify that no errors appear in the JS console

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Android: Native

iOS: Native

MacOS: Chrome / Safari

…els-patch

github-actions · 2025-12-02T16:48:48Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

# Conflicts: # src/setup/telemetry/index.ts

codecov · 2025-12-03T11:24:36Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`85.84% <ø> (ø)`
src/components/Button/index.tsx	`89.92% <ø> (ø)`
src/components/Checkbox.tsx	`88.88% <ø> (ø)`
...c/components/Navigation/NavigationTabBar/index.tsx	`50.39% <ø> (ø)`
src/pages/home/sidebar/NavigationTabBarAvatar.tsx	`100.00% <ø> (ø)`
...ressable/GenericPressable/implementation/index.tsx	`0.00% <0.00%> (ø)`
... and 5 files with indirect coverage changes

dariusz-biela · 2025-12-03T12:42:37Z

I'm currently working on preparing an upstream PR for Sentry.

In the meantime, I'm submitting this PR as ready for review to see if the solution I'm presenting is okay.

melvin-bot · 2025-12-03T12:42:50Z

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify · 2025-12-03T12:58:57Z

PR doesn’t need product input as a perf tooling PR. Unassigning and unsubscribing myself.

…mponent/sentryElement

# Conflicts: # src/CONST/index.ts

dariusz-biela · 2025-12-08T15:54:02Z

Example spans created using code from this PR in sentry dashboard:

rlinoz · 2025-12-08T19:32:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2025-12-08T20:12:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-09T15:30:15Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.74-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-10T21:39:24Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-12-10T21:55:38Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-12-10T23:00:03Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

dariusz-biela added 6 commits November 27, 2025 15:10

feat: enable reactComponentAnnotation for sentry in webpack

b5d55a3

chore: add sentry REQUEST local logging

ce659dd

feat: adds patch @sentry+core+10.20.0+001+data-label-support.patch

109e4cd

feat: adds prop sentryLabel to GenericPressable

6d8f422

feat: adds usage sentryLabel in NavigationTabBar

4de24cb

Merge branch 'refs/heads/main' into dariusz-biela/perf/sentry/inp-lab…

4f4d54a

…els-patch

melvin-bot Bot assigned dariusz-biela Dec 2, 2025

dariusz-biela added 3 commits December 3, 2025 11:43

Merge branch 'main' into dariusz-biela/perf/sentry/inp-labels-patch

27b56cb

# Conflicts: # src/setup/telemetry/index.ts

fix: updates sentry-core patch version

b985cb5

fix: updates sentry-core patch version details.md

a940644

dariusz-biela changed the title ~~Add data-label attribute support to Sentry htmlTreeAsString~~ [No QA] Add data-label attribute support to Sentry htmlTreeAsString Dec 3, 2025

dariusz-biela changed the title ~~[No QA] Add data-label attribute support to Sentry htmlTreeAsString~~ [No QA] Patch Sentry htmlTreeAsString to support data-label attributes Dec 3, 2025

sumo-slonik reviewed Dec 3, 2025

View reviewed changes

Comment thread patches/sentry-core/details.md Outdated

sumo-slonik approved these changes Dec 3, 2025

View reviewed changes

fix: updates sentry-core patch details with issue and PR links

0ed19ea

dariusz-biela marked this pull request as ready for review December 3, 2025 12:42

dariusz-biela requested review from a team as code owners December 3, 2025 12:42

melvin-bot Bot requested review from FitseTLT and removed request for a team December 3, 2025 12:42

melvin-bot Bot requested review from trjExpensify and removed request for a team December 3, 2025 12:42

trjExpensify removed their request for review December 3, 2025 12:59

dariusz-biela added 2 commits December 3, 2025 13:59

fix: removes reactComponentAnnotation from Sentry webpack plugin config

15842ef

fix: updates sentry-core patch to prioritize data-label over sentryCo…

e9abc7b

…mponent/sentryElement

war-in approved these changes Dec 3, 2025

View reviewed changes

Comment thread src/components/Navigation/NavigationTabBar/index.tsx Outdated

Comment thread patches/sentry-core/details.md Outdated

dariusz-biela added 4 commits December 5, 2025 14:30

docs: add upstream PR link to sentry-core patch details

57addb3

refactor: move sentryLabel constants to CONST.SENTRY_LABEL

3aa856f

Merge branch 'main' into dariusz-biela/perf/sentry/inp-labels-patch

eaf25ec

# Conflicts: # src/CONST/index.ts

refactor: rename data-label to data-sentry-label

ff19756

dariusz-biela changed the title ~~[No QA] Patch Sentry htmlTreeAsString to support data-label attributes~~ [No QA] Patch Sentry htmlTreeAsString to support data-sentry-label attributes Dec 5, 2025

rlinoz self-requested a review December 8, 2025 11:59

rlinoz approved these changes Dec 8, 2025

View reviewed changes

rlinoz merged commit 85231c0 into Expensify:main Dec 8, 2025
39 of 40 checks passed

OSBotify mentioned this pull request Dec 9, 2025

Deploy Checklist: New Expensify 2025-12-09 #77123

Closed

dariusz-biela mentioned this pull request Dec 11, 2025

[Sentry] Extending Sentry Analysis to Systematically Reduce High INP Events #76128

Open

quinthar added the #quality label Aug 11, 2026

Conversation

dariusz-biela commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Dec 2, 2025

Uh oh!

codecov Bot commented Dec 3, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

dariusz-biela commented Dec 3, 2025

Uh oh!

melvin-bot Bot commented Dec 3, 2025

Uh oh!

trjExpensify commented Dec 3, 2025

Uh oh!

Uh oh!

Uh oh!

dariusz-biela commented Dec 8, 2025

Uh oh!

rlinoz commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Dec 8, 2025

Uh oh!

OSBotify commented Dec 9, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dariusz-biela commented Dec 2, 2025 •

edited

Loading

codecov Bot commented Dec 3, 2025 •

edited by github-actions Bot

Loading

rlinoz commented Dec 8, 2025 •

edited

Loading