Conversation
|
@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppcard-android.movAndroid: mWeb Chromecard-mweb.moviOS: HybridAppcard-ios.mp4iOS: mWeb Safaricard-safari.mp4MacOS: Chrome / Safaricard-web.mov |
…uble-action-on-row-card-click [CP staging] Do not trigger both actions on card row click (cherry picked from commit c4677c2) (cherry-picked to staging by grgia)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.2.67-3 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.2.67-10 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.2.70-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.70-0 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.2.71-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.71-5 🚀
|
Explanation of Change
Fixed Issues
$ #76493
PROPOSAL:
Tests
Prerequisites: have an account with an Expensify Card assigned
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-12-02.at.10.50.11.mp4