fix: blank white space is shown below the composer - #76482
Conversation
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Code Review SummaryI've reviewed PR #76482. The change is small and focused, addressing the blank white space issue below the composer when sharing logs by dismissing the keyboard before attaching the log. Overall Assessment: ✅ The implementation looks good and follows common patterns in the codebase for dismissing the keyboard before navigation or modal actions. Key Points:
No critical issues found. The PR is ready for approval. |
trjExpensify
left a comment
There was a problem hiding this comment.
Minor troubleshooting log issue 👍
|
@daledah could you merge from main to fix the TS check failing |
|
@abdulrahuman5196 i fixed |
|
@daledah When i merge from main and run this code i am getting this issue. Can you check on this? Screen.Recording.2025-12-08.at.6.55.36.PM.mov |
|
@abdulrahuman5196 i don't get this issue. I merged main again, could you please test again? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-12-10.at.11.39.13.PM.movAndroid: mWeb ChromeScreen.Recording.2025-12-10.at.11.41.20.PM.moviOS: HybridAppScreen.Recording.2025-12-11.at.12.03.02.AM.moviOS: mWeb SafariScreen.Recording.2025-12-10.at.11.43.52.PM.movMacOS: Chrome / SafariScreen.Recording.2025-12-10.at.11.44.55.PM.mov |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @youssef-lr
🎀 👀 🎀
C+ Reviewed
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.2.78-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀
|
Explanation of Change
Fixed Issues
$ #74719
PROPOSAL: #74719 (comment)
Tests
Offline tests
Same as tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
andm.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
we.mov