[No-QA] Bumping node to 20.19.5 - #76451
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. |
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@chiragsalian looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Not an emergency, its common to see some of the test fail when we upgrade node version in App Repo during QSP. Its usually a non issue, but i've posted here as well for awareness incase we need a follow up action. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[No-QA] Bumping node to 20.19.5 (cherry picked from commit 2b392b9) (cherry-picked to staging by chiragsalian)
|
🚀 Cherry-picked to staging by https://github.com/chiragsalian in version: 9.2.67-11 🚀
|
1 similar comment
|
🚀 Cherry-picked to staging by https://github.com/chiragsalian in version: 9.2.67-11 🚀
|
[No-QA] Bumping node to 20.19.5 (cherry picked from commit 2b392b9) (cherry-picked to production by mountiny)
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.2.69-0 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.70-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.70-0 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.71-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.71-5 🚀
|
Explanation of Change
Bumps node to the latest version
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/571958
$
PROPOSAL:
Tests
None
Offline tests
None
QA Steps
None
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari