Skip to content

[CP Staging] Revert "Make AddUnreportedExpense use new SelectionList" - #76275

Merged
mountiny merged 1 commit into
Expensify:mainfrom
software-mansion-labs:@OlGierd03/revert-migrate-AddUnreportedExpense
Nov 28, 2025
Merged

mountiny merged 1 commit into
Expensify:mainfrom
software-mansion-labs:@OlGierd03/revert-migrate-AddUnreportedExpense

Conversation

@OlGierd03

Copy link
Copy Markdown
Contributor

Reverts #75891

The reverted PR added 2 deploy blockers and is currently undergoing consultation regarding the design changes that were introduced.

Deploy blockers:

@mountiny mountiny changed the title Revert "Make AddUnreportedExpense use new SelectionList" [CP Staging] Revert "Make AddUnreportedExpense use new SelectionList" Nov 28, 2025
@OlGierd03
OlGierd03 marked this pull request as ready for review November 28, 2025 13:11
@OlGierd03
OlGierd03 requested review from a team as code owners November 28, 2025 13:11
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and nkuoch and removed request for a team November 28, 2025 13:11
@melvin-bot

melvin-bot Bot commented Nov 28, 2025

Copy link
Copy Markdown

@nkuoch Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the revert changes are right

@mountiny
mountiny merged commit a94d3c3 into Expensify:main Nov 28, 2025
28 of 31 checks passed
@melvin-bot

melvin-bot Bot commented Nov 28, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny

Copy link
Copy Markdown
Contributor

Straight revert, not an emergency

@codecov

codecov Bot commented Nov 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/pages/AddUnreportedExpense.tsx 0.00% <0.00%> (ø)
... and 29 files with indirect coverage changes

@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 28, 2025
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

mountiny added a commit that referenced this pull request Nov 28, 2025
…t-migrate-AddUnreportedExpense

[CP Staging] Revert "Make AddUnreportedExpense use new SelectionList"

(cherry picked from commit a94d3c3)

(cherry-picked to staging by mountiny)
mountiny added a commit that referenced this pull request Nov 28, 2025
…765400767-1

🍒 Cherry pick PR #76275 to staging 🍒
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.65-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.65-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.66-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Dec 1, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.2.66-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants