Fix issue where </li> <li> creates a new line. by Rkdev09 · Pull Request #76009 · Expensify/App

Rkdev09 · 2025-11-25T11:06:04Z

Explanation of Change

Fixed Issues

$ #75697
PROPOSAL: #75697 (comment)

Tests

Create a new account
Go to Concierge chat
Write Please give me "create an expense" steps in dot list style and send
Wait for the reply
Expected: The bullet points list should be styled correctly

Verify that no errors appear in the JS console

Offline tests

Can't login and chat when offline

QA Steps

Same as tests
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

REC-20251126173605.mp4

Android: mWeb Chrome

REC-20251126174715.mp4

iOS: Native

REC-20251126175947.mp4

iOS: mWeb Safari

REC-20251126175538.mp4

MacOS: Chrome / Safari

REC-20251126180357.mp4

github-actions · 2025-11-25T11:06:16Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

Rkdev09 · 2025-11-25T11:06:47Z

I have read the CLA Document and I hereby sign the CLA

Rkdev09 · 2025-11-25T11:08:02Z

I have read the CLA Document and I hereby sign the CLA

melvin-bot · 2025-11-25T11:09:19Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Rkdev09 · 2025-11-25T11:10:12Z

@dukenv0307 could you please let me know how can I re-run the CLA check and what should I write in testing steps?

Rkdev09 · 2025-11-25T11:10:46Z

recheck

dukenv0307 · 2025-11-25T14:14:09Z

@Rkdev09 you can read other PR to see how they do that

dukenv0307 · 2025-11-26T04:35:09Z

@Rkdev09 kindly bump

dukenv0307 · 2025-11-26T04:52:06Z

Your solution works on iOS native

But doesn't work on Android native

Rkdev09 · 2025-11-26T06:55:07Z

@dukenv0307 I will start working on this in an hour.

Rkdev09 · 2025-11-26T11:23:37Z

Checking the android issue, will have an update soon.

Rkdev09 · 2025-11-26T12:07:49Z

@dukenv0307 worked for me on android app after merging main.

Please check

REC-20251126173605.mp4

Rkdev09 · 2025-11-26T12:38:15Z

@dukenv0307 I have added the platform videos. If you find any other issues, please ping me. I will try my best to fix them as soon as possible.

dukenv0307 · 2025-11-26T14:39:31Z

If there's no issue, you can open the PR

dukenv0307 · 2025-11-27T08:39:24Z

@Rkdev09 It doesn't work on Android. Here's my HTML string:

<strong>Here are the steps in a dot (bullet) list style:</strong><br><br> <ul>   <li>Click the green <strong>+</strong> (Create) button in the navigation.</li>   <li>Select <strong>Create expense</strong>.</li>   <li>Choose <strong>Manual</strong>.</li>   <li>Enter the <strong>amount</strong> and choose the <strong>currency</strong>, then click <strong>Next</strong>.</li>   <li>Select who it’s for: a <strong>workspace</strong> (business) or an <strong>individual</strong> (personal/payment).</li>   <li>Fill in any extra details you need, like <strong>category</strong>, <strong>tags</strong>, or <strong>description</strong>.</li>   <li>Click <strong>Create expense</strong> to save it.</li> </ul> <br> For more detail, you can also review <a href="https://help.expensify.com/articles/new-expensify/reports-and-expenses/Create-an-Expense">Create an Expense</a>.

Rkdev09 · 2025-11-27T14:30:08Z

Thanks for the code, I will try this tomorrow morning.

…

On Thu, 27 Nov, 2025, 2:09 pm dukenv0307, ***@***.***> wrote: *dukenv0307* left a comment (Expensify/App#76009) <#76009 (comment)> @Rkdev09 <https://github.com/Rkdev09> It doesn't work on Android. Here's my HTML string: Here are the steps in a dot (bullet) list style: <ul> <li>Click the green + (Create) button in the navigation.</li> <li>Select Create expense.</li> <li>Choose Manual.</li> <li>Enter the amount and choose the currency, then click Next.</li> <li>Select who it’s for: a workspace (business) or an individual (personal/payment).</li> <li>Fill in any extra details you need, like category, tags, or description.</li> <li>Click Create expense to save it.</li> </ul> For more detail, you can also review <a href="https://help.expensify.com/articles/new-expensify/reports-and-expenses/Create-an-Expense">Create an Expense</a>. — Reply to this email directly, view it on GitHub <#76009 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BZE3E6EYUQQGVXHLSPDHUZ33622FJAVCNFSM6AAAAACNEFIUJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTKOBUG4ZTSNRYGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

Rkdev09 · 2025-11-28T13:01:44Z

I can now reproduce the issue on android app. Looking for a solution to fix that asap.

Signed-off-by: Rkmishra09 <ritikamishra5822@gmail.com>

Rkdev09 · 2025-11-28T13:33:40Z

@dukenv0307 removing this line fixes the issue, maybe convertToLTR is blocking the fix on android app. convertToLTR is only for android. I'm finding a solution for that.

App/src/components/HTMLEngineProvider/BaseHTMLEngineProvider.tsx

Lines 222 to 225 in a94d3c3

    
           domVisitors={{ 
        
               // eslint-disable-next-line no-param-reassign 
        
               onText: (text) => (text.data = convertToLTR(text.data)), 
        
           }}

Signed-off-by: Rkmishra09 <ritikamishra5822@gmail.com>

Rkdev09 · 2025-11-30T14:15:05Z

Android issue is fixed and I have tested it. If other thing comes up, do let me know @dukenv0307. Thank you 🙏

dukenv0307 · 2025-12-01T08:04:37Z

Your solution works on my side

dukenv0307 · 2025-12-01T08:10:05Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-01.at.15.03.29.mov

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2025-12-01.at.15.09.42.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2025-12-01T19:05:35Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ents/HTMLEngineProvider/BaseHTMLEngineProvider.tsx	`88.67% <100.00%> (+0.21%)`	⬆️
src/styles/index.ts	`46.92% <ø> (+1.27%)`	⬆️
... and 419 files with indirect coverage changes

thienlnam · 2025-12-01T19:23:26Z

I feel like this test is flakey, the changes here should have no impact to that, so going to merge

FAIL tests/unit/ValidationUtilsTest.ts
  ● ValidationUtils › isValidExpirationDate › Should return true for a valid formats expiration date in the future

    expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

      146 |             const thirdFutureExpirationDate = '1225'; // MMYY format, in the future
      147 |             const fourthFutureExpirationDate = '122025'; // MMYYYY format, in the future
    > 148 |             expect(isValidExpirationDate(firstFutureExpirationDate)).toBe(true);
          |                                                                      ^
      149 |             expect(isValidExpirationDate(secondFutureExpirationDate)).toBe(true);
      150 |             expect(isValidExpirationDate(thirdFutureExpirationDate)).toBe(true);
      151 |             expect(isValidExpirationDate(fourthFutureExpirationDate)).toBe(true);

      at Object.toBe (tests/unit/ValidationUtilsTest.ts:148:70)

melvin-bot · 2025-12-01T19:23:41Z

@thienlnam looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

thienlnam · 2025-12-01T19:26:24Z

#76009 (comment)

OSBotify · 2025-12-01T19:49:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-01T23:44:32Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.2.67-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-03T13:57:11Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 9.2.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-03T14:52:38Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot Bot assigned Rkdev09 Nov 25, 2025

Rkdev09 marked this pull request as ready for review November 25, 2025 11:09

Rkdev09 requested review from a team as code owners November 25, 2025 11:09

melvin-bot Bot requested review from JmillsExpensify and dukenv0307 and removed request for a team November 25, 2025 11:09

melvin-bot Bot removed the request for review from a team November 25, 2025 11:09

Rkdev09 marked this pull request as draft November 25, 2025 11:09

Fix issue where </li> <li> creates a new line.

8b4111c

Rkdev09 force-pushed the fix-li-styling branch from dfcbe4a to 8b4111c Compare November 25, 2025 11:36

CLABotify added a commit to Expensify/CLA that referenced this pull request Nov 25, 2025

@Rkdev09 has signed the CLA in Expensify/App#76009

9fc26f4

Rkdev09 mentioned this pull request Nov 25, 2025

[$250] Fix issue where </li> <li> creates a new line #75697

Closed

Merge branch 'Expensify:main' into fix-li-styling

1127a57

Rkdev09 marked this pull request as ready for review November 26, 2025 16:08

ignore empty text nodes in ol and ul.

29e4b8c

Signed-off-by: Rkmishra09 <ritikamishra5822@gmail.com>

Rkdev09 added 2 commits November 30, 2025 19:40

remove ignoreDomNode fix.

edb8da9

Signed-off-by: Rkmishra09 <ritikamishra5822@gmail.com>

remove LTR controls into whitespace-only nodes.

459cf9f

Signed-off-by: Rkmishra09 <ritikamishra5822@gmail.com>

dukenv0307 approved these changes Dec 1, 2025

View reviewed changes

melvin-bot Bot requested a review from MarioExpensify December 1, 2025 08:10

thienlnam approved these changes Dec 1, 2025

View reviewed changes

thienlnam merged commit 4cf4348 into Expensify:main Dec 1, 2025
38 of 40 checks passed

melvin-bot Bot added the Emergency label Dec 1, 2025

thienlnam removed the Emergency label Dec 1, 2025

OSBotify mentioned this pull request Dec 1, 2025

Deploy Checklist: New Expensify 2025-12-01 #76460

Closed

MelvinBot mentioned this pull request Jan 20, 2026

Fix: Preserve whitespace in email-comment elements for Concierge messages #80039

Closed

53 tasks

Conversation

Rkdev09 commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rkdev09 commented Nov 25, 2025

Uh oh!

Rkdev09 commented Nov 25, 2025

Uh oh!

melvin-bot Bot commented Nov 25, 2025

Uh oh!

Rkdev09 commented Nov 25, 2025

Uh oh!

Rkdev09 commented Nov 25, 2025

Uh oh!

dukenv0307 commented Nov 25, 2025

Uh oh!

dukenv0307 commented Nov 26, 2025

Uh oh!

dukenv0307 commented Nov 26, 2025

Uh oh!

Rkdev09 commented Nov 26, 2025

Uh oh!

Rkdev09 commented Nov 26, 2025

Uh oh!

Rkdev09 commented Nov 26, 2025

Uh oh!

Rkdev09 commented Nov 26, 2025

Uh oh!

dukenv0307 commented Nov 26, 2025

Uh oh!

dukenv0307 commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Rkdev09 commented Nov 27, 2025 via email

Uh oh!

Rkdev09 commented Nov 28, 2025

Uh oh!

Rkdev09 commented Nov 28, 2025

Uh oh!

Rkdev09 commented Nov 30, 2025

Uh oh!

dukenv0307 commented Dec 1, 2025

Uh oh!

dukenv0307 commented Dec 1, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Dec 1, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

thienlnam commented Dec 1, 2025

Uh oh!

Uh oh!

melvin-bot Bot commented Dec 1, 2025

Uh oh!

thienlnam commented Dec 1, 2025

Uh oh!

OSBotify commented Dec 1, 2025

Uh oh!

OSBotify commented Dec 1, 2025

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Rkdev09 commented Nov 25, 2025 •

edited

Loading

github-actions Bot commented Nov 25, 2025 •

edited

Loading

dukenv0307 commented Nov 27, 2025 •

edited

Loading

codecov Bot commented Dec 1, 2025 •

edited by github-actions Bot

Loading