fix: attachment arrows are hidden when playing video by gijoe0295 · Pull Request #75899 · Expensify/App

gijoe0295 · 2025-11-24T14:05:30Z

Explanation of Change

The arrows to navigate through attachments in the carousel are hidden while video is playing. They only appear again when we navigate to another attachment. This PR resolves that problem.

Fixed Issues

$ #72505
PROPOSAL: #72505 (comment)

Tests

Send several videos and several photos to a chat
Open a video
Play the video, wait until the arrows auto hide
Verify that the arrows will show and hide based on control bar by tapping on the video (control bar shows > arrows show; control bar hides > arrows hide)

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-11-24.at.21.16.37.mov

Android: mWeb Chrome

Screen.Recording.2025-11-24.at.21.17.52.mov

iOS: Native

Screen.Recording.2025-11-24.at.21.08.24.mov

iOS: mWeb Safari

Screen.Recording.2025-11-24.at.21.13.54.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-24.at.21.18.43.mp4

MacOS: Desktop

codecov · 2025-11-24T14:15:06Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ntCarousel/Pager/AttachmentCarouselPagerContext.ts	`100.00% <ø> (ø)`
...rc/components/Attachments/AttachmentView/index.tsx	`50.56% <100.00%> (ø)`
...nts/AttachmentCarousel/useCarouselContextEvents.ts	`50.00% <50.00%> (ø)`
...ments/AttachmentView/AttachmentViewVideo/index.tsx	`20.00% <0.00%> (ø)`
src/components/VideoPlayer/BaseVideoPlayer.tsx	`40.22% <50.00%> (+0.38%)`	⬆️
... and 8 files with indirect coverage changes

melvin-bot · 2025-11-24T14:21:01Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

gijoe0295 · 2025-11-24T14:21:08Z

Typescript and unit test checks are already on main branch.

This reverts commit 1fcd1ec.

situchan · 2025-11-28T17:16:08Z

+        if (controlStatusState === CONST.VIDEO_PLAYER.CONTROLS_STATUS.SHOW) {
+            onTap(true);
+        } else if (controlStatusState === CONST.VIDEO_PLAYER.CONTROLS_STATUS.HIDE) {
+            onTap(false);


Have you also tested VOLUME_ONLY case?

Testing this case

I can't find any where we're using VOLUME_ONLY in the current code base. But I think we should show the arrows in that case because volume button is a part of the control bar.

JmillsExpensify

Verify that the arrows will show and hide based on control bar by tapping on the video (control bar shows > arrows show; control bar hides > arrows hide)

UX approved by product

situchan · 2025-12-10T16:18:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

situchan · 2025-12-10T16:24:01Z

@gijoe0295 please merge main

situchan · 2025-12-10T16:48:37Z

When video is paused and arrows are auto-hidden, need to tap and then tap again to see arrows.
This is because video controls keep displaying when video is paused.
Hope this is fine.

Screen.Recording.2025-12-10.at.10.44.30.PM.mov

lakchote · 2025-12-11T08:12:58Z

When video is paused and arrows are auto-hidden, need to tap and then tap again to see arrows.

Hmm this can be confusing I feel like. Thoughts @JmillsExpensify?

JmillsExpensify · 2025-12-16T10:17:09Z

Ah interesting, I didn't catch that before. I agree the UX isn't great, though I also kind of question why we actually need the arrows in the carousel in the first place. Most apps don't really use this anymore on mobile. So I don't think we need to block on this right now either.

lakchote

LGTM

gijoe0295 · 2025-12-17T10:18:31Z

@lakchote All checks have passed. Is it ready for merging?

OSBotify · 2025-12-23T13:58:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-24T19:09:13Z

🚀 Deployed to staging by https://github.com/JmillsExpensify in version: 9.2.87-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-29T12:09:58Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.87-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Krishna2323 · 2026-05-22T01:13:50Z

-            return;
-        }
+    const handleTap = useCallback(
+        (shouldShowArrows?: boolean) => {


This introduced #86602. Adding showArrows?: boolean to handleTap broke PDF tap toggling on mWeb — PressableWithoutFeedback passes a GestureResponderEvent as the first arg, which gets interpreted as true instead of toggling. Fixed in #90179.

fix: attachment arrows are hidden when playing video

b4cf3d2

melvin-bot Bot assigned gijoe0295 Nov 24, 2025

fix lint

1295046

gijoe0295 marked this pull request as ready for review November 24, 2025 14:20

gijoe0295 requested review from a team as code owners November 24, 2025 14:20

melvin-bot Bot requested a review from situchan November 24, 2025 14:21

melvin-bot Bot requested review from JmillsExpensify and removed request for a team November 24, 2025 14:21

gijoe0295 added 3 commits November 28, 2025 17:13

Merge branch 'main' of github.com:gijoe0295/App into gijoe/72505

56cc2c8

supplement missing context

1fcd1ec

Revert "supplement missing context"

92dce3b

This reverts commit 1fcd1ec.

situchan reviewed Nov 28, 2025

View reviewed changes

JmillsExpensify reviewed Dec 1, 2025

View reviewed changes

gijoe0295 added 3 commits December 2, 2025 02:36

Merge branch 'main' of github.com:gijoe0295/App into gijoe/72505

b5f5cb7

rename variables

ac554b2

rename variables

e47ea73

Eskalifer1 mentioned this pull request Dec 4, 2025

[HOLD FOR #75899] Attachment-After video is played, tapping on video doesn't show left side arrow #76708

Closed

8 tasks

gijoe0295 added 2 commits December 5, 2025 12:21

Merge branch 'main' of github.com:gijoe0295/App into gijoe/72505

4e0619a

show arrows in VOLUME_ONLY case

bdf143e

situchan approved these changes Dec 10, 2025

View reviewed changes

melvin-bot Bot requested a review from lakchote December 10, 2025 17:13

Merge branch 'main' of github.com:gijoe0295/App into gijoe/72505

34e14b4

lakchote approved these changes Dec 16, 2025

View reviewed changes

JmillsExpensify merged commit dd8ddd5 into Expensify:main Dec 23, 2025
30 checks passed

OSBotify mentioned this pull request Dec 24, 2025

Deploy Checklist: New Expensify 2025-12-24 #78431

Closed

62 tasks

melvin-bot Bot mentioned this pull request Dec 29, 2025

[Due for payment 2026-01-05] [$250] IOS - Attachment - Arrows to navigate through attachments are not displayed when a video is playing #72505

Closed

16 tasks

Krishna2323 reviewed May 22, 2026

View reviewed changes

Krishna2323 mentioned this pull request May 22, 2026

[Due for payment 2026-05-22] [$250] mWeb - Attachments - Navigation buttons do not appear or disappear when tapping the PDF document #86602

Closed

7 tasks

Conversation

gijoe0295 commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Nov 24, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Nov 24, 2025

Uh oh!

gijoe0295 commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

situchan Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

gijoe0295 Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

gijoe0295 Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

situchan commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented Dec 10, 2025

Uh oh!

situchan commented Dec 10, 2025

Uh oh!

lakchote commented Dec 11, 2025

Uh oh!

JmillsExpensify commented Dec 16, 2025

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

gijoe0295 commented Dec 17, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 23, 2025

Uh oh!

OSBotify commented Dec 24, 2025

Uh oh!

OSBotify commented Dec 29, 2025

Uh oh!

Krishna2323 May 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gijoe0295 commented Nov 24, 2025 •

edited

Loading

codecov Bot commented Nov 24, 2025 •

edited by github-actions Bot

Loading

gijoe0295 commented Nov 24, 2025 •

edited

Loading

situchan commented Dec 10, 2025 •

edited

Loading