Add margin-top for custom report name error row by Eskalifer1 · Pull Request #75524 · Expensify/App

Eskalifer1 · 2025-11-19T10:35:34Z

Explanation of Change

This PR adds top indentation for the error line in the custom report name section.

Fixed Issues

$#74737
PROPOSAL:#74737 (comment)

Tests

Precondition: have created workspace

Go to Workspace Settings
Select Reports
Click on default report title
Enter invalid name
Ensure that the error row has an indent at the top.

Verify that no errors appear in the JS console

Offline tests

No offline behaviour since we need respose from backend

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

74737-android-native.1.mp4

Android: mWeb Chrome

74737-android-web.1.mp4

iOS: Native

74737-ios-native.1.mp4

iOS: mWeb Safari

74737-ios-web.1.mp4

MacOS: Chrome / Safari

74737-web.mov

melvin-bot · 2025-11-19T10:35:40Z

@dannymcclain @abdulrahuman5196 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Eskalifer1 · 2025-11-19T10:41:21Z

Hi @abdulrahuman5196 While working on the PR, I noticed that we had a negative margin that raised all content above it by this value (12px) to the top. I couldn't find the reason why it was added, so I decided it would be better to remove it. This way, we would have a layout without unexpected indents, as in this case. At the same time, I added an 8px indent to the error line and reduced the indent of the next element by 12px (since I removed the 12px negative margin), so the layout remained the same as it was, but without negative values.

If this option does not suit us, we can simply give the error line a negative margin (12px) + the indent itself (8px), resulting in 20px.

Let me know your thoughts, thank you!

codecov · 2025-11-19T10:47:27Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/ErrorMessageRow.tsx	`100.00% <100.00%> (ø)`
src/components/OfflineWithFeedback.tsx	`74.46% <ø> (ø)`
...c/pages/workspace/reports/WorkspaceReportsPage.tsx	`0.00% <ø> (ø)`
src/components/MessagesRow.tsx	`16.66% <0.00%> (ø)`
... and 9 files with indirect coverage changes

joekaufmanexpensify

Good from a product perspective 👍

abdulrahuman5196 · 2025-11-24T12:09:55Z

checking now

dannymcclain · 2025-11-24T14:40:53Z

What's the current margin-top/spacing for the error? It feels just a tiny bit too far away from the push row above it (basically it feels equal distance from the push row above and below it, so the error feels a little less related to the push row than I think it could). If it's at 8px now, can we see 4px? Sorry for being nitpicky! cc @dubielzyk-expensify

Eskalifer1 · 2025-11-24T15:06:29Z

Hi @dannymcclain, I will give you some options, and you can see which one we like best. While working on the PR, I noticed that we had a negative indentation in the previous element, which caused one element to overlap another. This pattern is not good because, depending on the length of the line, it can give unexpected results. For example, in this case, when the error message is short, everything is fine and there is just not enough indentation(we decided 8px), but when the message is long, the error spills over onto the previous element.

8px long:

8px short:

4px long:

4px short:

None long:

None short:

I noticed that in many places there is no additional indentation, such as here, but it all depends on whether there can be an error in several lines or not. For example, there is no indentation at all here, so a correction with a negative indentation may be sufficient in this case:

dannymcclain · 2025-11-24T15:56:06Z

Can we prevent the error message from spilling over and instead just increase the heigh of the whole error element to keep consistent top/bottom padding on it all the time?

Eskalifer1 · 2025-11-24T16:05:40Z

To be honest, I don't really understand what you mean, but for now, the screenshots I sent are standard behavior for the error row used in the project. Perhaps you have an example of what you're talking about so I can understand better?

dannymcclain · 2025-11-24T16:19:46Z

To be honest, I don't really understand what you mean

Haha sorry, this is tricky to talk about 😅. What I mean is, for a single-line OR multi-line error message, why can't we have the same space above the text for both cases? Why do long error message "spill over" at all?

Eskalifer1 · 2025-11-24T16:31:56Z

I think I understand what you are referring to. Currently, this behavior occurs throughout the project because the error line consists of three elements:

A red dot
The message itself
The close button

The entire error line is centered. And when the message is short (takes up one line), height of the container is 40px, because the close button is 40px high and wide, but the message text itself is not 40px high, so it is centered (accordingly, there is indentation at the top and bottom, because all elements of the line are centered).

But when the message text has more lines, then the height of the entire line is determined by the text itself, the red dot and the close button are in the middle, and the message text takes up the entire height (it is the text that determines it), which is why there is no indentation in this case.

cc: @dannymcclain

dannymcclain · 2025-11-24T16:49:01Z

AH! Thank you for that detailed explanation! Ok, knowing that, would it be possible to add padding to the actual text container, so that in the short-error case, there is no change to the UI, but in the long-error case, we get some space around the text?

If this is out of the scope of the PR, just let me know and we can roll with this as is. Ideally we could make this better though.

Eskalifer1 · 2025-11-24T21:36:04Z

Hmm... I think it's possible, but I'm not sure if it's within the scope of this PR, since we don't currently have mechanisms to add this style to a specific place. However, it can be done globally for all locations, but in this case, it will be necessary to check all locations that use this component (and I am sure there are many) throughout the project and check if they have indents, and if so, change them to this approach, which is definitely outside the scope of this PR. The only thing we can try is to add a chain of props for text styles and transfer them specifically from this location.

Here is a photo of how it will look:

dubielzyk-expensify · 2025-11-25T00:13:18Z

Agree with what Danny is saying. The other thing we can do is to show a generic error on this page saying something like "Please fix the formatting errors":

then have the whole thing listed out on the edit page itself:

It's a bit weird to have two of the same error twice.

I do think we should add the padding on the longer error like Danny is suggesting in this PR though.

Eskalifer1 · 2025-11-25T13:52:49Z

So what should i do? I think that in order not to go beyond the scope of the PR, I can add this indentation for the text in this PR only for this specific place.

cc: @dannymcclain @dubielzyk-expensify

dannymcclain · 2025-11-25T14:08:20Z

I think that in order not to go beyond the scope of the PR, I can add this indentation for the text in this PR only for this specific place.

Let's go ahead and do that and keep the scope limited to this particular error. Maybe in the future we can go through and update all the errors to have this new spacing (which would be ideal), but for now, I'm fine to just fix it here. Does that work for everyone?

Eskalifer1 · 2025-11-25T16:16:12Z

Updated PR!

dubielzyk-expensify · 2025-11-25T23:34:01Z

Sounds good to me 👍 Let us know when there's new screenshots and we'll get this over the line

Eskalifer1 · 2025-11-26T07:59:46Z

Hi @dannymcclain screenshots is also added

dannymcclain · 2025-11-26T14:08:48Z

Screenshots/videos are looking good to me 👍

abdulrahuman5196 · 2025-11-26T18:43:08Z

@Eskalifer1 Could you kindly check on the Jest Unit Tests failures?

Eskalifer1 · 2025-11-27T08:45:56Z

Done!

abdulrahuman5196 · 2025-11-27T18:13:50Z

Checking now

abdulrahuman5196 · 2025-11-28T08:40:26Z

                                errors={reportTitleErrors}
-                                errorRowStyles={styles.mh0}
+                                errorRowStyles={[styles.mh0]}
+                                errorRowTextStyles={[styles.mv2]}


@Eskalifer1 I don't understand why are we creating new errorRowTextStyles just to add margin? why can't we reuse the errorRowStyles and add margin there?

Hi @abdulrahuman5196 This was decided with the design team, we discussed it in this conversation. If you can, please reread it starting with this message so that I don't have to write the same things again:
#75524 (comment)

abdulrahuman5196 · 2025-11-29T09:41:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-11-29.at.3.05.53.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-11-29.at.3.08.10.PM.mov

iOS: HybridApp

Screen.Recording.2025-11-29.at.3.03.12.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-11-29.at.3.05.12.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-29.at.2.58.54.PM.mov

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @neil-marcellini

🎀 👀 🎀
C+ Reviewed

neil-marcellini

Looks great, thank you

OSBotify · 2025-12-01T15:57:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-01T23:43:17Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.2.67-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-03T13:55:56Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.2.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-03T14:51:23Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Eskalifer1 added 2 commits November 19, 2025 12:05

fix:74737: added margin-top to custom Report Name error

76021d7

reduced marginTop for next element after report custom name

fa08f09

Eskalifer1 requested review from a team as code owners November 19, 2025 10:35

melvin-bot Bot assigned Eskalifer1 Nov 19, 2025

melvin-bot Bot requested review from abdulrahuman5196 and dannymcclain November 19, 2025 10:35

melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team November 19, 2025 10:35

joekaufmanexpensify previously approved these changes Nov 19, 2025

View reviewed changes

Merge remote-tracking branch 'origin' into fix/74737

81f9bb0

Eskalifer1 dismissed joekaufmanexpensify’s stale review via 81f9bb0 November 24, 2025 11:51

Eskalifer1 mentioned this pull request Nov 24, 2025

Reports - Report error is dispalyed very close to the hover #75949

Closed

16 tasks

chore: added styles for text error

97c6abc

Merge remote-tracking branch 'origin' into fix/74737

a7e90e3

Merge remote-tracking branch 'origin' into fix/74737

c192cba

abdulrahuman5196 reviewed Nov 28, 2025

View reviewed changes

abdulrahuman5196 approved these changes Nov 29, 2025

View reviewed changes

melvin-bot Bot requested a review from neil-marcellini November 29, 2025 09:42

neil-marcellini approved these changes Dec 1, 2025

View reviewed changes

neil-marcellini merged commit 8647cee into Expensify:main Dec 1, 2025
31 of 33 checks passed

OSBotify mentioned this pull request Dec 1, 2025

Deploy Checklist: New Expensify 2025-12-01 #76460

Closed

melvin-bot Bot mentioned this pull request Dec 3, 2025

[Due for payment 2025-12-10] [$250] Fix display of report title formula errors #74737

Closed

Conversation

Eskalifer1 commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 19, 2025

Uh oh!

Eskalifer1 commented Nov 19, 2025

Uh oh!

codecov Bot commented Nov 19, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 commented Nov 24, 2025

Uh oh!

dannymcclain commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eskalifer1 commented Nov 24, 2025

Uh oh!

dannymcclain commented Nov 24, 2025

Uh oh!

Eskalifer1 commented Nov 24, 2025

Uh oh!

dannymcclain commented Nov 24, 2025

Uh oh!

Eskalifer1 commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dannymcclain commented Nov 24, 2025

Uh oh!

Eskalifer1 commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dubielzyk-expensify commented Nov 25, 2025

Uh oh!

Eskalifer1 commented Nov 25, 2025

Uh oh!

dannymcclain commented Nov 25, 2025

Uh oh!

Eskalifer1 commented Nov 25, 2025

Uh oh!

dubielzyk-expensify commented Nov 25, 2025

Uh oh!

Eskalifer1 commented Nov 26, 2025

Uh oh!

dannymcclain commented Nov 26, 2025

Uh oh!

abdulrahuman5196 commented Nov 26, 2025

Uh oh!

Eskalifer1 commented Nov 27, 2025

Uh oh!

abdulrahuman5196 commented Nov 27, 2025

Uh oh!

abdulrahuman5196 Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Eskalifer1 Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

abdulrahuman5196 commented Nov 29, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Eskalifer1 commented Nov 19, 2025 •

edited

Loading

codecov Bot commented Nov 19, 2025 •

edited by github-actions Bot

Loading

dannymcclain commented Nov 24, 2025 •

edited

Loading

Eskalifer1 commented Nov 24, 2025 •

edited

Loading

Eskalifer1 commented Nov 24, 2025 •

edited

Loading