Remove SearchTransaction > isFromOneTransactionReport by s77rt · Pull Request #75484 · Expensify/App

s77rt · 2025-11-18T22:36:04Z

Explanation of Change

Fixed Issues

#73971
PROPOSAL:

Tests

Have a workspace

Create an expense in a new report
Go to Reports > Expense
Verify the expense action button is Submit

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-11-18T22:46:24Z

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-11-18T22:56:21Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/MoneyRequestReportUtils.ts	`66.66% <100.00%> (+0.59%)`	⬆️
src/libs/ReportUtils.ts	`75.56% <100.00%> (+0.01%)`	⬆️
src/libs/SearchUIUtils.ts	`72.95% <100.00%> (ø)`
src/components/Search/index.tsx	`33.84% <0.00%> (-0.18%)`	⬇️
... and 42 files with indirect coverage changes

heyjennahay

No concern with product change

hoangzinh

@s77rt can you merge latest main to ensure we pick as much as possible usage of isFromOneTransactionReport recently?

hoangzinh · 2025-11-25T11:05:27Z

            convertedAmount: item.convertedAmount,
            currency: item.currency,
-            isFromOneTransactionReport: item.isFromOneTransactionReport,
+            isFromOneTransactionReport: item.report?.transactionCount === 1,


NAB: We can recreate a sharable util to check if a report is isOneTransactionReport

…nReport

hoangzinh · 2025-11-25T22:38:57Z

-    const reportActions = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report?.reportID}`] ?? ([] as ReportAction[]);
-    const chatReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${report?.chatReportID}`];
-    return !!getOneTransactionThreadReportID(report, chatReport, reportActions);
+    return report?.transactionCount === 1;


I wasn't aware of this existing function before. Uhmm, if we touch this function, we probably need to optimistically update transactionCount on adding/deleting/moving transactions to support offline mode.

You are right. I have added back the original function as a deprecated function and kept its use in that file. New usage should use the new function and handle the optimistic data accordingly.

…nReport

hoangzinh · 2025-11-26T15:21:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-11-26.at.22.41.33.android.mov

Android: mWeb Chrome

Screen.Recording.2025-11-26.at.22.28.01.android.chrome.mov

iOS: HybridApp

Screen.Recording.2025-11-26.at.22.48.36.mov

iOS: mWeb Safari

Screen.Recording.2025-11-26.at.22.43.21.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-26.at.22.25.56.web.mov

hoangzinh

LGTM

melvin-bot · 2025-11-26T15:49:50Z

🎯 @hoangzinh, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #76152.

OSBotify · 2025-12-01T16:42:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-01T23:43:11Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.67-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…-isFromOneTransactionReport" This reverts commit 444ab30, reversing changes made to 93c0084.

OSBotify · 2025-12-03T13:55:50Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-03T14:51:17Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

s77rt added 3 commits November 18, 2025 20:15

remove SearchTransaction > isFromOneTransactionReport

dcb8063

update isFromOneTransactionReport source

e08fc20

update MoneyRequestReportUtilsTest

7f90459

melvin-bot Bot assigned s77rt Nov 18, 2025

fix tests

04f930b

s77rt marked this pull request as ready for review November 18, 2025 22:45

s77rt requested review from a team as code owners November 18, 2025 22:45

melvin-bot Bot requested review from heyjennahay and mollfpr and removed request for a team November 18, 2025 22:45

melvin-bot Bot removed the request for review from a team November 18, 2025 22:46

s77rt requested a review from luacmartins November 18, 2025 22:49

s77rt added 2 commits November 19, 2025 00:16

fix spellcheck

d08761a

fix ts

9208117

s77rt mentioned this pull request Nov 18, 2025

[$125] [To-do counters] SearchTransaction > isFromOneTransactionReport #73971

Closed

heyjennahay previously approved these changes Nov 21, 2025

View reviewed changes

s77rt changed the title ~~[Hold Auth#18306] Remove SearchTransaction > isFromOneTransactionReport~~ Remove SearchTransaction > isFromOneTransactionReport Nov 22, 2025

luacmartins requested review from hoangzinh and removed request for mollfpr November 24, 2025 21:19

hoangzinh reviewed Nov 25, 2025

View reviewed changes

s77rt added 2 commits November 25, 2025 20:54

merge main

8e7aa08

use isOneTransactionReport util

5f6f8f6

s77rt dismissed heyjennahay’s stale review via 5f6f8f6 November 25, 2025 20:05

s77rt requested a review from hoangzinh November 25, 2025 20:06

s77rt added 3 commits November 25, 2025 21:50

lint + ts

3941cce

Merge branch 'main' into remove-SearchTransaction-isFromOneTransactio…

4db40cd

…nReport

ts

ab50a51

fix test

5849d92

hoangzinh reviewed Nov 25, 2025

View reviewed changes

s77rt added 3 commits November 26, 2025 09:04

Merge branch 'main' into remove-SearchTransaction-isFromOneTransactio…

db06d98

…nReport

add back previous isOneTransactionReport logic as a deprecated function

dafd185

cleanup

ecf0415

hoangzinh approved these changes Nov 26, 2025

View reviewed changes

melvin-bot Bot mentioned this pull request Nov 26, 2025

[$250] [Due for Payment 2025-12-10] Payment issue for E/App PR#75484 #76152

Closed

luacmartins approved these changes Dec 1, 2025

View reviewed changes

luacmartins merged commit 444ab30 into Expensify:main Dec 1, 2025
31 of 32 checks passed

OSBotify mentioned this pull request Dec 1, 2025

Deploy Checklist: New Expensify 2025-12-01 #76460

Closed

mitarachim mentioned this pull request Dec 2, 2025

Reports - Submit button is not shown, expense is not clickable when expense is created offline #76465

Closed

8 tasks

cristipaval added a commit that referenced this pull request Dec 2, 2025

Revert "Merge pull request #75484 from s77rt/remove-SearchTransaction…

222e737

…-isFromOneTransactionReport" This reverts commit 444ab30, reversing changes made to 93c0084.

cristipaval mentioned this pull request Dec 2, 2025

[CP Staging] Revert "Remove SearchTransaction > isFromOneTransactionReport" #76528

Closed

53 tasks

MelvinBot mentioned this pull request Sep 7, 2026

[Due for payment 2026-09-09] Invoice - Join button appear and expand horizontal on the first invoice on the Spend tab #98882

Closed

7 tasks

Conversation

s77rt commented Nov 18, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 18, 2025

Uh oh!

codecov Bot commented Nov 18, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

hoangzinh Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

s77rt Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hoangzinh Nov 25, 2025

Choose a reason for hiding this comment

Uh oh!

s77rt Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Nov 26, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 1, 2025

Uh oh!

OSBotify commented Dec 1, 2025

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Nov 18, 2025 •

edited by github-actions Bot

Loading

hoangzinh commented Nov 26, 2025 •

edited

Loading