[No QA] Add new policy report action when a policy is forced upgraded to cotrol - #75478
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
pecanoro
changed the title
pecanoro
marked this pull request as ready for review
November 24, 2025 23:45
Contributor
Author
|
@rojiphil Rory and I talked about using translate for this and it was a huge refactor (I tried and getReportName is used in a ton of places), so we are sticking with the deprecated translateLocal. |
Contributor
Author
|
@rojiphil Oh I also need to manually input a fake action in the database for this so let me know an #admins reportID of yours and I will run it |
Contributor
@pecanoro Please add fake action to the #admins reportID 
|
Contributor
Author
|
@rojiphil I added the reportAction, let me know if, for some reason, you can't see it! |
Contributor
|
PR for the hidden upgrade help page #76065 Expecting the URL to be https://help.expensify.com/articles/hidden/collect-upgrade but will confirm once we merge |
Contributor
Author
|
Updated to add the new constant! Though the PR is not deployed yet so it's not live |
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 7a04c172..56446d62 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1624,9 +1624,9 @@ const translations: TranslationDeepObject<typeof en> = {
featureRequiresValidate: 'Diese Funktion erfordert, dass Sie Ihr Konto verifizieren.',
validateAccount: 'Bestätigen Sie Ihr Konto',
helpText: ({email}: {email: string}) =>
- `Fügen Sie weitere Möglichkeiten hinzu, Belege zu senden. Leiten Sie sie weiter an <copy-text text="${email}"/> oder senden Sie ihnen eine SMS an 47777 (nur US-Nummern).`,
- pleaseVerify: 'Bitte überprüfen Sie diese Kontaktmethode',
- getInTouch: 'Wann immer wir mit Ihnen in Kontakt treten müssen, werden wir diese Kontaktmethode verwenden.',
+ `Füge weitere Möglichkeiten hinzu, Belege zu senden. Leite sie an <copy-text text="${email}"/> weiter oder sende sie per SMS an 47777 (nur US-Nummern).`,
+ pleaseVerify: 'Bitte verifizieren Sie diese Kontaktmethode',
+ getInTouch: 'Wenn wir Kontakt mit Ihnen aufnehmen müssen, verwenden wir diese Kontaktmethode.',
enterMagicCode: ({contactMethod}: EnterMagicCodeParams) =>
`Bitte geben Sie den magischen Code ein, der an ${contactMethod} gesendet wurde. Er sollte in ein bis zwei Minuten ankommen.`,
setAsDefault: 'Als Standard festlegen',
@@ -4667,7 +4667,7 @@ ${
companyCard: 'Firmenkarte',
chooseCardFeed: 'Karten-Feed auswählen',
ukRegulation:
- 'Expensify, Inc. ist ein Agent von Plaid Financial Ltd., einem autorisierten Zahlungsinstitut, das von der Financial Conduct Authority gemäß den Payment Services Regulations 2017 reguliert wird (Firmennummer: 804718). Plaid bietet Ihnen regulierte Kontoinformationsdienste über Expensify Limited als seinen Agenten an.',
+ 'Expensify, Inc. ist als Vertreter von Plaid Financial Ltd. tätig, einem autorisierten Zahlungsinstitut, das von der Financial Conduct Authority gemäß den Payment Services Regulations 2017 reguliert wird (Firm Reference Number: 804718). Plaid stellt Ihnen über Expensify Limited als seinen Vertreter regulierte Kontoinformationsdienste zur Verfügung.',
},
expensifyCard: {
issueAndManageCards: 'Ausstellen und Verwalten Ihrer Expensify-Karten',
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index afcf7ed0..6da859b6 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1626,9 +1626,9 @@ const translations: TranslationDeepObject<typeof en> = {
featureRequiresValidate: 'Cette fonctionnalité nécessite que vous validiez votre compte.',
validateAccount: 'Validez votre compte',
helpText: ({email}: {email: string}) =>
- `Ajoutez plus de moyens pour envoyer des reçus. Transférez-les à <copy-text text="${email}"/> ou envoyez-les par SMS au 47777 (numéros américains uniquement).`,
- pleaseVerify: 'Veuillez vérifier cette méthode de contact',
- getInTouch: 'Chaque fois que nous devons vous contacter, nous utiliserons cette méthode de contact.',
+ `Ajoutez d’autres moyens d’envoyer des reçus. Transférez-les à <copy-text text="${email}"/> ou envoyez-les par SMS au 47777 (numéros américains uniquement).`,
+ pleaseVerify: 'Veuillez vérifier ce moyen de contact',
+ getInTouch: 'Chaque fois que nous aurons besoin de vous contacter, nous utiliserons cette méthode de contact.',
enterMagicCode: ({contactMethod}: EnterMagicCodeParams) => `Veuillez entrer le code magique envoyé à ${contactMethod}. Il devrait arriver dans une minute ou deux.`,
setAsDefault: 'Définir par défaut',
yourDefaultContactMethod:
@@ -4675,7 +4675,7 @@ ${
companyCard: "carte d'entreprise",
chooseCardFeed: 'Choisir le flux de cartes',
ukRegulation:
- "Expensify, Inc. est un agent de Plaid Financial Ltd., une institution de paiement autorisée régulée par la Financial Conduct Authority sous les Payment Services Regulations 2017 (Numéro de Référence de l'Entreprise : 804718). Plaid vous fournit des services d'information de compte régulés via Expensify Limited en tant qu'agent.",
+ 'Expensify, Inc. est un agent de Plaid Financial Ltd., un établissement de paiement agréé et réglementé par la Financial Conduct Authority en vertu des Payment Services Regulations 2017 (numéro de référence de la société : 804718). Plaid vous fournit des services réglementés d’information sur les comptes via Expensify Limited en tant que son agent.',
},
expensifyCard: {
issueAndManageCards: 'Émettre et gérer vos cartes Expensify',
@@ -6243,7 +6243,7 @@ ${
`a mis à jour la fréquence de rapport automatique à "${newFrequency}" (précédemment "${oldFrequency}")`,
updateApprovalMode: ({newValue, oldValue}: ChangeFieldParams) => `a mis à jour le mode d'approbation en "${newValue}" (auparavant "${oldValue}")`,
upgradedWorkspace: 'a mis à niveau cet espace de travail vers le plan Control',
- forcedCorporateUpgrade: `Cet espace de travail a été mis à niveau vers l'offre Control. Cliquez <a href="${CONST.COLLECT_UPGRADE_HELP_URL}">ici</a> pour plus d'informations.`,
+ forcedCorporateUpgrade: `Cet espace de travail a été mis à niveau vers le forfait Control. Cliquez <a href="${CONST.COLLECT_UPGRADE_HELP_URL}">ici</a> pour plus d'informations.`,
downgradedWorkspace: 'a rétrogradé cet espace de travail vers le plan Collect',
updatedAuditRate: ({oldAuditRate, newAuditRate}: UpdatedPolicyAuditRateParams) =>
`a changé le taux de rapports acheminés aléatoirement pour approbation manuelle à ${Math.round(newAuditRate * 100)}% (précédemment ${Math.round(oldAuditRate * 100)}%)`,
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 1c5fb3e3..be98f438 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1619,9 +1619,10 @@ const translations: TranslationDeepObject<typeof en> = {
contactMethods: 'Metodi di contatto',
featureRequiresValidate: 'Questa funzione richiede di convalidare il tuo account.',
validateAccount: 'Convalida il tuo account',
- helpText: ({email}: {email: string}) => `Aggiungi più modi per inviare le ricevute. Inoltrale a <copy-text text="${email}"/> o inviarli al 47777 (solo numeri USA).`,
- pleaseVerify: 'Si prega di verificare questo metodo di contatto',
- getInTouch: 'Ogni volta che avremo bisogno di contattarti, useremo questo metodo di contatto.',
+ helpText: ({email}: {email: string}) =>
+ `Aggiungi altri modi per inviare le ricevute. Inoltrale a <copy-text text="${email}"/> oppure inviale via SMS al 47777 (solo numeri statunitensi).`,
+ pleaseVerify: 'Verifica questo metodo di contatto',
+ getInTouch: 'Quando avremo bisogno di contattarti, useremo questo metodo di contatto.',
enterMagicCode: ({contactMethod}: EnterMagicCodeParams) => `Per favore, inserisci il codice magico inviato a ${contactMethod}. Dovrebbe arrivare entro un minuto o due.`,
setAsDefault: 'Imposta come predefinito',
yourDefaultContactMethod:
@@ -4654,7 +4655,7 @@ ${
companyCard: 'carta aziendale',
chooseCardFeed: 'Scegli il feed della carta',
ukRegulation:
- "Expensify, Inc. è un agente di Plaid Financial Ltd., un'istituzione di pagamento autorizzata regolata dalla Financial Conduct Authority ai sensi delle Payment Services Regulations 2017 (Numero di riferimento aziendale: 804718). Plaid ti fornisce servizi di informazione sui conti regolamentati tramite Expensify Limited come suo agente.",
+ 'Expensify, Inc. è un agente di Plaid Financial Ltd., un istituto di pagamento autorizzato regolamentato dalla Financial Conduct Authority ai sensi delle Payment Services Regulations 2017 (Numero di riferimento dell’impresa: 804718). Plaid ti fornisce servizi regolamentati di informazione sui conti tramite Expensify Limited in qualità di suo agente.',
},
expensifyCard: {
issueAndManageCards: 'Emetti e gestisci le tue carte Expensify',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 4f8e1e6a..141444ac 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1619,10 +1619,9 @@ const translations: TranslationDeepObject<typeof en> = {
contactMethods: '連絡方法',
featureRequiresValidate: 'この機能を使用するには、アカウントの確認が必要です。',
validateAccount: 'アカウントを確認してください',
- helpText: ({email}: {email: string}) =>
- `領収書を送信する方法を追加してください。それらを転送する先は <copy-text text="${email}"/> または、47777（米国の番号のみ）にテキストメッセージを送信してください。`,
+ helpText: ({email}: {email: string}) => `領収書の送信方法を増やしましょう。<copy-text text="${email}"/> に転送するか、47777（米国内の番号のみ）にSMSを送信してください。`,
pleaseVerify: 'この連絡方法を確認してください',
- getInTouch: '私たちがあなたに連絡を取る必要がある場合、この連絡方法を使用します。',
+ getInTouch: 'ご連絡が必要な場合は、この連絡方法を使用します。',
enterMagicCode: ({contactMethod}: EnterMagicCodeParams) => `${contactMethod}に送信されたマジックコードを入力してください。1～2分以内に届くはずです。`,
setAsDefault: 'デフォルトに設定',
yourDefaultContactMethod: 'これは現在のデフォルトの連絡方法です。削除する前に、別の連絡方法を選択し、「デフォルトに設定」をクリックする必要があります。',
@@ -4616,7 +4615,7 @@ ${
companyCard: '会社カード',
chooseCardFeed: 'カードフィードを選択',
ukRegulation:
- 'Expensify, Inc.は、Plaid Financial Ltd.の代理店であり、支払いサービス規則2017に基づいて金融行動監視機構によって規制されている認可支払い機関です（会社参照番号: 804718）。Plaidは、Expensify Limitedをその代理店として通じて、規制されたアカウント情報サービスを提供します。',
+ 'Expensify, Inc. は、Plaid Financial Ltd. の代理人であり、Plaid Financial Ltd. は 2017 年決済サービス規則の下で Financial Conduct Authority により規制される認可を受けた決済機関です（企業参照番号: 804718）。Plaid は、その代理人である Expensify Limited を通じて、お客様に規制対象の口座情報サービスを提供します。',
},
expensifyCard: {
issueAndManageCards: 'Expensifyカードを発行および管理する',
@@ -6159,7 +6158,7 @@ ${
`自動レポートの頻度を「${newFrequency}」（以前は「${oldFrequency}」）に更新しました。`,
updateApprovalMode: ({newValue, oldValue}: ChangeFieldParams) => `承認モードを"${oldValue}"から"${newValue}"に更新しました。`,
upgradedWorkspace: 'このワークスペースをコントロールプランにアップグレードしました',
- forcedCorporateUpgrade: `このワークスペースは Control プランにアップグレードされました。詳しくは<a href="${CONST.COLLECT_UPGRADE_HELP_URL}">こちら</a>をご覧ください。`,
+ forcedCorporateUpgrade: `このワークスペースはControlプランにアップグレードされました。詳細は<a href="${CONST.COLLECT_UPGRADE_HELP_URL}">こちら</a>をご覧ください。`,
downgradedWorkspace: 'このワークスペースをCollectプランにダウングレードしました。',
updatedAuditRate: ({oldAuditRate, newAuditRate}: UpdatedPolicyAuditRateParams) =>
`レポートが手動承認のためにランダムにルーティングされる割合を${Math.round(newAuditRate * 100)}%（以前は${Math.round(oldAuditRate * 100)}%）に変更しました。`,
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index aaf85ef0..726ae5ad 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1620,9 +1620,9 @@ const translations: TranslationDeepObject<typeof en> = {
featureRequiresValidate: 'Deze functie vereist dat je je account verifieert.',
validateAccount: 'Valideer uw account',
helpText: ({email}: {email: string}) =>
- `Voeg meer manieren toe om bonnen te verzenden. Stuur ze naar <copy-text text="${email}"/> of stuur ze naar 47777 (alleen Amerikaanse nummers).`,
+ `Voeg meer manieren toe om bonnen te versturen. Stuur ze door naar <copy-text text="${email}"/> of sms ze naar 47777 (alleen Amerikaanse nummers).`,
pleaseVerify: 'Verifieer deze contactmethode alstublieft',
- getInTouch: 'Telkens wanneer we contact met je moeten opnemen, gebruiken we deze contactmethode.',
+ getInTouch: 'Wanneer we contact met je moeten opnemen, gebruiken we deze contactmethode.',
enterMagicCode: ({contactMethod}: EnterMagicCodeParams) => `Voer de magische code in die is verzonden naar ${contactMethod}. Het zou binnen een minuut of twee moeten aankomen.`,
setAsDefault: 'Instellen als standaard',
yourDefaultContactMethod:
@@ -4650,7 +4650,7 @@ ${
companyCard: 'bedrijfskaart',
chooseCardFeed: 'Kies kaartfeed',
ukRegulation:
- 'Expensify, Inc. is een agent van Plaid Financial Ltd., een erkende betalingsinstelling gereguleerd door de Financial Conduct Authority onder de Payment Services Regulations 2017 (Firm Reference Number: 804718). Plaid biedt u gereguleerde rekeninginformatiediensten via Expensify Limited als zijn agent.',
+ 'Expensify, Inc. is een agent van Plaid Financial Ltd., een geautoriseerde betaaldienstinstelling die wordt gereguleerd door de Financial Conduct Authority krachtens de Payment Services Regulations 2017 (Firm Reference Number: 804718). Plaid levert u gereguleerde rekeninginformatiediensten via Expensify Limited als zijn agent.',
},
expensifyCard: {
issueAndManageCards: 'Uitgeven en beheren van uw Expensify-kaarten',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 315613e5..1fb69e7a 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1618,9 +1618,9 @@ const translations: TranslationDeepObject<typeof en> = {
featureRequiresValidate: 'Ta funkcja wymaga weryfikacji konta.',
validateAccount: 'Zweryfikuj swoje konto',
helpText: ({email}: {email: string}) =>
- `Dodaj więcej sposobów na przesyłanie paragonów. Prześlij je do <copy-text text="${email}"/> lub wyślij SMS na numer 47777 (tylko numery w USA).`,
- pleaseVerify: 'Proszę zweryfikować tę metodę kontaktu',
- getInTouch: 'Kiedy będziemy musieli się z Tobą skontaktować, użyjemy tej metody kontaktu.',
+ `Dodaj więcej sposobów na wysyłanie paragonów. Prześlij je na <copy-text text="${email}"/> lub wyślij SMS-em na numer 47777 (tylko numery w USA).`,
+ pleaseVerify: 'Proszę zweryfikować tę metodę kontaktu.',
+ getInTouch: 'Gdy będziemy musieli się z tobą skontaktować, skorzystamy z tej metody kontaktu.',
enterMagicCode: ({contactMethod}: EnterMagicCodeParams) => `Proszę wprowadzić magiczny kod wysłany na ${contactMethod}. Powinien dotrzeć w ciągu minuty lub dwóch.`,
setAsDefault: 'Ustaw jako domyślne',
yourDefaultContactMethod: 'To jest Twoja domyślna metoda kontaktu. Zanim będziesz mógł ją usunąć, musisz wybrać inną metodę kontaktu i kliknąć „Ustaw jako domyślną”.',
@@ -4638,7 +4638,7 @@ ${
companyCard: 'karta firmowa',
chooseCardFeed: 'Wybierz kanał kart',
ukRegulation:
- 'Expensify, Inc. jest agentem Plaid Financial Ltd., autoryzowanej instytucji płatniczej regulowanej przez Financial Conduct Authority zgodnie z Payment Services Regulations 2017 (Numer referencyjny firmy: 804718). Plaid dostarcza Ci regulowane usługi informacyjne o rachunkach za pośrednictwem Expensify Limited jako swojego agenta.',
+ 'Expensify, Inc. jest agentem Plaid Financial Ltd., autoryzowanej instytucji płatniczej regulowanej przez Financial Conduct Authority na mocy Payment Services Regulations 2017 (Numer referencyjny firmy: 804718). Plaid świadczy Ci regulowane usługi informacji o rachunku za pośrednictwem Expensify Limited jako swojego agenta.',
},
expensifyCard: {
issueAndManageCards: 'Wydawaj i zarządzaj swoimi kartami Expensify',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 044e54a8..11068857 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1616,8 +1616,8 @@ const translations: TranslationDeepObject<typeof en> = {
featureRequiresValidate: 'Este recurso requer que você valide sua conta.',
validateAccount: 'Valide sua conta',
helpText: ({email}: {email: string}) =>
- `Adicione mais maneiras de enviar recibos. Encaminhe-os para <copy-text text="${email}"/> ou envie uma mensagem para 47777 (apenas números dos EUA).`,
- pleaseVerify: 'Por favor, verifique este método de contato',
+ `Adicione mais formas de enviar recibos. Encaminhe-os para <copy-text text="${email}"/> ou envie por SMS para 47777 (apenas números dos EUA).`,
+ pleaseVerify: 'Verifique este método de contato',
getInTouch: 'Sempre que precisarmos entrar em contato com você, usaremos este método de contato.',
enterMagicCode: ({contactMethod}: EnterMagicCodeParams) => `Por favor, insira o código mágico enviado para ${contactMethod}. Ele deve chegar em um ou dois minutos.`,
setAsDefault: 'Definir como padrão',
@@ -4642,7 +4642,7 @@ ${
companyCard: 'cartão corporativo',
chooseCardFeed: 'Escolher feed de cartão',
ukRegulation:
- 'A Expensify, Inc. é um agente da Plaid Financial Ltd., uma instituição de pagamento autorizada e regulada pela Financial Conduct Authority sob as Payment Services Regulations 2017 (Número de Referência da Empresa: 804718). A Plaid fornece a você serviços de informações de conta regulados através da Expensify Limited como seu agente.',
+ 'A Expensify, Inc. é agente da Plaid Financial Ltd., uma instituição de pagamento autorizada e regulada pela Financial Conduct Authority nos termos das Payment Services Regulations 2017 (Número de Referência da Empresa: 804718). A Plaid fornece a você serviços regulados de informações de conta por meio da Expensify Limited como seu agente.',
},
expensifyCard: {
issueAndManageCards: 'Emita e gerencie seus Cartões Expensify',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index fe7e480c..c562a56a 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1594,9 +1594,9 @@ const translations: TranslationDeepObject<typeof en> = {
contactMethods: '联系方式',
featureRequiresValidate: '此功能需要您验证您的账户。',
validateAccount: '验证您的账户',
- helpText: ({email}: {email: string}) => `添加更多发送收据的方式。转发到 <copy-text text="${email}"/> 或将其发送至 47777（仅限美国号码）。`,
+ helpText: ({email}: {email: string}) => `添加更多发送收据的方式。将它们转发到 <copy-text text="${email}"/> 或短信发送至 47777（仅限美国号码）。`,
pleaseVerify: '请验证此联系方式',
- getInTouch: '每当我们需要联系您时，我们将使用此联系方式。',
+ getInTouch: '每当我们需要联系您时，我们都会使用此联系方式。',
enterMagicCode: ({contactMethod}: EnterMagicCodeParams) => `请输入发送到${contactMethod}的验证码。验证码将在一分钟内到达。`,
setAsDefault: '设为默认',
yourDefaultContactMethod: '这是您当前的默认联系方式。在删除它之前，您需要选择另一种联系方式并点击“设为默认”。',
@@ -4556,7 +4556,7 @@ ${
companyCard: '公司卡',
chooseCardFeed: '选择卡片信息流',
ukRegulation:
- 'Expensify, Inc. 是 Plaid Financial Ltd. 的代理商，Plaid Financial Ltd. 是一家授权支付机构，受金融行为监管局根据2017年支付服务条例的监管（公司参考编号：804718）。Plaid 通过 Expensify Limited 作为其代理商为您提供受监管的账户信息服务。',
+ 'Expensify, Inc. 是 Plaid Financial Ltd. 的代理，后者为根据《2017年支付服务条例》受金融行为监管局监管的获授权支付机构（公司参考编号：804718）。Plaid 通过其代理 Expensify Limited 向您提供受监管的账户信息服务。',
},
expensifyCard: {
issueAndManageCards: '发行和管理您的Expensify卡片',
@@ -6070,7 +6070,7 @@ ${
updatedWorkspaceFrequencyAction: ({oldFrequency, newFrequency}: UpdatedPolicyFrequencyParams) => `将自动报告频率更新为“${newFrequency}”（之前为“${oldFrequency}”）`,
updateApprovalMode: ({newValue, oldValue}: ChangeFieldParams) => `将审批模式更新为"${newValue}"（之前为"${oldValue}"）`,
upgradedWorkspace: '将此工作区升级到Control计划',
- forcedCorporateUpgrade: `此工作区已升级至 Control 方案。点击 <a href="${CONST.COLLECT_UPGRADE_HELP_URL}">此处</a> 了解更多信息。`,
+ forcedCorporateUpgrade: `此工作区已升级为 Control 方案。点击<a href="${CONST.COLLECT_UPGRADE_HELP_URL}">此处</a>了解更多信息。`,
downgradedWorkspace: '已将此工作区降级到 Collect 计划',
updatedAuditRate: ({oldAuditRate, newAuditRate}: UpdatedPolicyAuditRateParams) =>
`将随机分配进行人工审批的报告比例更改为${Math.round(newAuditRate * 100)}％（之前为${Math.round(oldAuditRate * 100)}％）`,
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Contributor
|
Final live help page URL https://help.expensify.com/Hidden/collect-upgrade |
heyjennahay
previously approved these changes
Nov 26, 2025
heyjennahay
left a comment
heyjennahay
left a comment
Contributor
There was a problem hiding this comment.
No concern with product change
Contributor
Author
|
@rojiphil Friendly reminder for that review, as this is quite urgent! |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp75478-android-hybrid-001.mp4Android: mWeb Chrome75478-mweb-chrome-001.mp4iOS: HybridApp75478-ios-hybrid-001.mp4iOS: mWeb Safari75478-mweb-safari-001.mp4MacOS: Chrome / Safari75478-web-chrome-002.mp4MacOS: Desktop |
rojiphil
approved these changes
Nov 26, 2025
rojiphil
left a comment
rojiphil
left a comment
Contributor
There was a problem hiding this comment.
Thanks @pecanoro. Was already working on this.
We also need to prettify as we now got a prettier check failure.
But I have few observations though:
- I am thinking if the policy log action should come from
conciergeand not from the policy owner. What do you think? - On creating a reply thread for the policy log action, an unexpected error from BE gets thrown. I am assuming that this is due to the fake action. But I just thought to bring this to your notice just in case this is due to a BE bug.
Approving as these observations do not seem to be related to FE changes. Also, FE changes tests well in ui.
|
@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
Good point! I will double check with the product team to see if we need to change it. But as you mentioned, it would be a change in the back-end
Ah yes, most likely since I inserted the value directly in the database. I tested the migration myself on dev, and it does allow me to create the thread; it's in the 'tests' part of the description. I added screenshots! |
cristipaval
approved these changes
Nov 26, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
63 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.65-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.65-6 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
We will be running a migration to force upgrade some
collectpolicies tocontrol. That migration will generate a new policy log action that we need to handle.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/563132
PROPOSAL:
Tests
Offline tests
Same as normal tests
QA Steps
No QA. We need an account that has been migrated and there are none on prod yet.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop