fix: [Translation Migration] Fix split or incomplete translations in reportActionsView - #75129
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
…reportActionsView
aa3534e to
685df71
Compare
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb ChromeiOS: HybridAppios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.mov |
…t-or-incomplete-translations-in-reportActionsView
…t-or-incomplete-translations-in-reportActionsView
…t-or-incomplete-translations-in-reportActionsView
…t-or-incomplete-translations-in-reportActionsView
…t-or-incomplete-translations-in-reportActionsView
…t-or-incomplete-translations-in-reportActionsView
…t-or-incomplete-translations-in-reportActionsView
…t-or-incomplete-translations-in-reportActionsView
…t-or-incomplete-translations-in-reportActionsView
…tion-Migration-Fix-split-or-incomplete-translations-in-reportActionsView
…lations-in-reportActionsView' of https://github.com/TaduJR/App into fix-Translation-Migration-Fix-split-or-incomplete-translations-in-reportActionsView
|
@TaduJR is this ready for another look? Please re-test |
…tion-Migration-Fix-split-or-incomplete-translations-in-reportActionsView
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.74-0 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀
|
Explanation of Change
This PR fixes split or incomplete translations in reportActionsView.beginningOfChatHistory by migrating from string concatenation to a parameterised translation approach with HTML rendering.
Fixed Issues
$ #72050
PROPOSAL: #72050 (comment)
Tests
Test Case 1: One Participant Chat
Test Case 2: Two Participant Chat
Test Case 3: Three+ Participant Chat (Group Chat)
Test Case 4: Optimistic Accounts (Unregistered Users)
Test Case 5: Concierge & Self-DM
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android-Native.mp4
Android: mWeb Chrome
Android-mWeb.mp4
iOS: Native
iOS-Native.mp4
iOS: mWeb Safari
iOS-Safari.mp4
MacOS: Chrome / Safari
Mac-Chrome-1.mp4
MacOS: Desktop
Mac-Desktop.1.mp4