Update approval-mode changes to refresh submitted report next steps - #75090
Conversation
|
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@aimane-chnaif Updated. |
aimane-chnaif
left a comment
There was a problem hiding this comment.
Lots of failed checks.
|
@aimane-chnaif Changes are done locally, but unable to update as of now since Will update it later. |
JmillsExpensify
left a comment
There was a problem hiding this comment.
PR looks good and is inline with product spec.
|
@aimane-chnaif Gentle bump for review |
|
Done |
|
I am afraid QA will mark this as deploy blocker as Screen.Recording.2026-01-13.at.9.40.57.am.mov |
In the testing steps, I had already mentioned the steps which asks them to go offline. For the backend issue, it would be same as prod so I think they may not mark it as a deploy blocker. |
Fixed |
|
@aimane-chnaif Gentle bump on this |
|
Please merge main |
|
Done |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@Gonals Looks like the automation to request a review from you didn't work. |
|
@Gonals Can you have a look when you get a chance? |
|
@Gonals Gentle bump on this |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/Gonals in version: 9.3.11-0 🚀
|
|
@ShridharGoel PR is passed when offline, but if go online, it fails with the original issue 75090A.mp4 |
|
That's expected because backend changes will be needed for the online scenario |
|
@ShridharGoel in this case, we can pass the PR, right? |
|
Yes |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.3.12-1 🚀
|

Explanation of Change
Update approval-mode changes to refresh submitted report next steps
Fixed Issues
$ #70948
PROPOSAL: #70948 (comment)
Tests
Precondition: Create a workspace enable Delay submissions manually, enable Add approvals and Make or track payments. Invite employee to workspace
Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-11-27.at.10.32.39.PM.mov
Android: mWeb Chrome
Screen.Recording.2025-11-27.at.10.26.50.PM.mov
iOS: Native
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-11-27.at.22.50.27.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-11-14.at.1.57.45.AM.mov