Skip to content

Fix tax bugs #74895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinpersaud merged 6 commits into from
Nov 17, 2025
Merged

Fix tax bugs #74895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1c18e79
Add automated tests for tax calculation
roryabraham Nov 11, 2025
2495f8b
Fix #73411 by removing unnecessary code that was clearing the tax rate
roryabraham Nov 12, 2025
0fdf0d2
Default taxClaimablePercentage to 1
roryabraham Nov 12, 2025
a92928f
Fix tests
roryabraham Nov 12, 2025
5ac2908
Don't reference issue numbers in tests
roryabraham Nov 12, 2025
07e032a
Merge branch 'main' into Rory-FixTaxBugs
roryabraham Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/DistanceRequestUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ function getTaxableAmount(policy: OnyxEntry<Policy>, customUnitRateID: string, d
const unit = distanceUnit?.attributes?.unit ?? CONST.CUSTOM_UNITS.DISTANCE_UNIT_MILES;
const rate = customUnitRate?.rate ?? CONST.DEFAULT_NUMBER_ID;
const amount = getDistanceRequestAmount(distance, unit, rate);
const taxClaimablePercentage = customUnitRate.attributes?.taxClaimablePercentage ?? CONST.DEFAULT_NUMBER_ID;
const taxClaimablePercentage = customUnitRate.attributes?.taxClaimablePercentage ?? 1;
return amount * taxClaimablePercentage;
}

Expand Down
5 changes: 0 additions & 5 deletions src/pages/iou/request/step/IOURequestStepAmount.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ import {
setDraftSplitTransaction,
setMoneyRequestAmount,
setMoneyRequestParticipantsFromReport,
setMoneyRequestTaxAmount,
setSplitShares,
trackExpense,
updateMoneyRequestAmountAndCurrency,
Expand Down Expand Up @@ -177,10 +176,6 @@ function IOURequestStepAmount({
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
setMoneyRequestAmount(transactionID, amountInSmallestCurrencyUnits, currency || CONST.CURRENCY.USD, shouldKeepUserInput);

// Initially when we're creating money request, we do not know the participant and hence if the request is with workspace with tax tracking enabled
// So, we reset the taxAmount here and calculate it in the hook in MoneyRequestConfirmationList component
setMoneyRequestTaxAmount(transactionID, null);

if (backTo) {
Navigation.goBack(backTo);
return;
Expand Down
Loading
Loading