[CP Staging / Production] disable Sentry profiling on Android - #74801
Conversation
|
🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
@rlinoz confirmed it fixes the issue: https://expensify.slack.com/archives/C08CZDJFJ77/p1762870881595659?thread_ts=1762814717.699749&cid=C08CZDJFJ77 |
|
✅ Automated Code Review Complete No code quality violations found. The changes correctly disable Sentry profiling on Android to prevent crashes while maintaining profiling on other platforms. Review Summary:
The implementation is clean and focused, with proper import organization and platform-specific logic. |
mountiny
left a comment
There was a problem hiding this comment.
No crash for me either (I could repro the crash before) so I think we can move this ahead
|
Does this one require C+ review? |
@Ollyws no |
|
Excellent, nice find Lucien |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Unrelated test |
[CP Staging / Production] disable Sentry profiling on Android (cherry picked from commit 646540c) (cherry-picked to production by Julesssss)
[CP Staging / Production] disable Sentry profiling on Android (cherry picked from commit 646540c) (cherry-picked to staging by Julesssss)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.50-0 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.2.50-1 🚀
|
|
Gh actions are failing to pick up jobs So fix is not yet deployed to prod or staging for Android 😫 |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.50-0 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.2.52-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.50-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.50-0 🚀
|
|
Fix verified on |
|
Prod build isn't updating, because it is now a lower version than the current staging build... We'll need to await the next release, or manually generate and upload the prod build I think... |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.54-1 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.2.55-3 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.2.52-0 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.2.57-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.57-4 🚀
|
Explanation of Change
Disables Sentry profiling for Android to prevent a major crash, while we investigate and find the root cause.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/566696
PROPOSAL:
Tests
Offline tests
NA
QA Steps
Same as in tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videosundefined