Fix approve button not shown because of invisible broken card connection violation - #74738

Merged

cead22 merged 35 commits into

Expensify:mainfrom

rayane-d:fix-approve-button-not-shown-because-of-brokenCardConnection-violation

Nov 24, 2025

Commits on Nov 10, 2025

fix approve button not shown because of invisible brokenCardConnection violation
rayane-d
committed
981b9b0
fix empty report next step shown because of invisible brokenCardConnection violation
rayane-d
committed
c198f7b

Commits on Nov 11, 2025

Just check if the violation has been dismissed by anyone If we don't provide an email to isViolationDismissed
rayane-d
committed
5bb1c92
Fix empty report next step message when the broken connection next step is dismissed
rayane-d
committed
e3d73cb
revert a change
rayane-d
committed
b03bdb1
fix empty report next step when the BrokenConnection violation is dismissed
rayane-d
committed
b5bf0ca
run prettier
rayane-d
committed
2f7c119
add automated tests for isViolationDismissed
rayane-d
committed
7cc00cc
pass current user email to isViolationDismissed in isDuplicate. because for duplicatedExpense violation, if the submitter dismisses it, the approver should still see it, and vice versa
rayane-d
committed
4871b1f
fix failing test
rayane-d
committed
6924d6b
fix type errors
rayane-d
committed
9cc99ea
Merge branch 'main' into fix-approve-button-not-shown-because-of-brokenCardConnection-violation
rayane-d
committed
2948ca9
remove deprecatedCurrentUserEmail
rayane-d
committed
3da5117

Commits on Nov 12, 2025

Commits on Nov 17, 2025

Merge branch 'main' into fix-approve-button-not-shown-because-of-brokenCardConnection-violation
rayane-d
committed
114ab85
Address review comments
rayane-d
committed
de6486d
add comment
rayane-d
committed
9b6a154

Commits on Nov 18, 2025

clarify comments
rayane-d
committed
1f79c59
fix hasDuplicateTransactions references
rayane-d
committed
271273f
prettier
rayane-d
committed
6ebfa13
Merge branch 'Expensify:main' into fix-approve-button-not-shown-because-of-brokenCardConnection-violation
rayane-d
authored
d9b1080
Fix "Mark as cash" button displayed for invisible violation
rayane-d
committed
e515eb6
prettier
rayane-d
committed
8c4fbf0
Apply suggestions from code review

rayane-d
and
pecanoro
authored
0f55707
add more tests
rayane-d
committed
79a7c94

Commits on Nov 19, 2025

Commits on Nov 20, 2025

Merge branch 'main' into fix-approve-button-not-shown-because-of-brokenCardConnection-violation
rayane-d
authored
82cfbd2

Commits on Nov 21, 2025