Update ownership check when moving expenses and add ownerAccountID on refresh of selected transactions by ShridharGoel · Pull Request #73633 · Expensify/App

ShridharGoel · 2025-10-28T13:16:07Z

Explanation of Change

Update ownership check when moving expenses

Fixed Issues

$ #73601, #73623
PROPOSAL:

Tests

Go to workspace chat.
Create two reports.
Add an expense to each report.
Go to Reports > Reports.
Select both expenses from Step 4.
Click dropdown button > Move expenses.
Create report button should be present.

Precondition: Account has self DM and workspace.
Go to the app.
Go to self DM.
Create an expense.
Go to workspace chat.
Create an expense.
Go to Reports > Expenses.
Select both expenses via checkbox.
Click dropdown button > Move expenses.
Close the RHP.
Click dropdown button > Move expenses.
Move expenses button should be present.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-10-28.at.7.25.17.PM.mov

MacOS: Desktop

melvin-bot · 2025-10-28T13:16:14Z

@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ShridharGoel · 2025-10-28T13:16:18Z

@c3024

c3024 · 2025-10-28T13:41:02Z

@ShridharGoel

Will #73623 also be fixed with this?

ShridharGoel · 2025-10-28T13:42:31Z

@c3024 No, I'm still checking that one.

ShridharGoel · 2025-10-28T13:51:25Z

@c3024 #73623 is also fixed.

ShridharGoel · 2025-10-28T13:55:55Z

Fix of issue #73601:

Fix of issue #73623:

Screen.Recording.2025-10-28.at.7.25.17.PM.mov

c3024 · 2025-10-28T13:38:23Z


-    const shouldShowRemoveFromReport = isEditing && isOwner && !isReportIOU && !isSelectedReportUnreported && !isCardTransaction;
+    const shouldShowRemoveFromReport =
+        !!(selectedReportID && selectedReportID !== CONST.REPORT.UNREPORTED_REPORT_ID && selectedReport) && isEditing && isOwner && !isReportIOU && !isCardTransaction;


@ShridharGoel

Doesn't the existing isSelectedReportUnreported work here instead of this check?

selectedReportID && selectedReportID !== CONST.REPORT.UNREPORTED_REPORT_ID && selectedReport

!isSelectedReportUnreported is also true when selectedReportID is undefined (when multiple reports are selected), so the "Remove from report" button would keep showing on multiple report selection if we use just that.

codecov · 2025-10-28T14:04:27Z

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/Search/index.tsx	0.00%	2 Missing ⚠️

Files with missing lines	Coverage Δ
...es/iou/request/step/IOURequestEditReportCommon.tsx	`77.65% <100.00%> (+0.24%)`	⬆️
src/components/Search/index.tsx	`0.00% <0.00%> (ø)`

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

c3024 · 2025-10-28T14:20:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

moveChrome1.mov

moveChrome2.mov

moveChrome3.mov

moveChrome4.mov

moveChrome5.mov

moveChrome6.mov

MacOS: Desktop

c3024

LGTM!

Update ownership check when moving expenses and add ownerAccountID on refresh of selected transactions (cherry picked from commit cca82d2) (cherry-picked to staging by puneetlath)

OSBotify · 2025-10-28T14:56:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-28T15:25:31Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.39-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Julesssss · 2025-10-28T16:24:32Z

Awaiting retest here

OSBotify · 2025-10-28T21:35:13Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.39-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-28T21:46:40Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.40-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-28T22:43:24Z

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.40-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-30T07:02:41Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.40-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Update ownership check when moving expenses

39a05d9

ShridharGoel requested a review from a team as a code owner October 28, 2025 13:16

melvin-bot Bot assigned ShridharGoel Oct 28, 2025

melvin-bot Bot requested review from bernhardoj and removed request for a team October 28, 2025 13:16

ShridharGoel mentioned this pull request Oct 28, 2025

[No Payment] [Due for payment 2025-11-06] Reports - Create report button is not shown when bulk moving expenses from different reports #73601

Closed

8 tasks

Add ownerAccountID again on refresh of selected transactions

20aeb0e

ShridharGoel changed the title ~~Update ownership check when moving expenses~~ Update ownership check when moving expenses and add ownerAccountID on refresh of selected transactions Oct 28, 2025

c3024 suggested changes Oct 28, 2025

View reviewed changes

c3024 approved these changes Oct 28, 2025

View reviewed changes

melvin-bot Bot requested a review from AndrewGable October 28, 2025 14:22

Gonals self-requested a review October 28, 2025 14:22

Gonals approved these changes Oct 28, 2025

View reviewed changes

Gonals merged commit cca82d2 into Expensify:main Oct 28, 2025
32 of 34 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 28, 2025

OSBotify mentioned this pull request Oct 28, 2025

Deploy Checklist: New Expensify 2025-10-27 #73587

Closed

68 tasks

github-actions Bot mentioned this pull request Oct 28, 2025

Investigate workflow job failing on main: test / test (job 1) #73637

Closed

Conversation

ShridharGoel commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 28, 2025

Uh oh!

ShridharGoel commented Oct 28, 2025

Uh oh!

c3024 commented Oct 28, 2025

Uh oh!

ShridharGoel commented Oct 28, 2025

Uh oh!

ShridharGoel commented Oct 28, 2025

Uh oh!

ShridharGoel commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

c3024 Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

c3024 commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 28, 2025

Uh oh!

OSBotify commented Oct 28, 2025

Uh oh!

Julesssss commented Oct 28, 2025

Uh oh!

OSBotify commented Oct 28, 2025

Uh oh!

OSBotify commented Oct 28, 2025

Uh oh!

OSBotify commented Oct 28, 2025

Uh oh!

OSBotify commented Oct 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ShridharGoel commented Oct 28, 2025 •

edited

Loading

ShridharGoel commented Oct 28, 2025 •

edited

Loading

ShridharGoel Oct 28, 2025 •

edited

Loading

codecov Bot commented Oct 28, 2025 •

edited

Loading

c3024 commented Oct 28, 2025 •

edited

Loading