Fix map preview resizing issue after edit causing partial area rendering - #73298
Conversation
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I think the videos are looking good to me. @dubielzyk-expensify for an extra set of 👀 |
|
Agree with that. Looking nice 👍 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-10-26.at.1.09.44.AM.movAndroid: mWeb ChromeScreen.Recording.2025-10-26.at.1.11.12.AM.moviOS: HybridAppScreen.Recording.2025-10-26.at.12.51.21.AM.moviOS: mWeb SafariScreen.Recording.2025-10-26.at.12.56.46.AM.movMacOS: Chrome / SafariScreen.Recording.2025-10-26.at.12.26.27.AM.movMacOS: DesktopScreen.Recording.2025-10-26.at.12.31.34.AM.mov |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @inimaga
🎀 👀 🎀
C+ Reviewed
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/inimaga in version: 9.2.39-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.39-3 🚀
|
Explanation of Change
Fixed Issues
$ #72191
PROPOSAL: #72191 comment
Tests
→ The distance receipt preview fills the area completely while the map is updating.
→ The distance receipt preview should still fills the area completely.
Offline tests
Same as Tests
QA Steps
Same as Tests
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.1404-08-01.at.2.39.54.PM.mp4
Android: mWeb Chrome
Screen.Recording.1404-08-01.at.2.42.25.PM.mp4
iOS: Native
Screen.Recording.1404-08-01.at.2.33.19.PM.mp4
iOS: mWeb Safari
Screen.Recording.1404-08-01.at.2.36.24.PM.mp4
MacOS: Chrome / Safari
Screen.Recording.1404-08-01.at.2.23.16.PM.mp4
MacOS: Desktop
Screen.Recording.1404-08-01.at.2.46.36.PM.mp4