Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ type FocusTrapForModalProps = {
active: boolean;
initialFocus?: FocusTrapOptions['initialFocus'];
shouldPreventScroll?: boolean;
shouldReturnFocus?: boolean;
};

export default FocusTrapForModalProps;
7 changes: 5 additions & 2 deletions src/components/FocusTrap/FocusTrapForModal/index.web.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import blurActiveElement from '@libs/Accessibility/blurActiveElement';
import ReportActionComposeFocusManager from '@libs/ReportActionComposeFocusManager';
import type FocusTrapForModalProps from './FocusTrapForModalProps';

function FocusTrapForModal({children, active, initialFocus = false, shouldPreventScroll = false}: FocusTrapForModalProps) {
function FocusTrapForModal({children, active, initialFocus = false, shouldPreventScroll = false, shouldReturnFocus = true}: FocusTrapForModalProps) {
return (
<FocusTrap
active={active}
Expand All @@ -20,7 +20,10 @@ function FocusTrapForModal({children, active, initialFocus = false, shouldPreven
if (ReportActionComposeFocusManager.isFocused()) {
return false;
}
return element;
if (shouldReturnFocus) {
return element;
}
return false;
},
}}
>
Expand Down
1 change: 1 addition & 0 deletions src/components/Modal/BaseModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,7 @@ function BaseModal({
customBackdrop={shouldUseCustomBackdrop ? <Overlay onPress={handleBackdropPress} /> : undefined}
type={type}
shouldIgnoreBackHandlerDuringTransition={shouldIgnoreBackHandlerDuringTransition}
shouldEnableNewFocusManagement={shouldEnableNewFocusManagement}
>
<Animated.View
onLayout={onViewLayout}
Expand Down
2 changes: 2 additions & 0 deletions src/components/Modal/ReanimatedModal/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ function ReanimatedModal({
shouldPreventScrollOnFocus,
initialFocus,
shouldIgnoreBackHandlerDuringTransition = false,
shouldEnableNewFocusManagement,
...props
}: ReanimatedModalProps) {
const [isVisibleState, setIsVisibleState] = useState(isVisible);
Expand Down Expand Up @@ -239,6 +240,7 @@ function ReanimatedModal({
<FocusTrapForModal
active={modalVisibility}
initialFocus={initialFocus}
shouldReturnFocus={!shouldEnableNewFocusManagement}
shouldPreventScroll={shouldPreventScrollOnFocus}
>
{isVisibleState && containerView}
Expand Down
6 changes: 6 additions & 0 deletions src/components/Modal/ReanimatedModal/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,12 @@ type ReanimatedModalProps = ViewProps &
/** Whether to use a custom backdrop for the modal? (This prevents focus issues on desktop) */
initialFocus?: FocusTrapOptions['initialFocus'];

/**
* Whether the modal should enable the new focus manager.
* We are attempting to migrate to a new refocus manager, adding this property for gradual migration.
* */
shouldEnableNewFocusManagement?: boolean;

/** Whether to ignore the back handler during transition */
shouldIgnoreBackHandlerDuringTransition?: boolean;
};
Expand Down
5 changes: 4 additions & 1 deletion src/components/PopoverMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,10 @@ function BasePopoverMenu({
shouldUseModalPaddingStyle={shouldUseModalPaddingStyle}
testID={testID}
>
<FocusTrapForModal active={isVisible}>
<FocusTrapForModal
active={isVisible}
shouldReturnFocus={!shouldEnableNewFocusManagement}
>
<View
onLayout={onLayout}
style={[menuContainerStyle, containerStyles, {paddingTop, paddingBottom, paddingVertical, ...(isWebOrDesktop ? styles.flex1 : styles.flexGrow1)}]}
Expand Down
Loading