Skip to content

Revert "update createWorkspace API params" - #72896

Merged
aldo-expensify merged 1 commit into
mainfrom
revert-71174-fix/67642
Oct 17, 2025
Merged

Revert "update createWorkspace API params"#72896
aldo-expensify merged 1 commit into
mainfrom
revert-71174-fix/67642

Conversation

@aldo-expensify

@aldo-expensify aldo-expensify commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

Reverts #71174

@aldo-expensify

aldo-expensify commented Oct 17, 2025

Copy link
Copy Markdown
Contributor Author

Testing if this fixes #72867

@aldo-expensify aldo-expensify mentioned this pull request Oct 17, 2025
Closed
4 of 8 tasks
@aldo-expensify
aldo-expensify marked this pull request as ready for review October 17, 2025 21:11
@aldo-expensify
aldo-expensify requested a review from a team as a code owner October 17, 2025 21:11
@cursor

cursor Bot commented Oct 17, 2025

Copy link
Copy Markdown

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on November 11.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@melvin-bot
melvin-bot Bot requested review from Gonals and removed request for a team October 17, 2025 21:11
@melvin-bot

melvin-bot Bot commented Oct 17, 2025

Copy link
Copy Markdown

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov

codecov Bot commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 3.70370% with 26 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/libs/actions/Policy/Policy.ts 0.00% 20 Missing ⚠️
...estedFeatures/BaseOnboardingInterestedFeatures.tsx 0.00% 6 Missing ⚠️
Files with missing lines Coverage Δ
src/CONST/index.ts 85.84% <100.00%> (+0.13%) ⬆️
...c/pages/iou/request/step/IOURequestStepUpgrade.tsx 0.00% <ø> (ø)
...estedFeatures/BaseOnboardingInterestedFeatures.tsx 1.02% <0.00%> (-0.03%) ⬇️
src/libs/actions/Policy/Policy.ts 31.67% <0.00%> (-0.66%) ⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

LGTM :feelsgood:. Thank you for your hard work!

@aldo-expensify
aldo-expensify merged commit 3941c45 into main Oct 17, 2025
31 of 34 checks passed
@aldo-expensify
aldo-expensify deleted the revert-71174-fix/67642 branch October 17, 2025 21:26
@melvin-bot melvin-bot Bot added the Emergency label Oct 17, 2025
@melvin-bot

melvin-bot Bot commented Oct 17, 2025

Copy link
Copy Markdown

@aldo-expensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@aldo-expensify

aldo-expensify commented Oct 17, 2025

Copy link
Copy Markdown
Contributor Author

Removed Emergency label because it is a straight revert

@OSBotify

OSBotify commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@Julesssss Julesssss mentioned this pull request Oct 17, 2025
Closed
OSBotify pushed a commit that referenced this pull request Oct 17, 2025
@aldo-expensify @OSBotify
Merge pull request #72896 from Expensify/revert-71174-fix/67642
7c6fb63 
Revert "update createWorkspace API params"

(cherry picked from commit 3941c45)

(cherry-picked to staging by Julesssss)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 17, 2025
@OSBotify OSBotify mentioned this pull request Oct 17, 2025
Closed
67 tasks done
@OSBotify

OSBotify commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.2.33-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@dukenv0307 dukenv0307 mentioned this pull request Oct 20, 2025
Merged
54 tasks done
@OSBotify

OSBotify commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.33-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.2.34-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.34-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blimpich blimpich blimpich approved these changes
@Gonals Gonals Awaiting requested review from Gonals

Assignees

@aldo-expensify aldo-expensify

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aldo-expensify @OSBotify @blimpich