Skip to content

[CP Staging] Revert "Open transaction thread on top" - #71458

Merged
mountiny merged 1 commit into
mainfrom
revert-71084-VickyStash/feature/63253-open-transaction-thread-on-top
Sep 29, 2025
Merged

[CP Staging] Revert "Open transaction thread on top"#71458
mountiny merged 1 commit into
mainfrom
revert-71084-VickyStash/feature/63253-open-transaction-thread-on-top

Conversation

@mountiny

@mountiny mountiny commented Sep 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

@mountiny mountiny self-assigned this Sep 29, 2025
@mountiny
mountiny requested review from a team as code owners September 29, 2025 10:20
@melvin-bot
melvin-bot Bot requested a review from Gonals September 29, 2025 10:20
@melvin-bot

melvin-bot Bot commented Sep 29, 2025

Copy link
Copy Markdown

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 29, 2025 10:20
github-actions[bot]
github-actions Bot reviewed Sep 29, 2025
View reviewed changes
Comment thread src/pages/home/report/ReportActionsList.tsx
const [tryNewDot] = useOnyx(ONYXKEYS.NVP_TRY_NEW_DOT, {canBeMissing: false});
const isTryNewDotNVPDismissed = !!tryNewDot?.classicRedirect?.dismissed;
const [isScrollToBottomEnabled, setIsScrollToBottomEnabled] = useState(false);
const [shouldScrollToEndAfterLayout, setShouldScrollToEndAfterLayout] = useState(false);

@github-actions github-actions Bot Sep 29, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No Issues Found

The revert restores the original state initialization which is correctly implemented. The state variable is properly initialized and managed.

@mountiny
mountiny merged commit a1cfa2b into main Sep 29, 2025
21 of 23 checks passed
@mountiny
mountiny deleted the revert-71084-VickyStash/feature/63253-open-transaction-thread-on-top branch September 29, 2025 10:25
@melvin-bot melvin-bot Bot added the Emergency label Sep 29, 2025
@melvin-bot

melvin-bot Bot commented Sep 29, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny

mountiny commented Sep 29, 2025

Copy link
Copy Markdown
Contributor Author

Straight revert

@codecov

codecov Bot commented Sep 29, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pages/home/report/ReportActionsList.tsx 57.14% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@OSBotify

OSBotify commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Sep 29, 2025
@mountiny @OSBotify
Merge pull request #71458 from Expensify/revert-71084-VickyStash/feat…
0dbf5b7 
…ure/63253-open-transaction-thread-on-top

[CP Staging] Revert "Open transaction thread on top"

(cherry picked from commit a1cfa2b)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Sep 29, 2025
@OSBotify OSBotify mentioned this pull request Sep 29, 2025
Closed
62 tasks done
@OSBotify

OSBotify commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.19-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@amyevans amyevans mentioned this pull request Sep 29, 2025
Closed
1 of 8 tasks
@VickyStash VickyStash mentioned this pull request Sep 29, 2025
Closed
7 of 8 tasks
VickyStash added a commit to callstack-internal/Expensify-App that referenced this pull request Sep 29, 2025
@VickyStash
Revert "Merge pull request Expensify#71458 from Expensify/revert-7108…
2375c97 
…4-VickyStash/feature/63253-open-transaction-thread-on-top"

This reverts commit a1cfa2b, reversing
changes made to 8896509.
@VickyStash VickyStash mentioned this pull request Sep 29, 2025
Closed
16 tasks
@OSBotify

OSBotify commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.19-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.20-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@VickyStash VickyStash mentioned this pull request Sep 30, 2025
Merged
54 tasks done
@OSBotify

OSBotify commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.20-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify OSBotify mentioned this pull request Oct 2, 2025
Closed
52 tasks done
@OSBotify

OSBotify commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.22-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@IuliiaHerets

IuliiaHerets commented Oct 2, 2025

Copy link
Copy Markdown

Hey, @mountiny. Can we check it off?

@Julesssss

Julesssss commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Hey, @mountiny. Can we check it off?

Yeah checked off, this revert is from yesterdays checklist. I believe this is listed due to a failure in the staging build. Not sure about that though.

@OSBotify

OSBotify commented Oct 3, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.22-6 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments
@cristipaval cristipaval cristipaval approved these changes
@Gonals Gonals Awaiting requested review from Gonals

Assignees

@mountiny mountiny

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mountiny @OSBotify @IuliiaHerets @Julesssss @cristipaval