Repository navigation
[No QA] Bump pods after cocoapods update - #71395
roryabraham wants to merge 9 commits into
Conversation
|
Verify podfile passed, so that's good ✅ |
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
# Conflicts: # ios/Podfile.lock
# Conflicts: # ios/Podfile.lock
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
carlosmiceli
left a comment
There was a problem hiding this comment.
LGTM, anything in particular that could be troublesome in these bump PRs?
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
iOS build failing is concerning, mind checking? |
|
Do we still need this one? |
|
Going to close this and open a new external issue for the upgrade |
Explanation of Change
Cocoapods were updated here without updating the
Podfile.lock. I ran abundle install && bundle exec pod install, but for some reason that downgraded a lot of our pods. So then I ranbundle exec pod update, and this is the result.Fixed Issues
$ n/a
MOBILE_EXPENSIFY_PR: https://github.com/Expensify/Mobile-Expensify/pull/13724
Tests
None. Relying on regression tests.
Offline tests
None.
QA Steps
None.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop