Fix wrong parentheses in Chinese language - #71384
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@madmax330 @CortneyOfstad One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR contains a minor but meaningful correction to the Chinese language listing in the Account Settings documentation. The change fixes a formatting issue with parentheses that would improve the visual presentation and readability for users viewing the supported languages list. Scores Summary
Key FindingsPositive Aspects:
Areas Addressed:
Recommendations
Files Reviewed
Final AssessmentRecommendation: APPROVE This is an excellent example of attention to detail in documentation maintenance. The change is minimal, targeted, and improves the overall quality and consistency of the help documentation without any negative impact. Overall Score: 9.2/10 |
|
A preview of your ExpensifyHelp changes have been deployed to https://51e6f089.helpdot.pages.dev ⚡️ |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
HelpDot Documentation ReviewOverall AssessmentThis PR addresses a minor formatting issue with Chinese language parentheses in the Account Settings documentation. The change corrects spacing in the Chinese (Simplified) language listing, improving visual consistency and readability. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a simple formatting correction that enhances visual consistency in the language list. The document maintains high quality standards throughout. |
| - Portuguese (Português – Brasil) | ||
| - Japanese (日本語) | ||
| - Chinese (中文(简体)) | ||
| - Chinese (中文 (简体)) |
There was a problem hiding this comment.
Style improvement: The change from full-width parentheses to half-width parentheses is correct and improves readability. This fix aligns with standard formatting conventions for mixed-language content.
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.2.21-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.21-4 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.21-4 🚀
|
Explanation of Change
The previous parentheses had built in spaces and so rendered weirdly. This should fix it.
cc @sakluger @sonialiap
Fixed Issues
#70091
Tests
Same as QA
Offline tests
QA Steps
Go to https://help.expensify.com/articles/new-expensify/settings/Account-Settings and ensure the list of languages looks like the following:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop