[NoQA] Change names of the `SelectionList` components by zfurtak · Pull Request #71184 · Expensify/App

zfurtak · 2025-09-24T12:18:04Z

Explanation of Change

This PR follows up on the creation of the new `SelectionList` component

the original component will now serve as a Selection List with sections
the new component is a Selection List with a single section.
The updated naming was discussed here in the related issue.

Fixed Issues

$ #65212

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-09-24T12:18:10Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

war-in

Everything looks good except changes in SelectionList directory, but I suppose this is just a git diff created while renaming the files so ✅

war-in · 2025-09-24T15:31:58Z

-        expect(mouseEnterMock).toBeCalled();
+        expect(mouseEnterMock).toHaveBeenCalled();
        fireEvent(screen.getByTestId(testID), 'mouseLeave', {stopPropagation: jest.fn()});
-        expect(mouseLeaveMock).toBeCalled();
+        expect(mouseLeaveMock).toHaveBeenCalled();


Are those some kind of lint fixes? Seem unrelated

Yeah, I fixed it just because it's somehow familiar to list topic and toBeCalled() is deprecated

melvin-bot · 2025-09-25T08:53:26Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-09-25T09:00:28Z

Codecov Report

❌ Patch coverage is 59.92439% with 212 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ListWithSections/BaseSelectionListWithSections.tsx	75.24%	103 Missing ⚠️
src/components/SelectionList/BaseSelectionList.tsx	0.00%	100 Missing ⚠️
src/components/SelectionListWithSections/index.tsx	0.00%	6 Missing ⚠️
src/components/SelectionList/index.tsx	0.00%	2 Missing ⚠️
src/components/SelectionList/index.native.tsx	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

rushatgabhane · 2025-09-26T09:38:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

rushatgabhane

LGTM

conflicts are trivial

rushatgabhane · 2025-09-26T09:40:13Z

@zfurtak please fix failing lint

zfurtak · 2025-09-26T09:51:05Z

@rushatgabhane this check is failing because I change imports in many files, these are not my errors though. I could fix them but they're not connected

rushatgabhane · 2025-09-26T09:52:09Z

ah okay, we can ignore them

zfurtak · 2025-09-26T10:07:31Z

Conflicts resolved ✅

grgia

Gonna merge this now, but note that will want to watch the deploy checklist on Monday (or whenever this is deployed to staging) as this PR will make it harder for the next deployer to go through the diffs

melvin-bot · 2025-09-26T14:13:05Z

@grgia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2025-09-26T14:25:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

grgia · 2025-09-26T14:47:05Z

@grgia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

We decided not to fix lint errors in this PR as they are unrelated to the changes and will add to the complexity of the PR.

OSBotify · 2025-09-26T23:08:06Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.2.19-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-29T20:17:18Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.19-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Change original Selecto=ionList name

d3dcb0d

melvin-bot Bot assigned zfurtak Sep 24, 2025

zfurtak added 2 commits September 24, 2025 14:19

Merge branch 'main' into @zfurtak/change-SelectionList-name

96f70a1

Change new component

5d2bf6c

zfurtak changed the title ~~Change name of the original SelectionList~~ [NoQA] Change names of the SelectionList components Sep 24, 2025

war-in approved these changes Sep 24, 2025

View reviewed changes

Merge branch 'main' into @zfurtak/change-SelectionList-name

1b7d2df

zfurtak marked this pull request as ready for review September 25, 2025 08:53

zfurtak requested a review from a team as a code owner September 25, 2025 08:53

melvin-bot Bot requested review from dukenv0307 and removed request for a team September 25, 2025 08:53

zfurtak mentioned this pull request Sep 25, 2025

[Due for payment 2026-04-01] [TRACKING] Split SelectionList into smaller, purpose-built list components #65212

Closed

rushatgabhane approved these changes Sep 26, 2025

View reviewed changes

melvin-bot Bot requested a review from grgia September 26, 2025 09:38

Merge branch 'main' into @zfurtak/change-SelectionList-name

f229abc

rushatgabhane approved these changes Sep 26, 2025

View reviewed changes

grgia approved these changes Sep 26, 2025

View reviewed changes

grgia merged commit 3392aec into Expensify:main Sep 26, 2025
19 of 20 checks passed

melvin-bot Bot added the Emergency label Sep 26, 2025

grgia removed the Emergency label Sep 26, 2025

OSBotify mentioned this pull request Sep 26, 2025

Deploy Checklist: New Expensify 2025-09-26 #71399

Closed

62 tasks done

Conversation

zfurtak commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

This PR follows up on the creation of the new SelectionList component

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 24, 2025

Uh oh!

war-in left a comment

Choose a reason for hiding this comment

Uh oh!

war-in Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

zfurtak Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Sep 25, 2025

Uh oh!

codecov Bot commented Sep 25, 2025

Codecov Report

Uh oh!

rushatgabhane commented Sep 26, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Uh oh!

rushatgabhane commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zfurtak commented Sep 26, 2025

Uh oh!

rushatgabhane commented Sep 26, 2025

Uh oh!

zfurtak commented Sep 26, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot Bot commented Sep 26, 2025

Uh oh!

OSBotify commented Sep 26, 2025

Uh oh!

grgia commented Sep 26, 2025

Uh oh!

OSBotify commented Sep 26, 2025

Uh oh!

OSBotify commented Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zfurtak commented Sep 24, 2025 •

edited

Loading

This PR follows up on the creation of the new `SelectionList` component

rushatgabhane commented Sep 26, 2025 •

edited

Loading