Repository navigation
[Pre RN 0.81] Bump react-native-plaid-link-sdk - #71172
Conversation
|
|
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
@dukenv0307 can you test this please |
|
@mountiny yes, will test it soon |
|
on it now |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-09-24.at.23.48.55.movAndroid: mWeb ChromeiOS: HybridAppScreen.Recording.2025-09-25.at.22.54.40.moviOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
Hey @war-in @mountiny I tried to build app on iOS native but got this error
I saw many members faced the same issue as mine in Slack, after upgrading the Xcode version. Can you please help me test it on iOS native? Thanks |
|
@dukenv0307 do you suggest to test this on adhoc but you think the build issue is not related to this change? |
|
@mountiny Yes, here's the Slack conversation about this error https://expensify.slack.com/archives/C05LX9D6E07/p1758095032611099 |
|
It worked well on Android native. I'll try to build iOS native again |
|
@dukenv0307 it looks like the error is caused by the incompatible Xcode version. Some of our team members had the same error, and downgrading Xcode fixed it. I'm currently on 16.4, and builds are working fine Let me know if I can help with anything! |
|
Thank you @war-in, I can test it now |
mountiny
left a comment
There was a problem hiding this comment.
Thanks! I will move this ahead to avoid more conflicts now, I hope Rory wont mind
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.19-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.19-3 🚀
|
Explanation of Change
Our current
react-native-plaid-link-sdkversion (12.4.0) doesn't support React native 0.81 so we're bumping it to the latest one v12.5.3, which has 81 supportFixed Issues
$ #65991
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13711
Tests
Only iOS & Android
Add bank accountin the payment sectionLog into your bankConfirmbuttonOffline tests
Can't test in Offline Mode as the
Add Bank Accountbutton is disabled in Offline Mode, which is the expected behaviour.QA Steps
Only iOS & Android
Add bank accountin the payment sectionLog into your bankConfirmbuttonPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop