Skip to content

[No QA] perf: production bundle cleanup #71047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 3 commits into from
Sep 25, 2025
Merged

[No QA] perf: production bundle cleanup #71047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7004ca7
perf: dependency cleanup, add mini-css-extract-plugin
kstroz Sep 23, 2025
83bd20f
perf: change compiler version from 18 to 19
kstroz Sep 23, 2025
e92868c
perf: added miniCssExtractPlugin to webpack, ignore react-is
kstroz Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ require('dotenv').config();
const IS_E2E_TESTING = process.env.E2E_TESTING === 'true';

const ReactCompilerConfig = {
target: '18',
target: '19',
environment: {
enableTreatRefLikeIdentifiersAsRefs: true,
},
Expand Down
7 changes: 6 additions & 1 deletion config/webpack/webpack.common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import CopyPlugin from 'copy-webpack-plugin';
import dotenv from 'dotenv';
import fs from 'fs';
import HtmlWebpackPlugin from 'html-webpack-plugin';
import MiniCssExtractPlugin from 'mini-css-extract-plugin';
import path from 'path';
import TerserPlugin from 'terser-webpack-plugin';
import type {Class} from 'type-fest';
Expand Down Expand Up @@ -149,6 +150,9 @@ const getCommonConfiguration = ({file = '.env', platform = 'web'}: Environment):
new IgnorePlugin({
resourceRegExp: /@welldone-software\/why-did-you-render/,
}),
new IgnorePlugin({
resourceRegExp: /react-is/,
}),
]
: []),
...(platform === 'web' ? [new CustomVersionFilePlugin()] : []),
Expand All @@ -166,6 +170,7 @@ const getCommonConfiguration = ({file = '.env', platform = 'web'}: Environment):
// eslint-disable-next-line @typescript-eslint/naming-convention
__DEV__: /staging|prod|adhoc/.test(file) === false,
}),
...(isDevelopment ? [] : [new MiniCssExtractPlugin()]),

// This allows us to interactively inspect JS bundle contents
...(process.env.ANALYZE_BUNDLE === 'true' ? [new BundleAnalyzerPlugin()] : []),
Expand Down Expand Up @@ -232,7 +237,7 @@ const getCommonConfiguration = ({file = '.env', platform = 'web'}: Environment):
},
{
test: /\.css$/i,
use: ['style-loader', 'css-loader'],
use: isDevelopment ? ['style-loader', 'css-loader'] : [MiniCssExtractPlugin.loader, 'css-loader'],
},
{
test: /\.(woff|woff2)$/i,
Expand Down
44 changes: 43 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@
"octokit": "cd scripts && npx ts-node -i -e \"$(cat ./octokit.ts)\""
},
"dependencies": {
"@babel/runtime": "^7.25.0",
"@dnd-kit/core": "^6.3.1",
"@dnd-kit/modifiers": "^9.0.0",
"@dnd-kit/sortable": "^10.0.0",
Expand Down Expand Up @@ -225,7 +226,6 @@
"@babel/preset-flow": "^7.12.13",
"@babel/preset-react": "^7.10.4",
"@babel/preset-typescript": "^7.21.5",
"@babel/runtime": "^7.25.0",
"@babel/traverse": "^7.22.20",
"@babel/types": "^7.22.19",
"@callstack/reassure-compare": "^1.0.0-rc.4",
Expand Down Expand Up @@ -336,6 +336,7 @@
"jest-when": "^3.5.2",
"link": "^2.1.1",
"memfs": "^4.6.0",
"mini-css-extract-plugin": "^2.9.4",
"nitrogen": "0.29.4",
"onchange": "^7.1.0",
"openai": "5.5.1",
Expand Down
Loading