More Fraud Protection events by cristipaval · Pull Request #71031 · Expensify/App

cristipaval · 2025-09-22T21:16:55Z

Explanation of Change

Fixed Issues

$ #68284
PROPOSAL:

Tests

Tested with the adhoc builds and verified that the events are in the Group-IB dashboard.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

@cristipaval will QA this by verifying that the events are sent to the Group-IB dashboard

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-09-22T21:17:02Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-09-25T15:03:59Z

Codecov Report

❌ Patch coverage is 36.58537% with 26 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/libs/Middleware/FraudMonitoring.ts	36.36%	21 Missing ⚠️
src/libs/FraudProtection/GroupIBSdkBridge/index.ts	0.00%	5 Missing ⚠️

📢 Thoughts on this report? Let us know!

coleaeason · 2025-09-25T20:09:59Z

+        if (!signal.attribute) {
+            return responseData;
+        }
+
+        if (signal.attribute.isHashed) {
+            FraudProtection.setHashedAttribute(signal.attribute.key, signal.attribute.value);
+            return responseData;
+        }

-        return data;
+        FraudProtection.setAttribute(signal.attribute.key, signal.attribute.value);
+        return responseData;


Feels like we could save code here, and elsewhere, if you just kept the original pattern you had, where setAttribute took an optional param to set the hashing/encryption. Is there any reason with two separate functions?

yeah, there's no need for an extra function. Updated.

github-actions · 2025-09-25T21:22:46Z

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

coleaeason

looks good! thanks for renaming to shouldHash that was also bothering me haha

github-actions · 2025-09-25T22:00:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #71031.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/71031/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/71031/index.html

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	https://71031.pr-testing.expensify.com
The build for Desktop was skipped

👀 View the workflow run that generated this build 👀

OSBotify · 2025-09-26T23:07:24Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.19-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-09-29T20:16:36Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.19-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

cristipaval added 2 commits September 23, 2025 00:01

Add one more event

55631c4

Add events related to bank account setup

896d6e4

cristipaval requested a review from coleaeason September 22, 2025 21:16

cristipaval self-assigned this Sep 22, 2025

cristipaval requested a review from a team as a code owner September 22, 2025 21:16

cristipaval added the InternalQA This pull request required internal QA label Sep 22, 2025

melvin-bot Bot requested review from jayeshmangwani and removed request for a team September 22, 2025 21:16

cristipaval removed the request for review from jayeshmangwani September 22, 2025 21:17

Merge remote-tracking branch 'origin/main' into cristi_more-FP-events

358a972

cristipaval added 4 commits September 25, 2025 19:40

Add setHashedAttribute function

de2e906

Send hashed card number

069fa5d

pan instead of cardNumber from response

c0cd041

pan instead of cardNumber

4a6b379

coleaeason reviewed Sep 25, 2025

View reviewed changes

Improve hashing option when settings attributes

4852544

coleaeason approved these changes Sep 25, 2025

View reviewed changes

cristipaval merged commit 5edc01d into main Sep 25, 2025
23 of 25 checks passed

cristipaval deleted the cristi_more-FP-events branch September 25, 2025 22:38

cristipaval changed the title ~~More FP events~~ More Fraud Protection events Sep 25, 2025

OSBotify mentioned this pull request Sep 26, 2025

Deploy Checklist: New Expensify 2025-09-26 #71399

Closed

62 tasks done

Navigation Menu

Repository navigation

More Fraud Protection events - #71031

More Fraud Protection events#71031
cristipaval merged 8 commits into
mainfrom
cristi_more-FP-events

cristipaval commented Sep 22, 2025 •

edited

Loading

Uh oh!

melvin-bot Bot commented Sep 22, 2025

Uh oh!

codecov Bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

coleaeason Sep 25, 2025

Uh oh!

cristipaval Sep 25, 2025

Uh oh!

github-actions Bot commented Sep 25, 2025

Uh oh!

coleaeason left a comment

Uh oh!

github-actions Bot commented Sep 25, 2025

Uh oh!

Uh oh!

OSBotify commented Sep 26, 2025

Uh oh!

OSBotify commented Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

cristipaval commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 22, 2025

Uh oh!

codecov Bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coleaeason Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

cristipaval Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 25, 2025

Uh oh!

coleaeason left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Sep 25, 2025

Uh oh!

Uh oh!

OSBotify commented Sep 26, 2025

Uh oh!

OSBotify commented Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cristipaval commented Sep 22, 2025 •

edited

Loading

codecov Bot commented Sep 25, 2025 •

edited

Loading