[NoQA] Fix web profile trace by JKobrynski · Pull Request #70881 · Expensify/App

JKobrynski · 2025-09-19T14:37:46Z

Explanation of Change

It was reported on Slack that profile trace on web is broken and can't be used in any available software to investigate performance issues. This PR makes it possible to generate a trace that after symbolication can be viewed in chrome://tracing and ui.perfetto.dev, speedscope doesn't work, probably because of the symbolicated profile trace's size. The size is another problem that we could address in the future, but this fix would make it possible to see anything in these traces for now.

Fixed Issues

$ #72127
PROPOSAL: N/A

Tests

Log into the app
Toggle the "Record Troubleshoot Data" switch
Perform some simple actions in the app (e.g. send messages, load reports)
Toggle the switch again
Download the profile trace
Symbolicate the profile trace
Upload it to chrome://tracing or ui.perfetto.dev
Make sure there are no errors once it's uploaded

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Log into the app
Toggle the "Record Troubleshoot Data" switch
Perform some simple actions in the app (e.g. send messages, load reports)
Toggle the switch again
Make sure the app works as expected and doesn't break or become laggy

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-09-19T14:38:28Z

@aldo-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny

Thanks!

ZhenjaHorbach · 2025-09-19T15:09:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

NA

Android: mWeb Chrome

2025-09-19.17.32.52.mov

iOS: HybridApp

NA

iOS: mWeb Safari

2025-09-19.17.27.45.mov

MacOS: Chrome / Safari

2025-09-19.17.18.44.mov

MacOS: Desktop

2025-09-19.17.24.29.mov

ZhenjaHorbach · 2025-09-19T15:35:37Z

@JKobrynski
Actually interesting
Is it okay that on android-web I download troubleshoot.zip and cpuprofile, but on ios-web only troubleshoot.zip ?
And the same on staging

aldo-expensify · 2025-09-19T20:18:09Z

            Performance.disableMonitoring();
        }
-        toggleProfileTool(isProfilingInProgress);
+        toggleProfileTool(shouldProfiling);


NAB: shouldn't this variable be named shouldProfile?

mountiny · 2025-09-19T21:29:08Z

Good shout, I think we can rename it in the next pr (there will be some more for this to get fixed completely)

mountiny · 2025-09-19T21:29:29Z

@ZhenjaHorbach also something to handle, but for now this should unblock the feature to some extent, thanks!

ZhenjaHorbach · 2025-09-19T21:31:17Z

@ZhenjaHorbach also something to handle, but for now this should unblock the feature to some extent, thanks!

Oh
Okay 😅
But I completed the checklist anyway!

OSBotify · 2025-09-19T21:42:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-19T22:56:18Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.16-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

ZhenjaHorbach · 2025-09-20T06:10:05Z

@mountiny
Can we please create an issue for this PR?

ZhenjaHorbach · 2025-09-23T07:35:12Z

@JKobrynski Actually interesting Is it okay that on android-web I download troubleshoot.zip and cpuprofile, but on ios-web only troubleshoot.zip ? And the same on staging

@JKobrynski
Could you check this please?

OSBotify · 2025-09-23T19:38:10Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.2.16-14 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

ZhenjaHorbach · 2025-10-08T14:19:42Z

@mountiny
Can we please create a payment issue for this PR?
The PR was merged before my approval
But the checklist was completely ready, but I didn't approve due to ios-web issue (which would be nice to fix if we want full web support for profile trace)

mountiny · 2025-10-08T18:33:13Z

Issue here #72127

fix onToggleProfiling method

79a6cc6

JKobrynski requested a review from a team as a code owner September 19, 2025 14:37

melvin-bot Bot assigned JKobrynski Sep 19, 2025

melvin-bot Bot requested review from aldo-expensify and removed request for a team September 19, 2025 14:38

mountiny changed the title ~~Fix web profile trace~~ [NoQA] Fix web profile trace Sep 19, 2025

mountiny approved these changes Sep 19, 2025

View reviewed changes

mountiny requested a review from ZhenjaHorbach September 19, 2025 15:08

aldo-expensify approved these changes Sep 19, 2025

View reviewed changes

mountiny merged commit 4207ae4 into Expensify:main Sep 19, 2025
22 of 23 checks passed

OSBotify mentioned this pull request Sep 19, 2025

Deploy Checklist: New Expensify 2025-09-19 #70900

Closed

mountiny mentioned this pull request Oct 8, 2025

[$250] Investigate the web traces being too big #72127

Closed

Conversation

JKobrynski commented Sep 19, 2025 • edited by mountiny Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 19, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aldo-expensify Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny commented Sep 19, 2025

Uh oh!

mountiny commented Sep 19, 2025

Uh oh!

Uh oh!

ZhenjaHorbach commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Sep 19, 2025

Uh oh!

OSBotify commented Sep 19, 2025

Uh oh!

ZhenjaHorbach commented Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Sep 23, 2025

Uh oh!

OSBotify commented Sep 23, 2025

Uh oh!

ZhenjaHorbach commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JKobrynski commented Sep 19, 2025 •

edited by mountiny

Loading

ZhenjaHorbach commented Sep 19, 2025 •

edited

Loading

ZhenjaHorbach commented Sep 19, 2025 •

edited

Loading

ZhenjaHorbach commented Sep 19, 2025 •

edited

Loading

ZhenjaHorbach commented Sep 20, 2025 •

edited

Loading

ZhenjaHorbach commented Oct 8, 2025 •

edited

Loading