Skip to content

[NO QA] fix conditionals to actually work when merged to main #70842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blimpich merged 3 commits into from
Sep 23, 2025
Merged

[NO QA] fix conditionals to actually work when merged to main #70842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d59559c
fix conditionals to actually work when merged to main
blimpich Sep 18, 2025
2e3ee62
pass secrets to workflow
blimpich Sep 18, 2025
3967147
remove always true conditional
blimpich Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/preDeploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:

test:
uses: ./.github/workflows/test.yml
secrets: inherit

confirmPassingBuild:
runs-on: ubuntu-latest
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
- name: Load Codecov token from 1Password
id: load-codecov-token
# Codecov needs a token to be run on the default branch (which happens in preDeploy.yml after a PR is merged to main)
if: ${{ github.event_name == 'workflow_call' && github.ref == 'refs/heads/main' }}
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}

@roryabraham roryabraham Sep 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! I didn't realize that workflow_call inherited the parent event_name.

@roryabraham roryabraham Sep 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this somewhere, or how did you figure this out?

@blimpich blimpich Sep 18, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I assumed it would be workflow_call but then saw that that wasn't right when we merged #68481 and the job skipped all the CodeCov steps.

Didn't test, I just ran gh run view --job=50728865194 and saw that it said it said Triggered via push in the output, so figured that we needed to use push instead of workflow_call.

Screenshot 2025-09-18 at 4 12 30 PM

# v2
uses: 1password/load-secrets-action@581a835fb51b8e7ec56b71cf2ffddd7e68bb25e0
with:
Expand All @@ -69,7 +69,7 @@ jobs:
CODECOV_TOKEN: op://${{ vars.OP_VAULT }}//CodeCov-API/key

- name: Upload coverage to Codecov (token required)
if: ${{ github.event_name == 'workflow_call' && github.ref == 'refs/heads/main' }}
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
# v5
uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7
with:
Expand Down
Loading