fix: Update copy in the Reject RHP - #70529
Merged
Merged
Conversation
Collaborator
Author
|
@truph01 Will take care of the review. |
mananjadhav
marked this pull request as ready for review
September 14, 2025 19:21
melvin-bot
Bot
requested review from
truph01
and removed request for
a team
September 14, 2025 19:21
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-09-15.at.14.55.37.movAndroid: mWeb ChromeScreen.Recording.2025-09-15.at.14.58.48.moviOS: HybridAppScreen.Recording.2025-09-15.at.14.50.44.moviOS: mWeb SafariScreen.Recording.2025-09-15.at.14.59.17.movMacOS: Chrome / SafariScreen.Recording.2025-09-15.at.14.48.37.movMacOS: DesktopScreen.Recording.2025-09-15.at.14.53.04.mov |
Contributor
|
PR looks good. Just need to wait for the translation confirmation |
truph01
approved these changes
Sep 17, 2025
lakchote
approved these changes
Sep 17, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.16-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.2.16-14 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #70482
PROPOSAL: NA
Tests
Precondition:
Test:
More->RejectHold vs Rejectmodal opens, click onGot it.Explain why you're rejecting this expense.Offline tests
Same as test steps
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as test steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop