fix: Wrong take-off time in Concierge reply in the Trip room - #70051
stitesExpensify merged 7 commits into
Conversation
c2c7924 to
039d59e
Compare
|
@TaduJR Are you able to add screenshots? |
|
@TaduJR Thanks, but I'd rather have a secondary source, rather than relying on your mock being correct. |
a178467 to
9c1ee13
Compare
df32d61 to
7b3542b
Compare
@jjcoffee Added screenshot for chrome using the onyx-state provided on the issue |
…ge-reply-in-the-Trip-room
|
@TaduJR It looks like you've also changed the date format, which probably isn't expected here. On staging it's just |
|
Added the screenshots for all platforms @jjcoffee |
|
Also I update the Proposal with the new way |
Reviewer Checklist
Screenshots/Videos |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.2.16-0 🚀
|
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.2.16-14 🚀
|





Explanation of Change
Fixed Issues
$ #69077
PROPOSAL: #69077 (comment)
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop