Repository navigation
PaymentMethodList backTo forwardTo removing #69750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mountiny
merged 15 commits into
Expensify:main
from
software-mansion-labs:collectioneur/paymentmethodlist-back-to-forward-to-removing
Sep 17, 2025
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
eef3f9a
added two routes in two places and removed backTo and forwardTo in pa…
collectioneur ddd4de4
small changes, adding comments
collectioneur 75edf3e
Merge branch 'feat/verify-account-uses-navigation-modal' into collect…
collectioneur c8ee404
Merge branch 'main' into collectioneur/paymentmethodlist-back-to-forw…
collectioneur 1b5eae3
fixed some things
collectioneur a9d01a7
changed props for VerifyAccountPage
collectioneur bb73941
fixed some screens + RHP related to deep links and fixed path for ve…
collectioneur 5822d12
Merge branch 'main' into collectioneur/paymentmethodlist-back-to-forw…
collectioneur eee6557
Merge branch 'main' into collectioneur/paymentmethodlist-back-to-forw…
collectioneur 8c20907
added displayName
collectioneur b41cedf
Merge branch 'main' into collectioneur/paymentmethodlist-back-to-forw…
jmusial 876f5f3
Merge branch 'main' into collectioneur/paymentmethodlist-back-to-forw…
jmusial 797f429
rename VerifyAccountPage
jmusial babe2a3
rename VarifyAccountPage v2
jmusial 89e0fcf
missed it indeed
jmusial File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
src/pages/settings/Wallet/NewBankAccountVerifyAccountPage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import React from 'react'; | ||
| import VerifyAccountPageBase from '@pages/settings/VerifyAccountPageBase'; | ||
| import ROUTES from '@src/ROUTES'; | ||
|
|
||
| function NewBankAccountVerifyAccountPage() { | ||
| return ( | ||
| <VerifyAccountPageBase | ||
| navigateBackTo={ROUTES.SETTINGS_WALLET} | ||
| navigateForwardTo={ROUTES.SETTINGS_ADD_BANK_ACCOUNT.route} | ||
| /> | ||
| ); | ||
| } | ||
|
|
||
| NewBankAccountVerifyAccountPage.displayName = 'NewBankAccountVerifyAccountPage'; | ||
|
|
||
| export default NewBankAccountVerifyAccountPage; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
src/pages/workspace/invoices/WorkspaceInvoicesVerifyAccountPage.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import React from 'react'; | ||
| import type {PlatformStackScreenProps} from '@libs/Navigation/PlatformStackNavigation/types'; | ||
| import type {WorkspaceSplitNavigatorParamList} from '@libs/Navigation/types'; | ||
| import VerifyAccountPageBase from '@pages/settings/VerifyAccountPageBase'; | ||
| import ROUTES from '@src/ROUTES'; | ||
| import type SCREENS from '@src/SCREENS'; | ||
|
|
||
| type WorkspaceInvoicesVerifyAccountPageProps = PlatformStackScreenProps<WorkspaceSplitNavigatorParamList, typeof SCREENS.WORKSPACE.INVOICES_VERIFY_ACCOUNT>; | ||
| function WorkspaceInvoicesVerifyAccountPage({route}: WorkspaceInvoicesVerifyAccountPageProps) { | ||
| const workspaceInvoicePath = ROUTES.WORKSPACE_INVOICES.getRoute(route.params.policyID); | ||
| return ( | ||
| <VerifyAccountPageBase | ||
| navigateBackTo={workspaceInvoicePath} | ||
| navigateForwardTo={ROUTES.SETTINGS_ADD_BANK_ACCOUNT.getRoute(workspaceInvoicePath)} | ||
| /> | ||
| ); | ||
| } | ||
|
|
||
| WorkspaceInvoicesVerifyAccountPage.displayName = 'WorkspaceInvoicesVerifyAccountPage'; | ||
|
|
||
| export default WorkspaceInvoicesVerifyAccountPage; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This route forwarding here led to this issue:
Which Melvin corrected by changing the route to: