Upgrade lottie-react-native to the latest version - #69597
Conversation
|
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
I'm getting following errors when trying to load lotties using the latest web adhoc build cc @mountiny |
|
@justinpersaud 👋 I see we have added the proxy back here https://github.com/Expensify/Cloudflare-Workers/pull/180/files and now @war-in is testing removing the patch that was avoiding using the proxy - however, seems like the CSP is still not happy, could you please take a look? |
|
Turns out https://assets.expensify.com was already in use for something, but I'm not sure what. Rather than go down that path, I'll update the proxy I setup to https://cdn.expensify.com instead. Once that happens, we need to source the scripts from that domain instead of https://cdn.jsdeliver.net The path would then be once I have updated it |
|
Ok, the https://cdn.expensify.com proxy is updated. @mountiny I sent you a PR for that rename here https://github.com/Expensify/Cloudflare-Workers/pull/201 |
|
@justinpersaud Vit confirmed that changes are deployed and I can test it now, but I'm still getting the same error when using the adhochttps://69597.pr-testing.expensify.com/ 
|
|
You need to use the proxy. You are still pointing directly to to https://cdn.jsdelivr.net when it should be https://cdn.expensify.com/cdn.jsdelivr.net/npm/@lottiefiles/dotlottie-web@0.44.0/dist/dotlottie-player.wasm |
# Conflicts: # package-lock.json # package.json
|
🚧 @trjExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
@justinpersaud do we have a proxy for 
|
|
🚧 @trjExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
ok guys, I used the right url this time and still got an error on the latest build (please ignore the hybrid app log) Any ideas? |
This comment has been minimized.
This comment has been minimized.
|
We added the new cdn proxy to |
|
@nyomanjyotisa @mountiny One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I don't think the failing test is related to my changes. It works really well when I run it locally |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@Krishna2323 yes, please do 🙏 |
|
Reviewing... |
|
Conflicts @war-in |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppWhatsApp.Video.Jun.17.2026.1.mp4Android: mWeb ChromeWhatsApp.Video.Jun.17.2026.mp4iOS: HybridAppios_hybrid.mp4iOS: mWeb Safariios__safari.mp4MacOS: Chrome / Safariweb_chrome.mp4 |
|
@war-in One minor comment and some merge conflicts are left. Otherwise, this works well. |
# Conflicts: # package-lock.json # package.json
|
@mountiny @Krishna2323 comment and conflicts resolved |
|
To avoid conflicts, I will merge these now |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.10-0 🚀
Bundle Size Analysis (Sentry): |
Help site review: no changes requiredI reviewed the changes in this PR against the help site files under Why: This is an internal dependency upgrade with no user-facing behavior changes:
The affected animations (the sign-in Lottie and Settings section illustrations) render the same content as before — only the underlying rendering library changed. None of the help articles describe these animations, the library, or any flow that this PR alters. There are no new or renamed features, tabs, settings labels, or buttons to document. If the animation upgrade is later paired with a user-facing feature change, that follow-up would be the right place to revisit the docs. @war-in, since no docs changes are required, I did not create a help site PR. Please confirm this assessment reflects the current behavior. If you believe a help article should be updated, let me know what flow it should cover and I'll create the draft PR. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.12-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 I reviewed the changes in this PR against the help site files under No help site documentation changes are required. This PR is a dependency upgrade — it bumps
There is no new or changed user-facing feature, page, tab, setting, button, or label. The Lottie animations (sign-in screen, native section illustrations) render exactly as before, so nothing documented in the help site is affected. Accordingly, I did not create a draft docs PR. @war-in, please confirm you agree no help site updates are needed. If you believe a docs change is warranted, reply with the specifics and I'll open a draft PR. |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.14-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.14-1 🚀
|
6 participants
Explanation of Change
Bumps
lottie-react-nativefrom6.5.1to7.3.8, which natively supports the newest React Native version. This lets us drop 4 patches (bridgeless, RN-77/80/83 support) that are now upstream; only therecyclingpatch remains (renamed to7.3.8). Adds@lottiefiles/dotlottie-react(used on web), pointing its WASM binary at the Expensify CDN to avoid a CSP block.Fixed Issues
$ #93615
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13682
Tests
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop