Fix broken global create emoji by bernhardoj · Pull Request #69411 · Expensify/App

bernhardoj · 2025-08-28T05:51:18Z

Explanation of Change

Fixed Issues

$ #67976
PROPOSAL: #67976 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Precondition: copy the global create emoji

Create a new expense on a workspace chat
Edit the merchant and use the global create emoji as the merchant
~~3. Verify the global create emoji shows correctly on the merchant input~~
Verify the merchant update system message shows the global create emoji correctly

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

x

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-08-28T05:51:24Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2025-08-28T05:51:24Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2025-08-28T07:32:20Z

     * Calls the onChangeText callback with a modified room name
     */
-    const setModifiedRoomName = (event: NativeSyntheticEvent<TextInputChangeEventData>) => {
-        const roomName = event.nativeEvent.text;


@ishpaul777 The event from live markdown doesn't have text, so I need to use onChangeText instead. This makes me think that we might get some uncaught errors when replacing all text input with live markdown input, since there are a lot of text input in our app.

@bernhardoj thanks for bringing this up, your concern is valid. I think the best step would be to carefully audit each usage, manually test any special cases (like amount input or magic code), and add automated UI tests wherever possible.

I found another crash when trying to input the password for a PDF-protected form. This makes me think that we should probably find a more reliable approach. Currently, the global create emoji Unicode is only recognized by our custom font file (CustomEmojiWebFont.ttf).

I'm thinking that maybe it's best to somehow edit our current Expensify font (ExpensifyMono-, ExpensifyNeue-, ExpensifyNewKansas-*) to include the global create emoji unicode. This way, we don't need CustomEmojiWebFont.ttf anymore. But:

I haven't checked how to do it yet

The font is created/updated by a 3rd-party, so every time the font is updated, we will need to re-add the global create emoji unicode to the font file.

@bernhardoj If we can get support for custom emojis added upstream by the 3rd-party font maintainer, that would be ideal. I’d lean against maintaining a separate patched version ourselves since it could become error-prone and difficult to keep in sync with updates.

@bernhardoj if you'd like to pivot to this solution, lets first bring it to the slack and involve design team as well

Posted here: https://expensify.slack.com/archives/C01GTK53T8Q/p1757354319213359

@ishpaul777 based on the disc, should we just handle the non-text input case?

that sounds good @bernhardoj, please let me know when its ready

@ishpaul777 Updated.

ishpaul777 · 2025-09-07T15:29:10Z

gentle bump @bernhardoj 👋

ishpaul777 · 2025-09-15T17:48:29Z

@bernhardoj its still broken on android for menuitem, can you please check?

Screen.Recording.2025-09-15.at.11.16.58.PM.mov

ishpaul777 · 2025-09-15T18:00:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-09-15.at.11.30.08.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-09-15.at.11.16.58.PM.mov

iOS: HybridApp

Screen.Recording.2025-09-15.at.10.41.10.PM.mov

iOS: mWeb Safari

Screen.Recording.2025-09-15.at.10.27.32.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-09-15.at.10.13.58.PM.mov

MacOS: Desktop

Screen.Recording.2025-09-15.at.11.23.00.PM.mov

bernhardoj · 2025-09-16T03:08:01Z

Checking

bernhardoj · 2025-09-16T06:21:53Z

    const isOnlyCustomEmoji = useMemo(() => {
        if (typeof children === 'string') {
-            return containsOnlyCustomEmoji(children);
+            return containsOnlyCustomEmoji(children.replace(CONST.UNICODE.LTR, ''));


Fixed. MenuItem prepend LTR unicode on Android only, so we need to clean it here before checking. (we still render the whole text with the LTR unicode)

App/src/components/MenuItem.tsx

Line 617 in ae3b077

return title ? convertToLTR(title) : '';

ishpaul777

lgtm!

MonilBhavsar

👍

OSBotify · 2025-09-17T18:01:07Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-09-19T22:51:21Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.2.16-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-09-23T19:33:34Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.2.16-14 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix broken global create emoji

3809619

bernhardoj requested a review from a team as a code owner August 28, 2025 05:51

melvin-bot Bot assigned bernhardoj Aug 28, 2025

melvin-bot Bot requested review from ishpaul777 and removed request for a team August 28, 2025 05:51

fix type

9f8fd9b

bernhardoj changed the title ~~Fix broken global create emoji~~ [HOLD Live Markdown #725] Fix broken global create emoji Aug 28, 2025

bernhardoj added 2 commits August 28, 2025 15:29

fix test

576e117

fix crash when typing in new room page

62d5c3b

bernhardoj commented Aug 28, 2025

View reviewed changes

bernhardoj added 2 commits August 28, 2025 15:33

prettier

03411bb

Merge branch 'main' into fix/67976-broken-global-create

324e5ee

bernhardoj added 2 commits September 12, 2025 10:29

Merge branch 'main' into fix/67976-broken-global-create

9ea4cc2

revert text input fix

c3fac07

bernhardoj changed the title ~~[HOLD Live Markdown #725] Fix broken global create emoji~~ Fix broken global create emoji Sep 12, 2025

bernhardoj added 2 commits September 16, 2025 14:20

Merge branch 'main' into fix/67976-broken-global-create

0b743a0

fix global create emoji only doesn't show correctly on Android

2d03ed8

bernhardoj commented Sep 16, 2025

View reviewed changes

ishpaul777 reviewed Sep 16, 2025

View reviewed changes

ishpaul777 approved these changes Sep 16, 2025

View reviewed changes

melvin-bot Bot requested a review from MonilBhavsar September 16, 2025 14:58

MonilBhavsar approved these changes Sep 17, 2025

View reviewed changes

MonilBhavsar merged commit 522afa4 into Expensify:main Sep 17, 2025
23 checks passed

OSBotify mentioned this pull request Sep 19, 2025

Deploy Checklist: New Expensify 2025-09-19 #70900

Closed

melvin-bot Bot mentioned this pull request Sep 23, 2025

[Due for payment 2025-09-30] [$250] Chat - Broken icon shown instead of custom global create emoji in Reports and Merchant #67976

Closed

16 tasks

Conversation

bernhardoj commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 28, 2025

Uh oh!

melvin-bot Bot commented Aug 28, 2025

Uh oh!

bernhardoj Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ishpaul777 commented Sep 7, 2025

Uh oh!

ishpaul777 commented Sep 15, 2025

Uh oh!

ishpaul777 commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

bernhardoj commented Sep 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ishpaul777 left a comment

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Sep 17, 2025

Uh oh!

OSBotify commented Sep 19, 2025

Uh oh!

OSBotify commented Sep 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bernhardoj commented Aug 28, 2025 •

edited

Loading

bernhardoj Aug 28, 2025 •

edited

Loading

ishpaul777 commented Sep 15, 2025 •

edited

Loading