Skip to content

Duplicate workspace - #67412

Merged
stitesExpensify merged 40 commits into
Expensify:mainfrom
callstack-internal:duplicate-workspace
Aug 21, 2025
Merged

Duplicate workspace#67412
stitesExpensify merged 40 commits into
Expensify:mainfrom
callstack-internal:duplicate-workspace

Conversation

@narefyev91

@narefyev91 narefyev91 commented Jul 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

New feature from OldDot - Duplicate workspace

Fixed Issues

$ #67289
PROPOSAL:

Tests

  1. Go to Workspaces list
  2. Click on 3 dots on workspace in which you are admin
  3. Click on Duplicate workspace
  4. Verify that in the right panel Duplicate workspace fist step is opened with Avatar selector and pre-filled name (current workspace name (Duplicate).
  5. Verify that you could not proceed without workspace name
  6. Click next - verify that next step is shown with list and checkboxes
  7. Verify that you see correct information for each section (check design doc)
  8. Click Select All - verify that all items are selected, un check Select All - verify that all items are un selected
  9. Select All/ pick some items - click next - verify that modal is shown with correct information about workspace
  10. Click cancel - verify that modal is closed
  11. click proceed - verify that modal is closed, right panel is closed, on the workspace list new row is added - verify that it's highlighted (and scrolled to it if list with workspaces are long)
  12. Verify that selected features from step 9 also presented in the new workspace
  13. Verify that admin chat and expense chats are created as well
  • Verify that no errors appear in the JS console

Offline tests

  1. Go to Workspaces list
  2. Click on 3 dots on workspace in which you are admin
  3. Click on Duplicate workspace
  4. Verify that in the right panel Duplicate workspace fist step is opened with Avatar selector and pre-filled name (current workspace name (Duplicate).
  5. Verify that you could not proceed without workspace name
  6. Click next - verify that next step is shown with list and checkboxes
  7. Verify that you see correct information for each section (check design doc)
  8. Click Select All - verify that all items are selected, un check Select All - verify that all items are un selected
  9. Select All/ pick some items - click next - verify that modal is shown with correct information about workspace
  10. Click cancel - verify that modal is closed
  11. click proceed - verify that modal is closed, right panel is closed, on the workspace list new row is added - verify that it's highlighted (and scrolled to it if list with workspaces are long). Also verify that styles applies for offline row (same as in other places in the app)
  12. Verify that selected features from step 9 also presented in the new workspace

QA Steps

  1. Go to Workspaces list
  2. Click on 3 dots on workspace in which you are admin
  3. Click on Duplicate workspace
  4. Verify that in the right panel Duplicate workspace fist step is opened with Avatar selector and pre-filled name (current workspace name (Duplicate).
  5. Verify that you could not proceed without workspace name
  6. Click next - verify that next step is shown with list and checkboxes
  7. Verify that you see correct information for each section (check design doc)
  8. Click Select All - verify that all items are selected, un check Select All - verify that all items are un selected
  9. Select All/ pick some items - click next - verify that modal is shown with correct information about workspace
  10. Click cancel - verify that modal is closed
  11. click proceed - verify that modal is closed, right panel is closed, on the workspace list new row is added - verify that it's highlighted (and scrolled to it if list with workspaces are long)
  12. Verify that selected features from step 9 also presented in the new workspace
  13. Verify that admin chat and expense chats are created as well
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
android-web.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov

@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@narefyev91

narefyev91 commented Aug 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Demo (BE still working on API integration):

Screen.Recording.2025-08-06.at.15.45.03.mov

@narefyev91

narefyev91 commented Aug 6, 2025

Copy link
Copy Markdown
Contributor Author

I will record all videos tomorrow - when API will be ready and reachable.
Also i will add correct text translations tomorrow - probably with chartgpt.
Anyway - during C+ review we could rely on optimistic data and check flow without blockers

@narefyev91
narefyev91 marked this pull request as ready for review August 6, 2025 13:40
@narefyev91
narefyev91 requested a review from a team as a code owner August 6, 2025 13:40
@melvin-bot
melvin-bot Bot requested review from DylanDylann and removed request for a team August 6, 2025 13:40
@melvin-bot

melvin-bot Bot commented Aug 6, 2025

Copy link
Copy Markdown

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot

melvin-bot Bot commented Aug 20, 2025

Copy link
Copy Markdown

We did not find an internal engineer to review this PR, trying to assign a random engineer to #67289 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

@melvin-bot
melvin-bot Bot requested a review from stitesExpensify August 20, 2025 05:03
@DylanDylann

DylanDylann commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

The rest looks fine

@narefyev91

narefyev91 commented Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

Just making sure - is this copy being included in the code? Thanks!

yeah - copy is in place

@narefyev91
updates after review
e99ded3
@narefyev91
Merge branch 'main' into duplicate-workspace
32e651d 
# Conflicts:
#	src/libs/actions/Policy/Policy.ts
#	src/types/onyx/index.ts
stitesExpensify
stitesExpensify approved these changes Aug 21, 2025
View reviewed changes

@stitesExpensify stitesExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long PR but it all looks great, nice job!

@stitesExpensify
stitesExpensify merged commit 8f4897f into Expensify:main Aug 21, 2025
20 checks passed
@OSBotify

OSBotify commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 22, 2025
Closed
@jponikarchuk jponikarchuk mentioned this pull request Aug 22, 2025
Closed
8 tasks
@OSBotify

OSBotify commented Aug 22, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.1.98-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

This was referenced Aug 22, 2025
Closed
Closed
francoisl added a commit that referenced this pull request Aug 22, 2025
@francoisl
Revert "Merge pull request #67412 from callstack-internal/duplicate-w…
adeeb36 
…orkspace"

This reverts commit 8f4897f, reversing
changes made to 485a092.
@francoisl francoisl mentioned this pull request Aug 22, 2025
Merged
51 tasks
@lanitochka17 lanitochka17 mentioned this pull request Aug 22, 2025
Closed
16 tasks
@samranahm samranahm mentioned this pull request Aug 22, 2025
Closed
8 tasks
yuwenmemon added a commit that referenced this pull request Aug 22, 2025
@yuwenmemon
Merge pull request #69055 from Expensify/francois-revert-67412
766ff9b 
[CP Staging] Revert #67412 "Duplicate workspace"
OSBotify pushed a commit that referenced this pull request Aug 22, 2025
@yuwenmemon @OSBotify
Merge pull request #69055 from Expensify/francois-revert-67412
a6a72cc 
[CP Staging] Revert #67412 "Duplicate workspace"

(cherry picked from commit 766ff9b)

(cherry-picked to staging by francoisl)
@lanitochka17 lanitochka17 mentioned this pull request Aug 22, 2025
Closed
16 tasks
@jponikarchuk jponikarchuk mentioned this pull request Aug 22, 2025
Closed
8 tasks
@carlosmiceli carlosmiceli mentioned this pull request Aug 22, 2025
Closed
@stitesExpensify

stitesExpensify commented Aug 22, 2025

Copy link
Copy Markdown
Contributor

Another blocker here

@OSBotify

OSBotify commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.98-12 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.1.99-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.99-11 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@melvin-bot melvin-bot Bot mentioned this pull request Aug 28, 2025
Closed
@MelvinBot MelvinBot mentioned this pull request Aug 18, 2026
Closed
7 tasks
aimane-chnaif
aimane-chnaif reviewed Aug 18, 2026
View reviewed changes
Comment thread src/libs/actions/Policy/Policy.ts
areCategoriesEnabled: isCategoriesOptionSelected,
areTagsEnabled: isTagsOptionSelected,
areDistanceRatesEnabled: isCustomUnitsOptionSelected,
areInvoicesEnabled: isInvoicesOptionSelected,

@aimane-chnaif aimane-chnaif Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR built the optimistic duplicated policy by spreading the entire source policy while turning on invoices, but never reset the per‑workspace invoice object:

// invoice (companyName / companyWebsite / Stripe bankAccount) is inherited from the source — this is the bug

So the duplicate inherited the source's invoice.companyName/companyWebsite, hasInvoicingDetails() returned true, the company‑info step was skipped, and SendInvoice ran against a workspace that was never provisioned for invoicing → the "unexpected error".

We fixed this by adding invoice: undefined here.

Regression Issue: Invoice created via duplicate workspace shows error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesdeanexpensify jamesdeanexpensify jamesdeanexpensify left review comments
@stitesExpensify stitesExpensify stitesExpensify approved these changes
+2 more reviewers
@aimane-chnaif aimane-chnaif aimane-chnaif left review comments
@DylanDylann DylanDylann DylanDylann approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.