[NO QA] Update en.ts - #67409
[NO QA] Update en.ts#67409
Conversation
Fixing grammar mistake
|
@dangrous I checked the Spanish file and it was correct. I'm happy to spot check other languages if needed - though, can you remind me where those are stored? Thanks! |
There was a problem hiding this comment.
English LGTM!
For the other languages, they're all just in that src/languages folder - but I think they would autoupdate in theory? honestly I don't entirely know how that works...
EDIT: Looks like it's this - https://github.com/Expensify/App#running-the-translation-script - I guess we should run that on this PR? Let me know and I can handle that, though we'll need another reviewer.
|
All of the translations that I know enough of to check (french, italian, german) have a plural for |
|
Works for me, thank you! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.88-0 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.1.88-3 🚀
|
Fixing grammar mistake
Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop