Fix onboarding flow path changes after page refresh by MobileMage · Pull Request #67017 · Expensify/App

MobileMage · 2025-07-24T00:53:34Z

Explanation of Change

Add early path validation check in getOnboardingInitialPath to prioritize resuming existing onboarding paths on refresh instead of redirecting to personal-details. This ensures users remain on their current onboarding step when refreshing the page by checking if the stored onboardingInitialPath is valid before falling back to domain/policy-based logic.

Fixed Issues

$ #65947
PROPOSAL: #65947 (comment)

Tests

Sign up on new.expensify.com
Select "Manage my team" as purpose
Select 1-10 employees
Navigate to the "Do you use any accounting software?" step
Refresh the page
Verify that the user remains on the "Do you use any accounting software?" page instead of being redirected to personal-details
Complete the onboarding flow normally to ensure no regression
Test with different onboarding paths (individual user, larger team sizes) and verify refresh behavior works correctly
Test initial onboarding (without refresh) to ensure existing flow is not broken

Verify that no errors appear in the JS console

Offline tests

Same as QA

QA Steps

Sign up on new.expensify.com
Select "Manage my team" as purpose
Select 1-10 employees
Navigate to the "Do you use any accounting software?" step
Refresh the page (F5 or Ctrl+R)
Verify that the user remains on the "Do you use any accounting software?" page and the URL shows the correct path
Complete the onboarding flow and verify it ends properly
Test the same scenario with different employee count selections (1-10, 11-100, 100+)
Test with "Track my expenses" option and verify refresh behavior works correctly
Test initial onboarding flow without refresh to ensure no regressions
Test on multiple browsers (Chrome, Firefox, Safari, Edge)
Test on mobile devices (iOS Safari, Android Chrome)
Verify that refreshing on other onboarding steps also maintains correct path

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

onboard-path-android-native.mp4

Android: mWeb Chrome

onboard-path-android-mweb.mp4

iOS: Native

onboard-path-ios-native.mp4

iOS: mWeb Safari

onboard-path-ios-mweb.mp4

MacOS: Chrome / Safari

refresh.fix.desktop.web.mp4

MacOS: Desktop

onboard-path-desktop-native.mp4

Add early path validation check in getOnboardingInitialPath to prioritize resuming existing onboarding paths on refresh instead of redirecting to personal-details. This ensures users remain on their current onboarding step when refreshing the page.

melvin-bot · 2025-07-24T00:53:40Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-07-24T05:13:12Z

+
+    if (onboardingInitialPath) {
+        const existingPathState = getStateFromPath(onboardingInitialPath, linkingConfig.config);
+        if (existingPathState?.routes?.at(-1)?.name === NAVIGATORS.ONBOARDING_MODAL_NAVIGATOR) {
+            return onboardingInitialPath;
+        }
+    }
+


Suggested change

if (onboardingInitialPath) {

const existingPathState = getStateFromPath(onboardingInitialPath, linkingConfig.config);

if (existingPathState?.routes?.at(-1)?.name === NAVIGATORS.ONBOARDING_MODAL_NAVIGATOR) {

return onboardingInitialPath;

}

}

if (onboardingInitialPath && state?.routes?.at(-1)?.name === NAVIGATORS.ONBOARDING_MODAL_NAVIGATOR) {

return onboardingInitialPath;

}

Nice catch, fixed

DylanDylann · 2025-07-24T09:31:51Z

cc @nabi-ebrahimi

github-actions · 2025-07-24T11:22:55Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

Simplify the logic in getOnboardingInitialPath by removing unnecessary checks for existing path state. Now, it directly validates the onboardingInitialPath against the current state, ensuring a more streamlined onboarding flow.

DylanDylann · 2025-07-25T06:57:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-07-25.at.14.02.14.mov

Android: mWeb Chrome

Screen.Recording.2025-07-25.at.14.01.31.mov

iOS: HybridApp

Screen.Recording.2025-07-25.at.14.03.23.mov

iOS: mWeb Safari

Screen.Recording.2025-07-25.at.13.59.36.mov

MacOS: Chrome / Safari

Screen.Recording.2025-07-25.at.13.54.23.mov

MacOS: Desktop

Screen.Recording.2025-07-25.at.13.58.16.mov

DylanDylann

LGTM

lakchote · 2025-07-25T13:34:18Z

@MobileMage merge main please to fix the spell check

…h-path-issue

MobileMage · 2025-07-27T19:20:02Z

@lakchote done

melvin-bot · 2025-07-29T09:36:49Z

Congrats, that's your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It's an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

OSBotify · 2025-07-29T09:47:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-31T12:17:38Z

🚀 Deployed to staging by https://github.com/lakchote in version: 9.1.88-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…esh-path-issue" This reverts commit 3edd54d, reversing changes made to 69d27c0.

github-actions · 2025-08-04T19:24:33Z

🚀 Deployed to production by https://github.com/grgia in version: 9.1.88-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MobileMage requested a review from a team as a code owner July 24, 2025 00:53

melvin-bot Bot requested review from DylanDylann and removed request for a team July 24, 2025 00:53

DylanDylann reviewed Jul 24, 2025

View reviewed changes

MobileMage force-pushed the fix/onboarding-refresh-path-issue branch 3 times, most recently from 13d1ac3 to 118a515 Compare July 24, 2025 11:38

Refactor onboarding initial path validation

2f7800b

Simplify the logic in getOnboardingInitialPath by removing unnecessary checks for existing path state. Now, it directly validates the onboardingInitialPath against the current state, ensuring a more streamlined onboarding flow.

MobileMage force-pushed the fix/onboarding-refresh-path-issue branch from 118a515 to 2f7800b Compare July 24, 2025 11:39

DylanDylann approved these changes Jul 25, 2025

View reviewed changes

melvin-bot Bot requested a review from lakchote July 25, 2025 07:05

lakchote approved these changes Jul 25, 2025

View reviewed changes

Merge remote-tracking branch 'origin/main' into fix/onboarding-refres…

30b55a9

…h-path-issue

lakchote merged commit 3edd54d into Expensify:main Jul 29, 2025

github-actions Bot mentioned this pull request Jul 31, 2025

Deploy Checklist: New Expensify 2025-07-31 #67499

Closed

90 tasks

jponikarchuk mentioned this pull request Aug 1, 2025

Onboarding - "What do you want to do today?" briefly appears when restarting #67649

Closed

8 tasks

nlemma mentioned this pull request Aug 1, 2025

[Needs Repro] Onboarding - OD tasks are appearing in the ND app after switching to it #67652

Closed

8 tasks

BlameGPT mentioned this pull request Aug 1, 2025

[$50 - RCA] Sign in-"Your session has expired" page displayed when signing in second time as new user #67605

Closed

8 tasks

rushatgabhane mentioned this pull request Aug 1, 2025

[CP Staging] Revert "Fix onboarding flow path changes after page refresh" #67699

Merged

grgia added a commit that referenced this pull request Aug 2, 2025

Revert "Merge pull request #67017 from MobileMage/fix/onboarding-refr…

1b537ec

…esh-path-issue" This reverts commit 3edd54d, reversing changes made to 69d27c0.

melvin-bot Bot mentioned this pull request Aug 4, 2025

[Due for payment 2025-08-11] [$250] Onboarding flow path changes after page refresh #65947

Closed

16 tasks

Navigation Menu

Uh oh!

Fix onboarding flow path changes after page refresh - #67017

Fix onboarding flow path changes after page refresh#67017
lakchote merged 3 commits into
Expensify:mainfrom
MobileMage:fix/onboarding-refresh-path-issue

MobileMage commented Jul 24, 2025

Uh oh!

melvin-bot Bot commented Jul 24, 2025

Uh oh!

DylanDylann Jul 24, 2025

Uh oh!

MobileMage Jul 24, 2025

Uh oh!

DylanDylann commented Jul 24, 2025

Uh oh!

github-actions Bot commented Jul 24, 2025 •

edited

Loading

Uh oh!

DylanDylann commented Jul 25, 2025 •

edited

Loading

Uh oh!

DylanDylann left a comment

Uh oh!

lakchote commented Jul 25, 2025

Uh oh!

MobileMage commented Jul 27, 2025

Uh oh!

melvin-bot Bot commented Jul 29, 2025

Uh oh!

OSBotify commented Jul 29, 2025

Uh oh!

github-actions Bot commented Jul 31, 2025

Uh oh!

github-actions Bot commented Aug 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

MobileMage commented Jul 24, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 24, 2025

Uh oh!

DylanDylann Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

MobileMage Jul 24, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Jul 24, 2025

Uh oh!

github-actions Bot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DylanDylann commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

lakchote commented Jul 25, 2025

Uh oh!

MobileMage commented Jul 27, 2025

Uh oh!

melvin-bot Bot commented Jul 29, 2025

Uh oh!

OSBotify commented Jul 29, 2025

Uh oh!

github-actions Bot commented Jul 31, 2025

Uh oh!

github-actions Bot commented Aug 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions Bot commented Jul 24, 2025 •

edited

Loading

DylanDylann commented Jul 25, 2025 •

edited

Loading