Expense - Negative sign disappears after moving expense with negative sign to self DM by thelullabyy · Pull Request #65920 · Expensify/App

thelullabyy · 2025-07-11T07:59:37Z

Explanation of Change

Fixed Issues

$ #64799
PROPOSAL: #64799 (comment)

Tests

Go to staging.expensify.com
Create a report with two expenses with negative amount.
Log in to staging.new.expensify.com with the same account.
Go to workspace chat.
Open the expense report from Step 2.
Click More > Delete.
Delete the report.
Go to self DM and open one of the unreported expenses.
Verify that the unreported expense doe retain its negative sign in the amount.
Open the same unreported expense on Old Dot.
On Old Dot, the same unreported expense retains its negative sign in the amount.
Go back to workspace chat on ND.
Click + > Create report.
Click Add expense > Add unreported expense.
Select any unreported expense from Step 8.
Click Add to report.
Open the expense preview.
The negative sign in the amount resurfaces after adding the unreported expense to a report.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to staging.expensify.com
Create a report with two expenses with negative amount.
Log in to staging.new.expensify.com with the same account.
Go to workspace chat.
Open the expense report from Step 2.
Click More > Delete.
Delete the report.
Go to self DM and open one of the unreported expenses.
Verify that the unreported expense doe retain its negative sign in the amount.
Open the same unreported expense on Old Dot.
On Old Dot, the same unreported expense retains its negative sign in the amount.
Go back to workspace chat on ND.
Click + > Create report.
Click Add expense > Add unreported expense.
Select any unreported expense from Step 8.
Click Add to report.
Open the expense preview.
The negative sign in the amount resurfaces after adding the unreported expense to a report.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_compressed.mp4

Android: mWeb Chrome

android_web.mov

iOS: Native

ios_compressed.mp4

iOS: mWeb Safari

ios_web_compressed.mp4

MacOS: Chrome / Safari

web-main.mp4

web_1_compressed.mp4

web_2.mp4

web_3.mp4

MacOS: Desktop

desktop_compressed.mp4

melvin-bot · 2025-07-11T09:21:28Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…9/negative-sign-expense

ikevin127 · 2025-07-11T18:13:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-hybrid.mp4

Android: mWeb Chrome

android-mweb.mp4

iOS: HybridApp

ios-hybrid.MP4

iOS: mWeb Safari

ios-mweb.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ikevin127 · 2025-07-11T23:40:03Z

    }
    if (Object.hasOwn(transactionChanges, 'amount') && typeof transactionChanges.amount === 'number') {
-        updatedTransaction.modifiedAmount = isFromExpenseReport ? -transactionChanges.amount : transactionChanges.amount;
-        shouldStopSmartscan = true;


@thelullabyy Not supposed to remove shouldStopSmartscan = true; from here, right ?

Thanks for noticing this. I've reverted the code

ikevin127 · 2025-07-11T23:45:37Z

        expect(expenseAmount).toBeLessThan(0);
    });
+
+    test('Return correct unreported transaction amount with negative sign', () => {


Suggested change

test('Return correct unreported transaction amount with negative sign', () => {

test('Unreported expense amount should retain negative sign', () => {

ikevin127 · 2025-07-12T00:22:50Z

@thelullabyy There are two other getTransactionAmount function calls in ReportUtils.ts which are responsible for displaying the amount where if we don't pass the 3rd argument (transaction?.reportID === CONST.REPORT.UNREPORTED_REPORT_ID) it won't retain / display the - negative sign, the 2 functions are:

getTransactionReportName for retaining negative amount in transaction report header

getReportPreviewMessage for retaining negative amount in LHN report preview message

Here's the Diff

diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts
index eb19633c453..91ee7e2e7d0 100644
--- a/src/libs/ReportUtils.ts
+++ b/src/libs/ReportUtils.ts
@@ -4469,7 +4469,7 @@ function getTransactionReportName({
     }
 
     const report = getReportOrDraftReport(transaction?.reportID, reports);
-    const amount = getTransactionAmount(transaction, !isEmptyObject(report) && isExpenseReport(report)) ?? 0;
+    const amount = getTransactionAmount(transaction, !isEmptyObject(report) && isExpenseReport(report), transaction?.reportID === CONST.REPORT.UNREPORTED_REPORT_ID) ?? 0;
     const formattedAmount = convertToDisplayString(amount, getCurrency(transaction)) ?? '';
     const comment = getMerchantOrDescription(transaction);
 
@@ -4524,7 +4524,7 @@ function getReportPreviewMessage(
                 return translateLocal('iou.receiptMissingDetails');
             }
 
-            const amount = getTransactionAmount(linkedTransaction, !isEmptyObject(report) && isExpenseReport(report)) ?? 0;
+            const amount = getTransactionAmount(linkedTransaction, !isEmptyObject(report) && isExpenseReport(report), linkedTransaction?.reportID === CONST.REPORT.UNREPORTED_REPORT_ID) ?? 0;
             const formattedAmount = convertToDisplayString(amount, getCurrency(linkedTransaction)) ?? '';
             return translateLocal('iou.didSplitAmount', {formattedAmount, comment: getMerchantOrDescription(linkedTransaction)});
         }
@@ -4546,7 +4546,7 @@ function getReportPreviewMessage(
                 return translateLocal('iou.receiptMissingDetails');
             }
 
-            const amount = getTransactionAmount(linkedTransaction, !isEmptyObject(report) && isExpenseReport(report)) ?? 0;
+            const amount = getTransactionAmount(linkedTransaction, !isEmptyObject(report) && isExpenseReport(report), linkedTransaction?.reportID === CONST.REPORT.UNREPORTED_REPORT_ID) ?? 0;
             const formattedAmount = convertToDisplayString(amount, getCurrency(linkedTransaction)) ?? '';
             return translateLocal('iou.trackedAmount', {formattedAmount, comment: getMerchantOrDescription(linkedTransaction)});
         }
@@ -9185,7 +9185,7 @@ function getIOUReportActionDisplayMessage(reportAction: OnyxEntry<ReportAction>,
         return translateLocal(translationKey, {amount: formattedAmount, payer: ''});
     }
 
-    const amount = getTransactionAmount(transaction, !isEmptyObject(iouReport) && isExpenseReport(iouReport)) ?? 0;
+    const amount = getTransactionAmount(transaction, !isEmptyObject(iouReport) && isExpenseReport(iouReport), transaction?.reportID === CONST.REPORT.UNREPORTED_REPORT_ID) ?? 0;
     const formattedAmount = convertToDisplayString(amount, getCurrency(transaction)) ?? '';
     const isRequestSettled = isSettled(IOUReportID);
     const isApproved = isReportApproved({report: iouReport});

how things look with the fix:

The other getTransactionAmount calls don't matter because they call Math.abs() on the amount later on, or they are sent to BE which should preserve current logic 👍

ikevin127 · 2025-07-13T01:27:35Z

🟢 Reviewer Checklist Completed

⏳ Awaiting for author to apply requested changes before reviewing again and Approving.

…9/negative-sign-expense

thelullabyy · 2025-07-14T02:37:33Z

@ikevin127 Thanks for your review, I've resolved & updated the code based on your suggestions. Please help check again.

About the failed test job 01, I believe it is the known issue due to flaky test
#65980

ikevin127

Thanks for the changes!

LGTM (the failing test seems unrelated to this PRs changes)

@thelullabyy I'd recommend to sync w/ main though, just to make sure you're up to date - otherwise there might be regressions reported even though they are not caused by this PRs changes.

…9/negative-sign-expense

ikevin127 · 2025-07-15T02:50:08Z

Not related to this PRs changes, but I noticed a bug while testing, which did not hit staging yet, reported it on Slack and will be handled by QA.

☝️That's why I suggested a sync with main, besides addressing the failed flaky unit test which seems to have been fixed, thanks for the sync. @youssef-lr We're good to merge here if everything looks good to you.

ikevin127 · 2025-07-15T21:25:25Z

@thelullabyy Can you solve the conflict before CME will get to this PR so we can avoid further delay ? Thanks!

github-actions · 2025-07-16T01:45:29Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

thelullabyy · 2025-07-16T01:55:42Z

@ikevin127 I have resolved the conflict. Pls check again

ikevin127 · 2025-07-16T01:57:41Z

Thanks, awaiting final review and merge from @youssef-lr

OSBotify · 2025-07-16T21:25:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-07-18T05:14:07Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.1.83-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-21T16:38:00Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.83-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

thelullabyy added 3 commits July 11, 2025 15:58

fix: negative sign unreported expense

13f08ed

fix: prettier

88eeb4b

fix: prettier

7d247fd

thelullabyy marked this pull request as ready for review July 11, 2025 09:21

thelullabyy requested a review from a team as a code owner July 11, 2025 09:21

melvin-bot Bot requested a review from ikevin127 July 11, 2025 09:21

melvin-bot Bot removed the request for review from a team July 11, 2025 09:21

thelullabyy marked this pull request as draft July 11, 2025 11:20

thelullabyy added 3 commits July 11, 2025 19:28

Merge branch 'main' of https://github.com/Expensify/App into fix/6479…

519dbcd

…9/negative-sign-expense

Merge branch 'main' of https://github.com/Expensify/App into fix/6479…

97f63bb

…9/negative-sign-expense

Merge branch 'main' of https://github.com/Expensify/App into fix/6479…

b3f30d9

…9/negative-sign-expense

thelullabyy marked this pull request as ready for review July 11, 2025 15:37

ikevin127 reviewed Jul 11, 2025

View reviewed changes

thelullabyy added 2 commits July 14, 2025 10:18

Merge branch 'main' of https://github.com/Expensify/App into fix/6479…

1b7fa95

…9/negative-sign-expense

fix: resolved comments

fea1592

ikevin127 approved these changes Jul 14, 2025

View reviewed changes

melvin-bot Bot requested a review from youssef-lr July 14, 2025 21:50

Merge branch 'main' of https://github.com/Expensify/App into fix/6479…

be22021

…9/negative-sign-expense

chore: merge main

5da0d43

thelullabyy requested a review from a team as a code owner July 16, 2025 01:45

chore: merge main

f3679a5

youssef-lr approved these changes Jul 16, 2025

View reviewed changes

youssef-lr merged commit 737f30f into Expensify:main Jul 16, 2025

github-actions Bot mentioned this pull request Jul 18, 2025

Deploy Checklist: New Expensify 2025-07-18 #66687

Closed

72 tasks done

melvin-bot Bot mentioned this pull request Jul 21, 2025

[Due for payment 2025-07-28] [$250] Expense - Negative sign disappears after moving expense with negative sign to self DM #64799

Closed

6 of 8 tasks

	test('Return correct unreported transaction amount with negative sign', () => {
	test('Unreported expense amount should retain negative sign', () => {

Conversation

thelullabyy commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 11, 2025

Uh oh!

ikevin127 commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ikevin127 Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

ikevin127 Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

thelullabyy Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

ikevin127 commented Jul 12, 2025

Uh oh!

ikevin127 commented Jul 13, 2025

🟢 Reviewer Checklist Completed

Uh oh!

thelullabyy commented Jul 14, 2025

Uh oh!

ikevin127 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ikevin127 commented Jul 15, 2025

Uh oh!

ikevin127 commented Jul 15, 2025

Uh oh!

github-actions Bot commented Jul 16, 2025

Uh oh!

thelullabyy commented Jul 16, 2025

Uh oh!

ikevin127 commented Jul 16, 2025

Uh oh!

OSBotify commented Jul 16, 2025

Uh oh!

github-actions Bot commented Jul 18, 2025

Uh oh!

github-actions Bot commented Jul 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

thelullabyy commented Jul 11, 2025 •

edited

Loading

ikevin127 commented Jul 11, 2025 •

edited

Loading

ikevin127 left a comment •

edited

Loading