Skip to content

Public domain user is able to hit the back button in onboarding modal and get dropped into Concierge with onboarding incomplete #65635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JS00001 merged 3 commits into from
Jul 17, 2025
Merged

Public domain user is able to hit the back button in onboarding modal and get dropped into Concierge with onboarding incomplete #65635

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b7d724
fix: onboarding issue
thelullabyy Jul 8, 2025
969431f
fix: update sol
thelullabyy Jul 8, 2025
a94fe7a
fix: update sol
thelullabyy Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,8 @@ function BaseOnboardingAccounting({shouldUseNativeStyles}: BaseOnboardingAccount
const isLoading = onboarding?.isLoading;
const prevIsLoading = usePrevious(isLoading);

const isVsb = onboarding?.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.VSB;

// Set onboardingPolicyID and onboardingAdminsChatReportID if a workspace is created by the backend for OD signup
useEffect(() => {
if (!paidGroupPolicy || onboardingPolicyID) {
Expand Down Expand Up @@ -319,7 +321,7 @@ function BaseOnboardingAccounting({shouldUseNativeStyles}: BaseOnboardingAccount
shouldEnableMaxHeight
>
<HeaderWithBackButton
shouldShowBackButton
shouldShowBackButton={!isVsb}
progressBarPercentage={80}
onBackButtonPress={() => Navigation.goBack(ROUTES.ONBOARDING_EMPLOYEES.getRoute())}
/>
Expand Down