Skip to content

Update report URL routes - #649

Merged
roryabraham merged 1 commit into
masterfrom
timszot_updateReportURLs
Oct 14, 2020
Merged

roryabraham merged 1 commit into
masterfrom
timszot_updateReportURLs

Conversation

@timszot

@timszot timszot commented Oct 14, 2020

Copy link
Copy Markdown
Contributor

Updates the report routes to from /report/1234 to /r/1234.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/143123

Tests

npm run web and checked URLs for various chats and DMs for dev.

QA: Log into chat.expensify.com and confirm URLs for chats and DMs are in format https://chat.expensify.com/#/r/12345

@timszot
timszot requested a review from a team October 14, 2020 17:11
@timszot timszot self-assigned this Oct 14, 2020
@botify
botify requested review from roryabraham and removed request for a team October 14, 2020 17:11

@roryabraham roryabraham left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@roryabraham
roryabraham merged commit efdb025 into master Oct 14, 2020
@roryabraham
roryabraham deleted the timszot_updateReportURLs branch October 14, 2020 20:24
yuwenmemon added a commit that referenced this pull request Mar 12, 2024
[CP Staging] Revert expensify-common #649 from version used on App
OSBotify pushed a commit that referenced this pull request Mar 12, 2024
[CP Staging] Revert expensify-common #649 from version used on App

(cherry picked from commit 1bc9c35)
sajal101agrawal pushed a commit to sajal101agrawal/expensify-app that referenced this pull request Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants