[Distance Tracking] Add navigation options by allroundexperts · Pull Request #64771 · Expensify/App

allroundexperts · 2025-06-23T22:38:35Z

Explanation of Change

This PR adds the Track Distance option to the global fab and the expense report fab.

Fixed Issues

$ #64365
PROPOSAL: N/A

Tests

Login to any account and turn on the MANUAL_DISTANCE beta.
Click on the global fab and click the Create Expense option. Verify that you can not see the Distance tab.
Click on the global fab, and verify that you see a Track Distance option.
Go to any expense chat and click on the chat's + button. Verify that you can see Track Distance option.
Turn the beta off. Verify that the Track Distance option does not appear in the above two places.
Click on the global fab and click the Create Expense option. Verify that you can see the Distance tab.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Login to any account and turn on the MANUAL_DISTANCE beta.
Click on the global fab and click the Create Expense option. Verify that you can not see the Distance tab.
Click on the global fab, and verify that you see a Track Distance option.
Go to any expense chat and click on the chat's + button. Verify that you can see Track Distance option.
Turn the beta off. Verify that the Track Distance option does not appear in the above two places.
Click on the global fab and click the Create Expense option. Verify that you can see the Distance tab.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Unable to build android

Android: mWeb Chrome

Screen.Recording.2025-06-25.at.2.07.50.AM.mov

iOS: Native

Screen.Recording.2025-06-25.at.2.05.34.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-06-25.at.1.24.02.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-06-25.at.1.19.54.AM.mov

MacOS: Desktop

Screen.Recording.2025-06-25.at.1.22.22.AM.mov

melvin-bot · 2025-06-24T21:16:19Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2025-06-25T15:04:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

trackDistanceAndroid.mov

Android: mWeb Chrome

trackDistanceAndroidmWeb.mov

iOS: HybridApp

trackDistanceiOS.mov

iOS: mWeb Safari

trackDistanceiOSmWeb.mov

MacOS: Chrome / Safari

trackDistanceChrome.mov

MacOS: Desktop

trackDistanceDesktop.mov

c3024 · 2025-06-25T15:10:26Z

NIT:

Order of "Create Expense", "Create Report" and "Track Distance" are different in FAB and Attachment picker.

c3024

LGTM!

melvin-bot · 2025-06-25T15:23:22Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #64365 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

OSBotify · 2025-06-26T00:24:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-27T23:44:35Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.1.72-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-27T23:56:30Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 9.1.72-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

shubham1206agra · 2025-06-29T04:09:07Z

-                                        </TabScreenWithFocusTrapWrapper>
-                                    )}
-                                </TopTab.Screen>
+                                {!manualDistanceTrackingEnabled && (


@allroundexperts Can you tell why this was put in place here?

+1, Seems to have caused #65128

This was put in because of a new feature that we're working on. But this is behind a beta, so should not have any effect on the App.

@allroundexperts This placement seems to be too early. Since there is no logic related to manual distance tracking yet.

github-actions · 2025-06-30T22:20:26Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.72-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

allroundexperts added 2 commits June 24, 2025 03:30

add nav options for tracking distance

214551e

Merge branch 'main' into feat-64365

caf3702

allroundexperts marked this pull request as ready for review June 24, 2025 21:16

allroundexperts requested a review from a team as a code owner June 24, 2025 21:16

melvin-bot Bot requested review from c3024 and removed request for a team June 24, 2025 21:16

add translations

50f09df

allroundexperts mentioned this pull request Jun 24, 2025

[Due for payment 2025-07-08] [$250] Add "Track distance" to global create #64365

Closed

add all translations

e17f02a

c3024 approved these changes Jun 25, 2025

View reviewed changes

melvin-bot Bot requested a review from chiragsalian June 25, 2025 15:23

allroundexperts added 2 commits June 26, 2025 01:42

Merge branch 'main' into feat-64365

0f3b7d8

change order

fdaca10

chiragsalian approved these changes Jun 26, 2025

View reviewed changes

chiragsalian merged commit 6b934d1 into Expensify:main Jun 26, 2025

github-actions Bot mentioned this pull request Jun 27, 2025

Deploy Checklist: New Expensify 2025-06-27 #65114

Closed

shubham1206agra reviewed Jun 29, 2025

View reviewed changes

inimaga mentioned this pull request Jun 30, 2025

[Due for payment 2025-07-08][$250] Expense - App crashes after creating per diem expense in one workspace and opening create flow #65151

Closed

6 of 8 tasks

BlameGPT mentioned this pull request Jun 30, 2025

Split expense - Distance expense option is missing in split expenses #65128

Closed

3 of 8 tasks

Navigation Menu

[Distance Tracking] Add navigation options - #64771

[Distance Tracking] Add navigation options#64771
chiragsalian merged 6 commits into
Expensify:mainfrom
allroundexperts:feat-64365

allroundexperts commented Jun 23, 2025 •

edited

Loading

Uh oh!

melvin-bot Bot commented Jun 24, 2025

Uh oh!

c3024 commented Jun 25, 2025 •

edited

Loading

Uh oh!

c3024 commented Jun 25, 2025

Uh oh!

c3024 left a comment

Uh oh!

melvin-bot Bot commented Jun 25, 2025

Uh oh!

OSBotify commented Jun 26, 2025

Uh oh!

github-actions Bot commented Jun 27, 2025

Uh oh!

github-actions Bot commented Jun 27, 2025

Uh oh!

shubham1206agra Jun 29, 2025

Uh oh!

MonilBhavsar Jun 30, 2025

Uh oh!

allroundexperts Jun 30, 2025

Uh oh!

shubham1206agra Jun 30, 2025

Uh oh!

github-actions Bot commented Jun 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

allroundexperts commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 24, 2025

Uh oh!

c3024 commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 commented Jun 25, 2025

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jun 25, 2025

Uh oh!

OSBotify commented Jun 26, 2025

Uh oh!

github-actions Bot commented Jun 27, 2025

Uh oh!

github-actions Bot commented Jun 27, 2025

Uh oh!

shubham1206agra Jun 29, 2025

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

allroundexperts Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Jun 30, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

allroundexperts commented Jun 23, 2025 •

edited

Loading

c3024 commented Jun 25, 2025 •

edited

Loading