Skip to content

[CP Staging] Revert "fix: missing credentials during reauthentication" - #63988

Merged
mountiny merged 1 commit into
mainfrom
revert-63773-pac-guerreiro/fix/missing-credentials-during-reauthentication
Jun 11, 2025
Merged

[CP Staging] Revert "fix: missing credentials during reauthentication"#63988
mountiny merged 1 commit into
mainfrom
revert-63773-pac-guerreiro/fix/missing-credentials-during-reauthentication

Conversation

@techievivek

@techievivek techievivek commented Jun 11, 2025 •
edited by mountiny
Loading

Copy link
Copy Markdown
Contributor

Reverts #63773

Fixes #63914

cc @pac-guerreiro

@techievivek techievivek self-assigned this Jun 11, 2025
@techievivek
techievivek requested a review from a team as a code owner June 11, 2025 15:02
@melvin-bot
melvin-bot Bot requested review from youssef-lr and removed request for a team June 11, 2025 15:03
@melvin-bot

melvin-bot Bot commented Jun 11, 2025

Copy link
Copy Markdown

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@techievivek
techievivek requested review from mountiny and removed request for youssef-lr June 11, 2025 15:03
@mountiny mountiny changed the title Revert "fix: missing credentials during reauthentication" [CP Staging] Revert "fix: missing credentials during reauthentication" Jun 11, 2025
mountiny
mountiny approved these changes Jun 11, 2025
View reviewed changes

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mountiny
mountiny merged commit d01868a into main Jun 11, 2025
@mountiny
mountiny deleted the revert-63773-pac-guerreiro/fix/missing-credentials-during-reauthentication branch June 11, 2025 15:05
@techievivek techievivek added the CP Staging marks PRs that have been CP'd to staging label Jun 11, 2025
@melvin-bot melvin-bot Bot added Emergency and removed CP Staging marks PRs that have been CP'd to staging labels Jun 11, 2025
@melvin-bot

melvin-bot Bot commented Jun 11, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny

mountiny commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

Straight revert

OSBotify pushed a commit that referenced this pull request Jun 11, 2025
@mountiny @OSBotify
Merge pull request #63988 from Expensify/revert-63773-pac-guerreiro/f…
ed5c944 
…ix/missing-credentials-during-reauthentication

[CP Staging] Revert "fix: missing credentials during reauthentication"

(cherry picked from commit d01868a)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jun 11, 2025
@github-actions github-actions Bot mentioned this pull request Jun 11, 2025
Closed
82 tasks
@OSBotify

OSBotify commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@pac-guerreiro pac-guerreiro mentioned this pull request Jun 11, 2025
Merged
49 tasks
@github-actions

github-actions Bot commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.64-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions

github-actions Bot commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.64-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mountiny mountiny mountiny approved these changes

Assignees

@techievivek techievivek

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Login - Unable to log in after closing account

3 participants

@techievivek @mountiny @OSBotify