fix: ComposeBox - When you click on the mention again, extra characters appear. by Krishna2323 · Pull Request #63843 · Expensify/App

Krishna2323 · 2025-06-10T12:39:26Z

Explanation of Change

Fixed Issues

$ #60804
PROPOSAL: #60804 (comment)

Tests

Go to workspace chat.
In the compose box, type “@”.
Select any user from the list or manually enter a username.
Click in the middle of the username within the mention.
In the window that appears, click on the same user again.
Verify that when you click on the mention again, the cursor is placed after the mention and no extra characters are added.
In the compose box, type “#”
Select any option from the list
Click in the middle of the option within the mention.
In the window that appears, click on the same user again.
Verify that when you click on the mention again, the cursor is placed after the mention and no extra characters are added.
Search a user by display name with last name > search "@firstname Lastname"
Select the user from mention suggestion window
Verify Display name is replaced by the email/login

Verify that no errors appear in the JS console

Offline tests

Go to workspace chat.
In the compose box, type “@”.
Select any user from the list or manually enter a username.
Click in the middle of the username within the mention.
In the window that appears, click on the same user again.
Verify that when you click on the mention again, the cursor is placed after the mention and no extra characters are added.
In the compose box, type “#”
Select any option from the list
Click in the middle of the option within the mention.
In the window that appears, click on the same user again.
Verify that when you click on the mention again, the cursor is placed after the mention and no extra characters are added.
Search a user by display name with last name > search "@firstname Lastname"
Select the user from mention suggestion window
Verify Display name is replaced by the email/login

QA Steps

Go to workspace chat.
In the compose box, type “@”.
Select any user from the list or manually enter a username.
Click in the middle of the username within the mention.
In the window that appears, click on the same user again.
Verify that when you click on the mention again, the cursor is placed after the mention and no extra characters are added.
In the compose box, type “#”
Select any option from the list
Click in the middle of the option within the mention.
In the window that appears, click on the same user again.
Verify that when you click on the mention again, the cursor is placed after the mention and no extra characters are added.
Search a user by display name with last name > search "@firstname Lastname"
Select the user from mention suggestion window
Verify Display name is replaced by the email/login

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

…rs appear. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-06-11T17:46:26Z

@hoangzinh, I was recording the videos, but unfortunately, I found one edge case that I need to resolve. I’ll provide updates again as soon as I find a solution for it.

Monosnap.screencast.2025-06-11.23-09-59.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2025-06-12T22:10:11Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2025-06-12T22:11:52Z

@hoangzinh, this is ready for review. Please take some time to test it thoroughly—there might be some edge cases I missed during my testing, though I tried to cover all possible scenarios.

hoangzinh · 2025-06-14T04:01:15Z

+    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
+    return (str.match(/ /g) || []).length;


Suggested change

// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing

return (str.match(/ /g) || []).length;

return (str.match(/ /g) ?? []).length;

Is there any case that we need to use ||?

updated to "??".

hoangzinh · 2025-06-14T04:04:41Z

+        if (whiteSpacesLength) {
+            const str = rest.split(' ', whiteSpacesLength + 1).join(' ');
+            return rest.slice(0, str.length);
+        }
+
+        const breakerIndex = rest.search(CONST.REGEX.MENTION_BREAKER);
+        return breakerIndex === -1 ? rest : rest.slice(0, breakerIndex);


Can you add comments for that logic, please?, it's kind of tricky

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hoangzinh · 2025-06-15T22:53:40Z

@Krishna2323 can you resolve conflict?

hoangzinh · 2025-06-17T23:06:57Z

@Krishna2323 can you resoilve conflict please?

Krishna2323 · 2025-06-18T03:33:36Z

@hoangzinh, sorry for delay, I'm on a trek and don't have my laptop RN. I'll resolve conflicts by EOD tomorrow.

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hoangzinh · 2025-06-23T11:13:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-06-23.at.18.23.22.android.mov

Android: mWeb Chrome

Screen.Recording.2025-06-23.at.18.25.39.android.chrome.mov

iOS: HybridApp

Screen.Recording.2025-06-23.at.18.28.12.mov

iOS: mWeb Safari

Screen.Recording.2025-06-23.at.18.29.45.mov

MacOS: Chrome / Safari

Screen.Recording.2025-06-23.at.18.18.34.web.mov

MacOS: Desktop

Screen.Recording.2025-06-23.at.18.26.27.desktop.mov

hoangzinh

LGTM

dangrous

Okay, this is looking good! A couple questions:

Have we tested this against all of the deploy blockers that required revert?
Do we need to count all whitespace characters (\s) or just single spaces? If it's only single spaces, let's update the names to countSpaces instead of countWhiteSpaces etc. But, if we need to count all whitespace, we need to update the str.match on L156 to /\s/g

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2025-06-24T10:25:04Z

@dangrous, both deploy blockers have been tested and we need to count all whitespace, I have updated str.match on L156 to /\s/g.

hoangzinh · 2025-06-24T11:46:42Z

Have we tested this against all of the deploy blockers that required revert?

Yes, @dangrous. They're included in testing steps of this PR.

dangrous

Thanks! This LGTM - do you want to give one more quick test after the update, @hoangzinh, or should we be set?

dangrous · 2025-06-26T17:07:35Z

I'm going to go ahead and merge, I think we should be good here.

OSBotify · 2025-06-26T17:17:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

hoangzinh · 2025-06-26T22:09:17Z

oh I missed your message. Yes, hoping

github-actions · 2025-06-27T23:43:35Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.72-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

hoangzinh · 2025-06-27T23:48:39Z

🙏

github-actions · 2025-06-27T23:55:30Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.72-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-30T22:19:26Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.72-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

Krishna2323 added 4 commits June 10, 2025 18:03

fix: ComposeBox - When you click on the mention again, extra characte…

6da8278

…rs appear. Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix slice length for comment after mention.

0438326

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix comment after mention removal.

19b6e07

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix: text after mention is removed.

de284a6

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 added 4 commits June 13, 2025 00:39

fix ESLint.

dbaf185

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

fix text not removed after adding mention by using display name.

608aa70

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'main' into krishna2323/issue/60804_pr3

c3072e6

minor fix.

02c8748

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 marked this pull request as ready for review June 12, 2025 22:10

Krishna2323 requested a review from a team as a code owner June 12, 2025 22:10

melvin-bot Bot requested review from hoangzinh and removed request for a team June 12, 2025 22:10

hoangzinh reviewed Jun 14, 2025

View reviewed changes

add comment.

27e380c

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

resolve conflicts.

5c78f1a

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 force-pushed the krishna2323/issue/60804_pr3 branch from 16dab86 to 5c78f1a Compare June 19, 2025 12:19

Krishna2323 added 3 commits June 19, 2025 17:50

resolve conflicts.

ea7db95

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/60804_pr3

53306b7

add changes in new files.

4801d26

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hoangzinh reviewed Jun 20, 2025

View reviewed changes

Comment thread src/pages/home/report/ReportActionCompose/SuggestionMention.tsx Outdated

fix spell check.

9fd6e1a

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

hoangzinh approved these changes Jun 23, 2025

View reviewed changes

melvin-bot Bot requested a review from dangrous June 23, 2025 11:31

dangrous reviewed Jun 23, 2025

View reviewed changes

Krishna2323 added 2 commits June 24, 2025 15:47

Merge branch 'Expensify:main' into krishna2323/issue/60804_pr3

f729c6b

minor fix.

9d13cba

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

dangrous approved these changes Jun 24, 2025

View reviewed changes

dangrous merged commit 4d46c6f into Expensify:main Jun 26, 2025

github-actions Bot mentioned this pull request Jun 27, 2025

Deploy Checklist: New Expensify 2025-06-27 #65114

Closed

hoangzinh mentioned this pull request Jul 1, 2025

[Due for payment 2025-07-07] [$250] ComposeBox - When you click on the mention again, extra characters appear #60804

Closed

8 tasks

		// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
		return (str.match(/ /g) \|\| []).length;

	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	return (str.match(/ /g) \|\| []).length;
	return (str.match(/ /g) ?? []).length;

Conversation

Krishna2323 commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Jun 11, 2025

Uh oh!

melvin-bot Bot commented Jun 12, 2025

Uh oh!

Krishna2323 commented Jun 12, 2025

Uh oh!

hoangzinh Jun 14, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Jun 15, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh Jun 14, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Jun 15, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Jun 15, 2025

Uh oh!

hoangzinh commented Jun 17, 2025

Uh oh!

Krishna2323 commented Jun 18, 2025

Uh oh!

Uh oh!

hoangzinh commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Jun 24, 2025

Uh oh!

hoangzinh commented Jun 24, 2025

Uh oh!

dangrous left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dangrous commented Jun 26, 2025

Uh oh!

OSBotify commented Jun 26, 2025

Uh oh!

hoangzinh commented Jun 26, 2025

Uh oh!

github-actions Bot commented Jun 27, 2025

Uh oh!

hoangzinh commented Jun 27, 2025

Uh oh!

github-actions Bot commented Jun 27, 2025

Uh oh!

github-actions Bot commented Jun 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Krishna2323 commented Jun 10, 2025 •

edited

Loading

hoangzinh commented Jun 23, 2025 •

edited

Loading

dangrous left a comment •

edited

Loading