Skip to content

[CP Staging] Fix hold message is not displayed under expense row after holding expense from RHP #63828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 3 commits into from
Jun 10, 2025
Merged

[CP Staging] Fix hold message is not displayed under expense row after holding expense from RHP #63828

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3ee62d
fix hold violations not showing
SzymczakJ Jun 10, 2025
5f6f240
fix eslint
SzymczakJ Jun 10, 2025
e72d6c6
Merge branch 'main' into @szymczak/fix-TransactionItemRow-bugs
SzymczakJ Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions src/components/TransactionItemRow/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ import TagCell from './DataCells/TagCell';
import TaxCell from './DataCells/TaxCell';
import TotalCell from './DataCells/TotalCell';
import TypeCell from './DataCells/TypeCell';
import TransactionItemRowRBR from './TransactionItemRowRBR';
import TransactionItemRowRBRWithOnyx from './TransactionItemRowRBRWithOnyx';

type ColumnComponents = {
Expand Down Expand Up @@ -441,18 +440,10 @@ function TransactionItemRow({
</View>
{columns?.map((column) => columnComponent[column])}
</View>
{}
{isInReportTableView ? (
<TransactionItemRowRBRWithOnyx
transaction={transactionItem}
missingFieldError={missingFieldError}
/>
) : (
<TransactionItemRowRBR
transactionViolations={transactionItem.violations}
missingFieldError={missingFieldError}
/> // We are rendering this component only if we are not in the report table view for performance reasons
)}
<TransactionItemRowRBRWithOnyx
transaction={transactionItem}
missingFieldError={missingFieldError}
/>
</View>
</Animated.View>
)}
Expand Down