Skip to content

Fix useTransactionViolations returning stale violations data #63722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rlinoz merged 6 commits into from
Jun 19, 2025
Merged

Fix useTransactionViolations returning stale violations data #63722

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
548356a
using get collection data instead of key preventing stale data
mollfpr Jun 7, 2025
7010d78
fix eslint
mollfpr Jun 9, 2025
e321238
revert changes
mollfpr Jun 11, 2025
82be18a
use custom wrapper for useOnyx
mollfpr Jun 11, 2025
ea4eb8d
Merge branch 'main' of github.com:Expensify/App into mollfpr-fix-stal…
mollfpr Jun 18, 2025
bd18c08
fix check failure
mollfpr Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/hooks/useTransactionViolations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
import {useMemo} from 'react';
import {useOnyx} from 'react-native-onyx';
import {isViolationDismissed} from '@libs/TransactionUtils';
import ONYXKEYS from '@src/ONYXKEYS';
import type {TransactionViolations} from '@src/types/onyx';
import useOnyx from './useOnyx';

function useTransactionViolations(transactionID?: string): TransactionViolations {
const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`);
const [transactionViolations = []] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`);
const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, {
canBeMissing: true,
});
const [transactionViolations = []] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transactionID}`, {
canBeMissing: true,
});
Comment on lines -8 to +13

@rlinoz rlinoz Jun 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im a little confused, it looks like the PR description doesn't seem to line up with the changes? It looks like we are just adding the canBeMissing but why?

@shubham1206agra shubham1206agra Jun 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rlinoz It was not updated, but the actual update is https://expensify.slack.com/archives/C05LX9D6E07/p1749519744150989. TLDR - We are now using a custom useOnyx hook to resolve this issue.

@rlinoz rlinoz Jun 19, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaah we changed the import and are using a different useOnyx, got it. Thanks!


return useMemo(() => transactionViolations.filter((violation) => !isViolationDismissed(transaction, violation)), [transaction, transactionViolations]);
}

Expand Down