Skip to content

[NoQA] Pass cardID in createDigitalWallet api call #63657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 1 commit into from
Jun 10, 2025
Merged

[NoQA] Pass cardID in createDigitalWallet api call #63657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libs/API/parameters/CreateDigitalWalletParams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ type CreateDigitalGoogleWalletParams = {
appVersion: string;
walletAccountID: string;
deviceID: string;
cardID: number;
};

type CreateDigitalWalletParams = CreateDigitalAppleWalletParams | CreateDigitalGoogleWalletParams;
Expand Down
2 changes: 1 addition & 1 deletion src/libs/Wallet/index.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ function checkIfWalletIsAvailable(): Promise<boolean> {

function handleAddCardToWallet(card: Card, cardHolderName: string): Promise<TokenizationStatus> {
return getSecureWalletInfo().then((walletData: AndroidWalletData) =>
createDigitalGoogleWallet({cardHolderName, ...walletData}).then((cardData: AndroidCardData) => addCardToGoogleWallet(cardData)),
createDigitalGoogleWallet({cardID: card.cardID, cardHolderName, ...walletData}).then((cardData: AndroidCardData) => addCardToGoogleWallet(cardData)),
);
}

Expand Down
13 changes: 12 additions & 1 deletion src/libs/actions/Wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,13 +279,24 @@ function issuerEncryptPayloadCallback(nonce: string, nonceSignature: string, cer
* @param walletAccountID ID of the wallet on user's phone
* @param deviceID ID of user's phone
*/
function createDigitalGoogleWallet({walletAccountID, deviceID, cardHolderName}: {deviceID: string; walletAccountID: string; cardHolderName: string}): Promise<AndroidCardData> {
function createDigitalGoogleWallet({
walletAccountID,
deviceID,
cardID,
cardHolderName,
}: {
deviceID: string;
walletAccountID: string;
cardID: number;
cardHolderName: string;
}): Promise<AndroidCardData> {
// eslint-disable-next-line rulesdir/no-api-side-effects-method
return API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.CREATE_DIGITAL_WALLET, {
platform: 'android',
appVersion: pkg.version,
walletAccountID,
deviceID,
cardID,
})
.then((response) => {
const data = response as unknown as ProvisioningCardData;
Expand Down