Skip to content

fix: add padding bottom for private notes list page #63586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Beamanator merged 2 commits into from
Jun 6, 2025
Merged

fix: add padding bottom for private notes list page #63586

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
439d26e
fix: add padding bottom for private notes list page
daledah Jun 5, 2025
3e42326
fix: lint
daledah Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/pages/PrivateNotes/PrivateNotesListPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ type NoteListItem = {
function PrivateNotesListPage({report, accountID: sessionAccountID}: PrivateNotesListPageProps) {
const route = useRoute<PlatformStackRouteProp<PrivateNotesNavigatorParamList, typeof SCREENS.PRIVATE_NOTES.LIST>>();
const backTo = route.params.backTo;
const [personalDetailsList] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST);
const [personalDetailsList] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {canBeMissing: false});
const styles = useThemeStyles();
const {translate} = useLocalize();
const getAttachmentValue = useCallback((item: NoteListItem) => ({reportID: item.reportID, accountID: Number(item.accountID), type: CONST.ATTACHMENT_TYPE.NOTE}), []);
Expand Down Expand Up @@ -88,10 +88,7 @@ function PrivateNotesListPage({report, accountID: sessionAccountID}: PrivateNote
}, [report, personalDetailsList, sessionAccountID, translate, backTo]);

return (
<ScreenWrapper
includeSafeAreaPaddingBottom={false}
testID={PrivateNotesListPage.displayName}
>
<ScreenWrapper testID={PrivateNotesListPage.displayName}>
<HeaderWithBackButton
title={translate('privateNotes.title')}
shouldShowBackButton
Expand Down