Skip to content

Add (you) to yourself in the 'from' dropdown #63435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JS00001 merged 3 commits into from
Jun 6, 2025
Merged

Add (you) to yourself in the 'from' dropdown #63435

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6fb395
fix you problem
JS00001 Jun 4, 2025
4b27474
remove user domain stripping
JS00001 Jun 6, 2025
a025c57
Merge branch 'main' of github.com:Expensify/App into jsenyitko-add-(you)
JS00001 Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/components/SelectionList/Search/UserSelectionListItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import useStyleUtils from '@hooks/useStyleUtils';
import useTheme from '@hooks/useTheme';
import useThemeStyles from '@hooks/useThemeStyles';
import {areEmailsFromSamePrivateDomain} from '@libs/LoginUtils';
import {getDisplayNameForParticipant} from '@libs/ReportUtils';
import CONST from '@src/CONST';

function UserSelectionListItem<TItem extends ListItem>({
Expand Down Expand Up @@ -56,6 +57,13 @@ function UserSelectionListItem<TItem extends ListItem>({
return login.split('@').at(0);
}, [currentUserPersonalDetails.login, item.login]);

const userDisplayName = useMemo(() => {
return getDisplayNameForParticipant({
accountID: item.accountID ?? CONST.DEFAULT_NUMBER_ID,
shouldAddCurrentUserPostfix: true,
});
}, [item.accountID]);

return (
<BaseListItem
item={item}
Expand Down Expand Up @@ -92,7 +100,7 @@ function UserSelectionListItem<TItem extends ListItem>({
<View style={[styles.flex1, styles.flexRow, styles.gap2, styles.flexShrink1, styles.alignItemsCenter]}>
<TextWithTooltip
shouldShowTooltip={showTooltip}
text={Str.removeSMSDomain(item.text ?? '')}
text={userDisplayName}
style={[styles.flexShrink0, styles.optionDisplayName, isFocused ? styles.sidebarLinkActiveText : styles.sidebarLinkText, styles.sidebarLinkTextBold, styles.pre]}
/>
{!!userHandle && (
Expand Down