fix translate error message for bank account deletion into Spanish - #63410
Merged
marcochavezf merged 3 commits intoJun 10, 2025
Conversation
Contributor
|
@huult Is the copy confirmed by the team? |
Contributor
Author
Contributor
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2025-06-04.at.1.27.29.PM.mov |
Contributor
marcochavezf
requested changes
Jun 4, 2025
| validationAmounts: 'The validation amounts you entered are incorrect. Please double check your bank statement and try again.', | ||
| fullName: 'Please enter a valid full name', | ||
| ownershipPercentage: 'Please enter a valid percentage number', | ||
| deletePaymentBankAccount: |
Contributor
There was a problem hiding this comment.
Given that we're getting the copy from the backend, let's double check with the team #62778 (comment)
This comment was marked as outdated.
This comment was marked as outdated.
…or-message-bank-account-deletion-spanish
Contributor
|
I doubled checked the copy with ChatGTP and looks fine against the existing ones |
marcochavezf
approved these changes
Jun 10, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
82 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.1.64-0 🚀
|
8 tasks
50 tasks
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.64-5 🚀
|
8 tasks
Contributor
Testrails Regression ChecklistThe following test cases must be verified by reviewers:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Details
Fixed Issues
$ #62778
PROPOSAL: #62778 (comment)
Tests
Same QA step
Offline tests
QA Steps
Precondition:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-06-04.at.08.54.36.mp4
Android: mWeb Chrome
Screen.Recording.2025-06-04.at.08.48.51.mp4
iOS: Native
Screen.Recording.2025-06-04.at.08.55.49.mp4
iOS: mWeb Safari
Screen.Recording.2025-06-04.at.08.50.24.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-06-04.at.08.45.36.mp4
MacOS: Desktop
Screen.Recording.2025-06-04.at.08.51.01.mp4